diff options
author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-04-25 17:48:50 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-04-25 17:48:50 -0400 |
commit | 32279240abab6fe2d2399cea303d040f03fbc32c (patch) | |
tree | ae86b954f32f2a5f8139ecc89c77505226d5977f /drivers/net/irda | |
parent | 6f0d27ff97f66c041e2adc86b61e8957e8dd056d (diff) |
USB: ks959-sir.c: remove err() usage
err() was a very old USB-specific macro that I thought had
gone away. This patch removes it from being used in the
driver and uses dev_err() instead.
CC: Samuel Ortiz <samuel@sortiz.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/net/irda')
-rw-r--r-- | drivers/net/irda/ks959-sir.c | 31 |
1 files changed, 19 insertions, 12 deletions
diff --git a/drivers/net/irda/ks959-sir.c b/drivers/net/irda/ks959-sir.c index abe689dffc72..824e2a93fe8a 100644 --- a/drivers/net/irda/ks959-sir.c +++ b/drivers/net/irda/ks959-sir.c | |||
@@ -247,8 +247,9 @@ static void ks959_speed_irq(struct urb *urb) | |||
247 | { | 247 | { |
248 | /* unlink, shutdown, unplug, other nasties */ | 248 | /* unlink, shutdown, unplug, other nasties */ |
249 | if (urb->status != 0) { | 249 | if (urb->status != 0) { |
250 | err("ks959_speed_irq: urb asynchronously failed - %d", | 250 | dev_err(&urb->dev->dev, |
251 | urb->status); | 251 | "ks959_speed_irq: urb asynchronously failed - %d\n", |
252 | urb->status); | ||
252 | } | 253 | } |
253 | } | 254 | } |
254 | 255 | ||
@@ -332,14 +333,16 @@ static void ks959_send_irq(struct urb *urb) | |||
332 | 333 | ||
333 | /* in process of stopping, just drop data */ | 334 | /* in process of stopping, just drop data */ |
334 | if (!netif_running(kingsun->netdev)) { | 335 | if (!netif_running(kingsun->netdev)) { |
335 | err("ks959_send_irq: Network not running!"); | 336 | dev_err(&kingsun->usbdev->dev, |
337 | "ks959_send_irq: Network not running!\n"); | ||
336 | return; | 338 | return; |
337 | } | 339 | } |
338 | 340 | ||
339 | /* unlink, shutdown, unplug, other nasties */ | 341 | /* unlink, shutdown, unplug, other nasties */ |
340 | if (urb->status != 0) { | 342 | if (urb->status != 0) { |
341 | err("ks959_send_irq: urb asynchronously failed - %d", | 343 | dev_err(&kingsun->usbdev->dev, |
342 | urb->status); | 344 | "ks959_send_irq: urb asynchronously failed - %d\n", |
345 | urb->status); | ||
343 | return; | 346 | return; |
344 | } | 347 | } |
345 | 348 | ||
@@ -358,8 +361,9 @@ static void ks959_send_irq(struct urb *urb) | |||
358 | if (kingsun->tx_buf_clear_used > 0) { | 361 | if (kingsun->tx_buf_clear_used > 0) { |
359 | /* There is more data to be sent */ | 362 | /* There is more data to be sent */ |
360 | if ((ret = ks959_submit_tx_fragment(kingsun)) != 0) { | 363 | if ((ret = ks959_submit_tx_fragment(kingsun)) != 0) { |
361 | err("ks959_send_irq: failed tx_urb submit: %d", | 364 | dev_err(&kingsun->usbdev->dev, |
362 | ret); | 365 | "ks959_send_irq: failed tx_urb submit: %d\n", |
366 | ret); | ||
363 | switch (ret) { | 367 | switch (ret) { |
364 | case -ENODEV: | 368 | case -ENODEV: |
365 | case -EPIPE: | 369 | case -EPIPE: |
@@ -407,7 +411,8 @@ static netdev_tx_t ks959_hard_xmit(struct sk_buff *skb, | |||
407 | kingsun->tx_buf_clear_used = wraplen; | 411 | kingsun->tx_buf_clear_used = wraplen; |
408 | 412 | ||
409 | if ((ret = ks959_submit_tx_fragment(kingsun)) != 0) { | 413 | if ((ret = ks959_submit_tx_fragment(kingsun)) != 0) { |
410 | err("ks959_hard_xmit: failed tx_urb submit: %d", ret); | 414 | dev_err(&kingsun->usbdev->dev, |
415 | "ks959_hard_xmit: failed tx_urb submit: %d\n", ret); | ||
411 | switch (ret) { | 416 | switch (ret) { |
412 | case -ENODEV: | 417 | case -ENODEV: |
413 | case -EPIPE: | 418 | case -EPIPE: |
@@ -442,8 +447,9 @@ static void ks959_rcv_irq(struct urb *urb) | |||
442 | 447 | ||
443 | /* unlink, shutdown, unplug, other nasties */ | 448 | /* unlink, shutdown, unplug, other nasties */ |
444 | if (urb->status != 0) { | 449 | if (urb->status != 0) { |
445 | err("kingsun_rcv_irq: urb asynchronously failed - %d", | 450 | dev_err(&kingsun->usbdev->dev, |
446 | urb->status); | 451 | "kingsun_rcv_irq: urb asynchronously failed - %d\n", |
452 | urb->status); | ||
447 | kingsun->receiving = 0; | 453 | kingsun->receiving = 0; |
448 | return; | 454 | return; |
449 | } | 455 | } |
@@ -536,7 +542,7 @@ static int ks959_net_open(struct net_device *netdev) | |||
536 | sprintf(hwname, "usb#%d", kingsun->usbdev->devnum); | 542 | sprintf(hwname, "usb#%d", kingsun->usbdev->devnum); |
537 | kingsun->irlap = irlap_open(netdev, &kingsun->qos, hwname); | 543 | kingsun->irlap = irlap_open(netdev, &kingsun->qos, hwname); |
538 | if (!kingsun->irlap) { | 544 | if (!kingsun->irlap) { |
539 | err("ks959-sir: irlap_open failed"); | 545 | dev_err(&kingsun->usbdev->dev, "irlap_open failed\n"); |
540 | goto free_mem; | 546 | goto free_mem; |
541 | } | 547 | } |
542 | 548 | ||
@@ -549,7 +555,8 @@ static int ks959_net_open(struct net_device *netdev) | |||
549 | kingsun->rx_urb->status = 0; | 555 | kingsun->rx_urb->status = 0; |
550 | err = usb_submit_urb(kingsun->rx_urb, GFP_KERNEL); | 556 | err = usb_submit_urb(kingsun->rx_urb, GFP_KERNEL); |
551 | if (err) { | 557 | if (err) { |
552 | err("ks959-sir: first urb-submit failed: %d", err); | 558 | dev_err(&kingsun->usbdev->dev, |
559 | "first urb-submit failed: %d\n", err); | ||
553 | goto close_irlap; | 560 | goto close_irlap; |
554 | } | 561 | } |
555 | 562 | ||