diff options
author | Bjorn Helgaas <bjorn.helgaas@hp.com> | 2006-08-15 03:05:38 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2006-09-22 17:54:45 -0400 |
commit | 9c3bd6833a4df1abd9ecd3b51492b8949bf9cd11 (patch) | |
tree | 6835d90852cd40289ad970b979b694ed55203e60 /drivers/net/irda/via-ircc.c | |
parent | 9a673e563e543a5c8a6f9824562e55e807b8a56c (diff) |
[IRDA]: Replace hard-coded dev_self[] array sizes with ARRAY_SIZE()
Several IR drivers used "for (i = 0; i < 4; i++)" to walk their
dev_self[] table. Better to use ARRAY_SIZE(). And fix ali-ircc so it
won't run off the end if we find too many adapters.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/irda/via-ircc.c')
-rw-r--r-- | drivers/net/irda/via-ircc.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/net/irda/via-ircc.c b/drivers/net/irda/via-ircc.c index 8bafb455c102..79b85f327500 100644 --- a/drivers/net/irda/via-ircc.c +++ b/drivers/net/irda/via-ircc.c | |||
@@ -279,7 +279,7 @@ static void via_ircc_clean(void) | |||
279 | 279 | ||
280 | IRDA_DEBUG(3, "%s()\n", __FUNCTION__); | 280 | IRDA_DEBUG(3, "%s()\n", __FUNCTION__); |
281 | 281 | ||
282 | for (i=0; i < 4; i++) { | 282 | for (i=0; i < ARRAY_SIZE(dev_self); i++) { |
283 | if (dev_self[i]) | 283 | if (dev_self[i]) |
284 | via_ircc_close(dev_self[i]); | 284 | via_ircc_close(dev_self[i]); |
285 | } | 285 | } |
@@ -327,6 +327,9 @@ static __devinit int via_ircc_open(int i, chipio_t * info, unsigned int id) | |||
327 | 327 | ||
328 | IRDA_DEBUG(3, "%s()\n", __FUNCTION__); | 328 | IRDA_DEBUG(3, "%s()\n", __FUNCTION__); |
329 | 329 | ||
330 | if (i >= ARRAY_SIZE(dev_self)) | ||
331 | return -ENOMEM; | ||
332 | |||
330 | /* Allocate new instance of the driver */ | 333 | /* Allocate new instance of the driver */ |
331 | dev = alloc_irdadev(sizeof(struct via_ircc_cb)); | 334 | dev = alloc_irdadev(sizeof(struct via_ircc_cb)); |
332 | if (dev == NULL) | 335 | if (dev == NULL) |