aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/irda/ma600-sir.c
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2014-11-11 17:44:57 -0500
committerDavid S. Miller <davem@davemloft.net>2014-11-12 13:56:41 -0500
commit955a9d202f470019f42979f0d1caec98843e39ce (patch)
treefff6124b339bc33e3b5c67668bfcc13098be865c /drivers/net/irda/ma600-sir.c
parent8d326d818a2a8fc80c7df85dd88cb214804d1499 (diff)
irda: Convert IRDA_DEBUG to pr_debug
Use the normal kernel debugging mechanism which also enables dynamic_debug at the same time. Other miscellanea: o Remove sysctl for irda_debug o Remove function tracing like uses (use ftrace instead) o Coalesce formats o Realign arguments o Remove unnecessary OOM messages Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/irda/ma600-sir.c')
-rw-r--r--drivers/net/irda/ma600-sir.c14
1 files changed, 3 insertions, 11 deletions
diff --git a/drivers/net/irda/ma600-sir.c b/drivers/net/irda/ma600-sir.c
index 944d044510e3..a764817b47f1 100644
--- a/drivers/net/irda/ma600-sir.c
+++ b/drivers/net/irda/ma600-sir.c
@@ -65,13 +65,11 @@ static struct dongle_driver ma600 = {
65 65
66static int __init ma600_sir_init(void) 66static int __init ma600_sir_init(void)
67{ 67{
68 IRDA_DEBUG(2, "%s()\n", __func__);
69 return irda_register_dongle(&ma600); 68 return irda_register_dongle(&ma600);
70} 69}
71 70
72static void __exit ma600_sir_cleanup(void) 71static void __exit ma600_sir_cleanup(void)
73{ 72{
74 IRDA_DEBUG(2, "%s()\n", __func__);
75 irda_unregister_dongle(&ma600); 73 irda_unregister_dongle(&ma600);
76} 74}
77 75
@@ -86,8 +84,6 @@ static int ma600_open(struct sir_dev *dev)
86{ 84{
87 struct qos_info *qos = &dev->qos; 85 struct qos_info *qos = &dev->qos;
88 86
89 IRDA_DEBUG(2, "%s()\n", __func__);
90
91 sirdev_set_dtr_rts(dev, TRUE, TRUE); 87 sirdev_set_dtr_rts(dev, TRUE, TRUE);
92 88
93 /* Explicitly set the speeds we can accept */ 89 /* Explicitly set the speeds we can accept */
@@ -104,8 +100,6 @@ static int ma600_open(struct sir_dev *dev)
104 100
105static int ma600_close(struct sir_dev *dev) 101static int ma600_close(struct sir_dev *dev)
106{ 102{
107 IRDA_DEBUG(2, "%s()\n", __func__);
108
109 /* Power off dongle */ 103 /* Power off dongle */
110 sirdev_set_dtr_rts(dev, FALSE, FALSE); 104 sirdev_set_dtr_rts(dev, FALSE, FALSE);
111 105
@@ -174,8 +168,8 @@ static int ma600_change_speed(struct sir_dev *dev, unsigned speed)
174{ 168{
175 u8 byte; 169 u8 byte;
176 170
177 IRDA_DEBUG(2, "%s(), speed=%d (was %d)\n", __func__, 171 pr_debug("%s(), speed=%d (was %d)\n", __func__,
178 speed, dev->speed); 172 speed, dev->speed);
179 173
180 /* dongle already reset, dongle and port at default speed (9600) */ 174 /* dongle already reset, dongle and port at default speed (9600) */
181 175
@@ -204,7 +198,7 @@ static int ma600_change_speed(struct sir_dev *dev, unsigned speed)
204 return -1; 198 return -1;
205 } 199 }
206 else 200 else
207 IRDA_DEBUG(2, "%s() control byte write read OK\n", __func__); 201 pr_debug("%s() control byte write read OK\n", __func__);
208#endif 202#endif
209 203
210 /* Set DTR, Set RTS */ 204 /* Set DTR, Set RTS */
@@ -236,8 +230,6 @@ static int ma600_change_speed(struct sir_dev *dev, unsigned speed)
236 230
237static int ma600_reset(struct sir_dev *dev) 231static int ma600_reset(struct sir_dev *dev)
238{ 232{
239 IRDA_DEBUG(2, "%s()\n", __func__);
240
241 /* Reset the dongle : set DTR low for 10 ms */ 233 /* Reset the dongle : set DTR low for 10 ms */
242 sirdev_set_dtr_rts(dev, FALSE, TRUE); 234 sirdev_set_dtr_rts(dev, FALSE, TRUE);
243 msleep(10); 235 msleep(10);