aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/igb
diff options
context:
space:
mode:
authorAlexander Duyck <alexander.h.duyck@intel.com>2009-02-06 18:22:52 -0500
committerDavid S. Miller <davem@davemloft.net>2009-02-07 05:43:16 -0500
commit265de4090853e56fb152e4cb0d21e4ec568d561a (patch)
treea5464529ec0b0fe697a01d022b672a30b4e62419 /drivers/net/igb
parent04fe63583d4648c0378a58afc0de89b640d822ef (diff)
igb: fix two minor items found during code review
This patch addresses two minor items I found while cleaning up the igb driver for our sourceforge version. The first clears the context index if we don't flag that we need it. The second item is that eims_other should be used instead of bit defines when setting all of the EICS bits prior to reset. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/igb')
-rw-r--r--drivers/net/igb/igb_main.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c
index 88f135f4b27f..67138400af8b 100644
--- a/drivers/net/igb/igb_main.c
+++ b/drivers/net/igb/igb_main.c
@@ -2771,6 +2771,8 @@ static inline bool igb_tx_csum_adv(struct igb_adapter *adapter,
2771 if (adapter->flags & IGB_FLAG_NEED_CTX_IDX) 2771 if (adapter->flags & IGB_FLAG_NEED_CTX_IDX)
2772 context_desc->mss_l4len_idx = 2772 context_desc->mss_l4len_idx =
2773 cpu_to_le32(tx_ring->queue_index << 4); 2773 cpu_to_le32(tx_ring->queue_index << 4);
2774 else
2775 context_desc->mss_l4len_idx = 0;
2774 2776
2775 buffer_info->time_stamp = jiffies; 2777 buffer_info->time_stamp = jiffies;
2776 buffer_info->next_to_watch = i; 2778 buffer_info->next_to_watch = i;
@@ -3040,8 +3042,8 @@ static void igb_tx_timeout(struct net_device *netdev)
3040 /* Do the reset outside of interrupt context */ 3042 /* Do the reset outside of interrupt context */
3041 adapter->tx_timeout_count++; 3043 adapter->tx_timeout_count++;
3042 schedule_work(&adapter->reset_task); 3044 schedule_work(&adapter->reset_task);
3043 wr32(E1000_EICS, adapter->eims_enable_mask & 3045 wr32(E1000_EICS,
3044 ~(E1000_EIMS_TCP_TIMER | E1000_EIMS_OTHER)); 3046 (adapter->eims_enable_mask & ~adapter->eims_other));
3045} 3047}
3046 3048
3047static void igb_reset_task(struct work_struct *work) 3049static void igb_reset_task(struct work_struct *work)