diff options
author | Jesse Brandeburg <jesse.brandeburg@intel.com> | 2009-04-21 14:42:05 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-04-22 03:47:54 -0400 |
commit | 4cb9be7ab47820a1fa747569f5f035a5f628c91b (patch) | |
tree | f272447c9bdc5b01578760f1c0f973a183f801b5 /drivers/net/igb/igb_main.c | |
parent | bf98a82633b97fb638fcee0fae3c0de54d1f7b05 (diff) |
e1000/e1000e/igb/ixgb: do not use netif_wake_queue un-necessarily
It was pointed out that the Intel wired ethernet drivers do not need to
wake the tx queue since netif_carrier_on/off will take care of the qdisc
management in order to guarantee the correct handling of the transmit
routine enable state.
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/igb/igb_main.c')
-rw-r--r-- | drivers/net/igb/igb_main.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c index ceaa58554679..183235d46aee 100644 --- a/drivers/net/igb/igb_main.c +++ b/drivers/net/igb/igb_main.c | |||
@@ -942,6 +942,8 @@ int igb_up(struct igb_adapter *adapter) | |||
942 | rd32(E1000_ICR); | 942 | rd32(E1000_ICR); |
943 | igb_irq_enable(adapter); | 943 | igb_irq_enable(adapter); |
944 | 944 | ||
945 | netif_tx_start_all_queues(adapter->netdev); | ||
946 | |||
945 | /* Fire a link change interrupt to start the watchdog. */ | 947 | /* Fire a link change interrupt to start the watchdog. */ |
946 | wr32(E1000_ICS, E1000_ICS_LSC); | 948 | wr32(E1000_ICS, E1000_ICS_LSC); |
947 | return 0; | 949 | return 0; |
@@ -2664,7 +2666,6 @@ static void igb_watchdog_task(struct work_struct *work) | |||
2664 | } | 2666 | } |
2665 | 2667 | ||
2666 | netif_carrier_on(netdev); | 2668 | netif_carrier_on(netdev); |
2667 | netif_tx_wake_all_queues(netdev); | ||
2668 | 2669 | ||
2669 | igb_ping_all_vfs(adapter); | 2670 | igb_ping_all_vfs(adapter); |
2670 | 2671 | ||
@@ -2681,7 +2682,6 @@ static void igb_watchdog_task(struct work_struct *work) | |||
2681 | printk(KERN_INFO "igb: %s NIC Link is Down\n", | 2682 | printk(KERN_INFO "igb: %s NIC Link is Down\n", |
2682 | netdev->name); | 2683 | netdev->name); |
2683 | netif_carrier_off(netdev); | 2684 | netif_carrier_off(netdev); |
2684 | netif_tx_stop_all_queues(netdev); | ||
2685 | 2685 | ||
2686 | igb_ping_all_vfs(adapter); | 2686 | igb_ping_all_vfs(adapter); |
2687 | 2687 | ||