diff options
author | David S. Miller <davem@davemloft.net> | 2008-07-17 03:34:19 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-07-17 22:21:00 -0400 |
commit | e8a0464cc950972824e2e128028ae3db666ec1ed (patch) | |
tree | 5022b95396c0f3b313531bc39b19543c03551b9a /drivers/net/ifb.c | |
parent | 070825b3840a743e21ebcc44f8279708a4fed977 (diff) |
netdev: Allocate multiple queues for TX.
alloc_netdev_mq() now allocates an array of netdev_queue
structures for TX, based upon the queue_count argument.
Furthermore, all accesses to the TX queues are now vectored
through the netdev_get_tx_queue() and netdev_for_each_tx_queue()
interfaces. This makes it easy to grep the tree for all
things that want to get to a TX queue of a net device.
Problem spots which are not really multiqueue aware yet, and
only work with one queue, can easily be spotted by grepping
for all netdev_get_tx_queue() calls that pass in a zero index.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ifb.c')
-rw-r--r-- | drivers/net/ifb.c | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/drivers/net/ifb.c b/drivers/net/ifb.c index ccbd6554f6eb..897b05e79ed0 100644 --- a/drivers/net/ifb.c +++ b/drivers/net/ifb.c | |||
@@ -229,14 +229,20 @@ module_param(numifbs, int, 0); | |||
229 | MODULE_PARM_DESC(numifbs, "Number of ifb devices"); | 229 | MODULE_PARM_DESC(numifbs, "Number of ifb devices"); |
230 | 230 | ||
231 | /* | 231 | /* |
232 | * dev_ifb->tx_queue.lock is usually taken after dev->rx_queue.lock, | 232 | * dev_ifb's TX queue lock is usually taken after dev->rx_queue.lock, |
233 | * reversely to e.g. qdisc_lock_tree(). It should be safe until | 233 | * reversely to e.g. qdisc_lock_tree(). It should be safe until |
234 | * ifb doesn't take dev->tx_queue.lock with dev_ifb->rx_queue.lock. | 234 | * ifb doesn't take dev's TX queue lock with dev_ifb->rx_queue.lock. |
235 | * But lockdep should know that ifb has different locks from dev. | 235 | * But lockdep should know that ifb has different locks from dev. |
236 | */ | 236 | */ |
237 | static struct lock_class_key ifb_tx_queue_lock_key; | 237 | static struct lock_class_key ifb_tx_queue_lock_key; |
238 | static struct lock_class_key ifb_rx_queue_lock_key; | 238 | static struct lock_class_key ifb_rx_queue_lock_key; |
239 | 239 | ||
240 | static void set_tx_lockdep_key(struct net_device *dev, | ||
241 | struct netdev_queue *txq, | ||
242 | void *_unused) | ||
243 | { | ||
244 | lockdep_set_class(&txq->lock, &ifb_tx_queue_lock_key); | ||
245 | } | ||
240 | 246 | ||
241 | static int __init ifb_init_one(int index) | 247 | static int __init ifb_init_one(int index) |
242 | { | 248 | { |
@@ -258,7 +264,7 @@ static int __init ifb_init_one(int index) | |||
258 | if (err < 0) | 264 | if (err < 0) |
259 | goto err; | 265 | goto err; |
260 | 266 | ||
261 | lockdep_set_class(&dev_ifb->tx_queue.lock, &ifb_tx_queue_lock_key); | 267 | netdev_for_each_tx_queue(dev_ifb, set_tx_lockdep_key, NULL); |
262 | lockdep_set_class(&dev_ifb->rx_queue.lock, &ifb_rx_queue_lock_key); | 268 | lockdep_set_class(&dev_ifb->rx_queue.lock, &ifb_rx_queue_lock_key); |
263 | 269 | ||
264 | return 0; | 270 | return 0; |