aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/hamradio/mkiss.c
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2008-12-16 18:43:29 -0500
committerDavid S. Miller <davem@davemloft.net>2008-12-16 18:43:29 -0500
commitf40e0638237a2d3e2ce8bedf3af4b3c02cf6fff7 (patch)
treec70b1a86681bd827fd0d7028cef391042f344e79 /drivers/net/hamradio/mkiss.c
parentf162e97d778ec29492be8eb9bbecb65be976b7c8 (diff)
drivers/net/hamradio: Move a dereference below a NULL test
In each case, if the NULL test is necessary, then the dereference should be moved below the NULL test. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ type T; expression E; identifier i,fld; statement S; @@ - T i = E->fld; + T i; ... when != E when != i if (E == NULL) S + i = E->fld; // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/hamradio/mkiss.c')
-rw-r--r--drivers/net/hamradio/mkiss.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c
index 7570c73f18c0..bbdb311b8420 100644
--- a/drivers/net/hamradio/mkiss.c
+++ b/drivers/net/hamradio/mkiss.c
@@ -846,12 +846,13 @@ static int mkiss_ioctl(struct tty_struct *tty, struct file *file,
846 unsigned int cmd, unsigned long arg) 846 unsigned int cmd, unsigned long arg)
847{ 847{
848 struct mkiss *ax = mkiss_get(tty); 848 struct mkiss *ax = mkiss_get(tty);
849 struct net_device *dev = ax->dev; 849 struct net_device *dev;
850 unsigned int tmp, err; 850 unsigned int tmp, err;
851 851
852 /* First make sure we're connected. */ 852 /* First make sure we're connected. */
853 if (ax == NULL) 853 if (ax == NULL)
854 return -ENXIO; 854 return -ENXIO;
855 dev = ax->dev;
855 856
856 switch (cmd) { 857 switch (cmd) {
857 case SIOCGIFNAME: 858 case SIOCGIFNAME: