aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/gianfar.c
diff options
context:
space:
mode:
authorJesse Gross <jesse@nicira.com>2010-10-20 09:56:03 -0400
committerDavid S. Miller <davem@davemloft.net>2010-10-21 04:26:52 -0400
commiteab6d18d20fc5b5ba04a7e7fcd6f357197870e51 (patch)
tree8a52538666747998dd16bc68a2102b05ebfe6873 /drivers/net/gianfar.c
parentb738127dfb469bb9f595cdace30e7f881e8146b2 (diff)
vlan: Don't check for vlan group before vlan_tx_tag_present.
Many (but not all) drivers check to see whether there is a vlan group configured before using a tag stored in the skb. There's not much point in this check since it just throws away data that should only be present in the expected circumstances. However, it will soon be legal and expected to get a vlan tag when no vlan group is configured, so remove this check from all drivers to avoid dropping the tags. Signed-off-by: Jesse Gross <jesse@nicira.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/gianfar.c')
-rw-r--r--drivers/net/gianfar.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c
index 6180089bf67a..4c4cc80ec0a1 100644
--- a/drivers/net/gianfar.c
+++ b/drivers/net/gianfar.c
@@ -2075,7 +2075,7 @@ static int gfar_start_xmit(struct sk_buff *skb, struct net_device *dev)
2075 2075
2076 /* make space for additional header when fcb is needed */ 2076 /* make space for additional header when fcb is needed */
2077 if (((skb->ip_summed == CHECKSUM_PARTIAL) || 2077 if (((skb->ip_summed == CHECKSUM_PARTIAL) ||
2078 (priv->vlgrp && vlan_tx_tag_present(skb)) || 2078 vlan_tx_tag_present(skb) ||
2079 unlikely(do_tstamp)) && 2079 unlikely(do_tstamp)) &&
2080 (skb_headroom(skb) < GMAC_FCB_LEN)) { 2080 (skb_headroom(skb) < GMAC_FCB_LEN)) {
2081 struct sk_buff *skb_new; 2081 struct sk_buff *skb_new;
@@ -2161,7 +2161,7 @@ static int gfar_start_xmit(struct sk_buff *skb, struct net_device *dev)
2161 gfar_tx_checksum(skb, fcb); 2161 gfar_tx_checksum(skb, fcb);
2162 } 2162 }
2163 2163
2164 if (priv->vlgrp && vlan_tx_tag_present(skb)) { 2164 if (vlan_tx_tag_present(skb)) {
2165 if (unlikely(NULL == fcb)) { 2165 if (unlikely(NULL == fcb)) {
2166 fcb = gfar_add_fcb(skb); 2166 fcb = gfar_add_fcb(skb);
2167 lstatus |= BD_LFLAG(TXBD_TOE); 2167 lstatus |= BD_LFLAG(TXBD_TOE);