phylib: move to dynamic allocation of struct mii_bus

This patch introduces mdiobus_alloc() and mdiobus_free(), and
makes all mdio bus drivers use these functions to allocate their
struct mii_bus'es dynamically.

Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Acked-by: Andy Fleming <afleming@freescale.com>

2 files changed, 6 insertions, 7 deletions

diff --git a/drivers/net/fs_enet/mii-bitbang.c b/drivers/net/fs_enet/mii-bitbang.c
index 2774252c2352..49b6645d7e0c 100644
--- a/drivers/net/fs_enet/mii-bitbang.c
+++ b/drivers/net/fs_enet/mii-bitbang.c
@@ -218,9 +218,9 @@ out_free_irqs:
 out_unmap_regs:
         iounmap(bitbang->dir);
 out_free_bus:
-        kfree(new_bus);
-out_free_priv:
         free_mdio_bitbang(new_bus);
+out_free_priv:
+        kfree(bitbang);
 out:
         return ret;
 }
@@ -231,12 +231,11 @@ static int fs_enet_mdio_remove(struct of_device *ofdev)
         struct bb_info *bitbang = bus->priv;
 
         mdiobus_unregister(bus);
-        free_mdio_bitbang(bus);
         dev_set_drvdata(&ofdev->dev, NULL);
         kfree(bus->irq);
+        free_mdio_bitbang(bus);
         iounmap(bitbang->dir);
         kfree(bitbang);
-        kfree(bus);
 
         return 0;
 }
diff --git a/drivers/net/fs_enet/mii-fec.c b/drivers/net/fs_enet/mii-fec.c
index 4d89a22317ac..28077cc1b949 100644
--- a/drivers/net/fs_enet/mii-fec.c
+++ b/drivers/net/fs_enet/mii-fec.c
@@ -128,7 +128,7 @@ static int __devinit fs_enet_mdio_probe(struct of_device *ofdev,
         struct fec_info *fec;
         int ret = -ENOMEM, i;
 
-        new_bus = kzalloc(sizeof(struct mii_bus), GFP_KERNEL);
+        new_bus = mdiobus_alloc();
         if (!new_bus)
                 goto out;
 
@@ -190,7 +190,7 @@ out_res:
 out_fec:
         kfree(fec);
 out_mii:
-        kfree(new_bus);
+        mdiobus_free(new_bus);
 out:
         return ret;
 }
@@ -205,7 +205,7 @@ static int fs_enet_mdio_remove(struct of_device *ofdev)
         kfree(bus->irq);
         iounmap(fec->fecp);
         kfree(fec);
-        kfree(bus);
+        mdiobus_free(bus);
 
         return 0;
 }