aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/fec_8xx
diff options
context:
space:
mode:
authorJeff Garzik <jeff@garzik.org>2007-09-15 17:41:06 -0400
committerDavid S. Miller <davem@sunset.davemloft.net>2007-10-10 19:51:17 -0400
commit88d3aafdae5c5e1d2dd9489a5c8a24e29d335f2e (patch)
tree272ce75c30a170420ac8bbfd679c3faed9f9d20a /drivers/net/fec_8xx
parent09f75cd7bf13720738e6a196cc0107ce9a5bd5a0 (diff)
[ETHTOOL] Provide default behaviors for a few ethtool sub-ioctls
For the operations get-tx-csum get-sg get-tso get-ufo the default ethtool_op_xxx behavior is fine for all drivers, so we permit op==NULL to imply the default behavior. This provides a more uniform behavior across all drivers, eliminating ethtool(8) "ioctl not supported" errors on older drivers that had not been updated for the latest sub-ioctls. The ethtool_op_xxx() functions are left exported, in case anyone wishes to call them directly from a driver-private implementation -- a not-uncommon case. Should an ethtool_op_xxx() helper remain unused for a while, except by net/core/ethtool.c, we can un-export it at a later date. [ Resolved conflicts with set/get value ethtool patch... -DaveM ] Signed-off-by: Jeff Garzik <jeff@garzik.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/fec_8xx')
-rw-r--r--drivers/net/fec_8xx/fec_main.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/fec_8xx/fec_main.c b/drivers/net/fec_8xx/fec_main.c
index 6f214ab12fff..8d2904fa5789 100644
--- a/drivers/net/fec_8xx/fec_main.c
+++ b/drivers/net/fec_8xx/fec_main.c
@@ -1041,9 +1041,7 @@ static const struct ethtool_ops fec_ethtool_ops = {
1041 .get_link = ethtool_op_get_link, 1041 .get_link = ethtool_op_get_link,
1042 .get_msglevel = fec_get_msglevel, 1042 .get_msglevel = fec_get_msglevel,
1043 .set_msglevel = fec_set_msglevel, 1043 .set_msglevel = fec_set_msglevel,
1044 .get_tx_csum = ethtool_op_get_tx_csum,
1045 .set_tx_csum = ethtool_op_set_tx_csum, /* local! */ 1044 .set_tx_csum = ethtool_op_set_tx_csum, /* local! */
1046 .get_sg = ethtool_op_get_sg,
1047 .set_sg = ethtool_op_set_sg, 1045 .set_sg = ethtool_op_set_sg,
1048 .get_regs = fec_get_regs, 1046 .get_regs = fec_get_regs,
1049}; 1047};