Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

Pull networking fixes from David Miller:

 1) Really fix tuntap SKB use after free bug, from Eric Dumazet.

 2) Adjust SKB data pointer to point past the transport header before
    calling icmpv6_notify() so that the headers are in the state which
    that function expects.  From Duan Jiong.

 3) Fix ambiguities in the new tuntap multi-queue APIs.  From Jason
    Wang.

 4) mISDN needs to use del_timer_sync(), from Konstantin Khlebnikov.

 5) Don't destroy mutex after freeing up device private in mac802154,
    fix also from Konstantin Khlebnikov.

 6) Fix INET request socket leak in TCP and DCCP, from Christoph Paasch.

 7) SCTP HMAC kconfig rework, from Neil Horman.

 8) Fix SCTP jprobes function signature, otherwise things explode, from
    Daniel Borkmann.

 9) Fix typo in ipv6-offload Makefile variable reference, from Simon
    Arlott.

10) Don't fail USBNET open just because remote wakeup isn't supported,
    from Oliver Neukum.

11) be2net driver bug fixes from Sathya Perla.

12) SOLOS PCI ATM driver bug fixes from Nathan Williams and David
    Woodhouse.

13) Fix MTU changing regression in 8139cp driver, from John Greene.

* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net: (45 commits)
  solos-pci: ensure all TX packets are aligned to 4 bytes
  solos-pci: add firmware upgrade support for new models
  solos-pci: remove superfluous debug output
  solos-pci: add GPIO support for newer versions on Geos board
  8139cp: Prevent dev_close/cp_interrupt race on MTU change
  net: qmi_wwan: add ZTE MF880
  drivers/net: Use of_match_ptr() macro in smsc911x.c
  drivers/net: Use of_match_ptr() macro in smc91x.c
  ipv6: addrconf.c: remove unnecessary "if"
  bridge: Correctly encode addresses when dumping mdb entries
  bridge: Do not unregister all PF_BRIDGE rtnl operations
  use generic usbnet_manage_power()
  usbnet: generic manage_power()
  usbnet: handle PM failure gracefully
  ksz884x: fix receive polling race condition
  qlcnic: update driver version
  qlcnic: fix unused variable warnings
  net: fec: forbid FEC_PTP on SoCs that do not support
  be2net: fix wrong frag_idx reported by RX CQ
  be2net: fix be_close() to ensure all events are ack'ed
  ...

16 files changed, 98 insertions, 61 deletions

diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h
index abf26c7c1d19..3bc1912afba9 100644
--- a/drivers/net/ethernet/emulex/benet/be.h
+++ b/drivers/net/ethernet/emulex/benet/be.h
@@ -616,7 +616,7 @@ static inline bool be_error(struct be_adapter *adapter)
         return adapter->eeh_error || adapter->hw_error || adapter->fw_timeout;
 }
 
-static inline bool be_crit_error(struct be_adapter *adapter)
+static inline bool be_hw_error(struct be_adapter *adapter)
 {
         return adapter->eeh_error || adapter->hw_error;
 }
diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c b/drivers/net/ethernet/emulex/benet/be_cmds.c
index f2875aa47661..8a250c38fb82 100644
--- a/drivers/net/ethernet/emulex/benet/be_cmds.c
+++ b/drivers/net/ethernet/emulex/benet/be_cmds.c
@@ -298,7 +298,12 @@ void be_async_mcc_enable(struct be_adapter *adapter)
 
 void be_async_mcc_disable(struct be_adapter *adapter)
 {
+        spin_lock_bh(&adapter->mcc_cq_lock);
+
         adapter->mcc_obj.rearm_cq = false;
+        be_cq_notify(adapter, adapter->mcc_obj.cq.id, false, 0);
+
+        spin_unlock_bh(&adapter->mcc_cq_lock);
 }
 
 int be_process_mcc(struct be_adapter *adapter)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index f95612b907ae..9dca22be8125 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -1689,15 +1689,41 @@ static void be_rx_cq_clean(struct be_rx_obj *rxo)
         struct be_queue_info *rxq = &rxo->q;
         struct be_queue_info *rx_cq = &rxo->cq;
         struct be_rx_compl_info *rxcp;
+        struct be_adapter *adapter = rxo->adapter;
+        int flush_wait = 0;
         u16 tail;
 
-        /* First cleanup pending rx completions */
-        while ((rxcp = be_rx_compl_get(rxo)) != NULL) {
-                be_rx_compl_discard(rxo, rxcp);
-                be_cq_notify(rxo->adapter, rx_cq->id, false, 1);
+        /* Consume pending rx completions.
+         * Wait for the flush completion (identified by zero num_rcvd)
+         * to arrive. Notify CQ even when there are no more CQ entries
+         * for HW to flush partially coalesced CQ entries.
+         * In Lancer, there is no need to wait for flush compl.
+         */
+        for (;;) {
+                rxcp = be_rx_compl_get(rxo);
+                if (rxcp == NULL) {
+                        if (lancer_chip(adapter))
+                                break;
+
+                        if (flush_wait++ > 10 || be_hw_error(adapter)) {
+                                dev_warn(&adapter->pdev->dev,
+                                         "did not receive flush compl\n");
+                                break;
+                        }
+                        be_cq_notify(adapter, rx_cq->id, true, 0);
+                        mdelay(1);
+                } else {
+                        be_rx_compl_discard(rxo, rxcp);
+                        be_cq_notify(adapter, rx_cq->id, true, 1);
+                        if (rxcp->num_rcvd == 0)
+                                break;
+                }
         }
 
-        /* Then free posted rx buffer that were not used */
+        /* After cleanup, leave the CQ in unarmed state */
+        be_cq_notify(adapter, rx_cq->id, false, 0);
+
+        /* Then free posted rx buffers that were not used */
         tail = (rxq->head + rxq->len - atomic_read(&rxq->used)) % rxq->len;
         for (; atomic_read(&rxq->used) > 0; index_inc(&tail, rxq->len)) {
                 page_info = get_rx_page_info(rxo, tail);
@@ -2157,7 +2183,7 @@ void be_detect_error(struct be_adapter *adapter)
         u32 sliport_status = 0, sliport_err1 = 0, sliport_err2 = 0;
         u32 i;
 
-        if (be_crit_error(adapter))
+        if (be_hw_error(adapter))
                 return;
 
         if (lancer_chip(adapter)) {
@@ -2398,13 +2424,22 @@ static int be_close(struct net_device *netdev)
 
         be_roce_dev_close(adapter);
 
-        be_async_mcc_disable(adapter);
-
         if (!lancer_chip(adapter))
                 be_intr_set(adapter, false);
 
-        for_all_evt_queues(adapter, eqo, i) {
+        for_all_evt_queues(adapter, eqo, i)
                 napi_disable(&eqo->napi);
+
+        be_async_mcc_disable(adapter);
+
+        /* Wait for all pending tx completions to arrive so that
+         * all tx skbs are freed.
+         */
+        be_tx_compl_clean(adapter);
+
+        be_rx_qs_destroy(adapter);
+
+        for_all_evt_queues(adapter, eqo, i) {
                 if (msix_enabled(adapter))
                         synchronize_irq(be_msix_vec_get(adapter, eqo));
                 else
@@ -2414,12 +2449,6 @@ static int be_close(struct net_device *netdev)
 
         be_irq_unregister(adapter);
 
-        /* Wait for all pending tx completions to arrive so that
-         * all tx skbs are freed.
-         */
-        be_tx_compl_clean(adapter);
-
-        be_rx_qs_destroy(adapter);
         return 0;
 }
 
diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
index 5ba6e1cbd346..ec490d741fc0 100644
--- a/drivers/net/ethernet/freescale/Kconfig
+++ b/drivers/net/ethernet/freescale/Kconfig
@@ -94,9 +94,8 @@ config GIANFAR
 
 config FEC_PTP
         bool "PTP Hardware Clock (PHC)"
-        depends on FEC && ARCH_MXC
+        depends on FEC && ARCH_MXC && !SOC_IMX25 && !SOC_IMX27 && !SOC_IMX35 && !SOC_IMX5
         select PTP_1588_CLOCK
-        default y if SOC_IMX6Q
         --help---
           Say Y here if you want to use PTP Hardware Clock (PHC) in the
           driver.  Only the basic clock operations have been implemented.
diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c
index 83f0ea929d3d..8ebc352bcbe6 100644
--- a/drivers/net/ethernet/micrel/ksz884x.c
+++ b/drivers/net/ethernet/micrel/ksz884x.c
@@ -4761,7 +4761,7 @@ static void transmit_cleanup(struct dev_info *hw_priv, int normal)
         struct ksz_dma_buf *dma_buf;
         struct net_device *dev = NULL;
 
-        spin_lock(&hw_priv->hwlock);
+        spin_lock_irq(&hw_priv->hwlock);
         last = info->last;
 
         while (info->avail < info->alloc) {
@@ -4795,7 +4795,7 @@ static void transmit_cleanup(struct dev_info *hw_priv, int normal)
                 info->avail++;
         }
         info->last = last;
-        spin_unlock(&hw_priv->hwlock);
+        spin_unlock_irq(&hw_priv->hwlock);
 
         /* Notify the network subsystem that the packet has been sent. */
         if (dev)
@@ -5259,11 +5259,15 @@ static irqreturn_t netdev_intr(int irq, void *dev_id)
         struct dev_info *hw_priv = priv->adapter;
         struct ksz_hw *hw = &hw_priv->hw;
 
+        spin_lock(&hw_priv->hwlock);
+
         hw_read_intr(hw, &int_enable);
 
         /* Not our interrupt! */
-        if (!int_enable)
+        if (!int_enable) {
+                spin_unlock(&hw_priv->hwlock);
                 return IRQ_NONE;
+        }
 
         do {
                 hw_ack_intr(hw, int_enable);
@@ -5310,6 +5314,8 @@ static irqreturn_t netdev_intr(int irq, void *dev_id)
 
         hw_ena_intr(hw);
 
+        spin_unlock(&hw_priv->hwlock);
+
         return IRQ_HANDLED;
 }
 
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
index 537902479689..bc7ec64e9c7a 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
@@ -36,8 +36,8 @@
 
 #define _QLCNIC_LINUX_MAJOR 5
 #define _QLCNIC_LINUX_MINOR 0
-#define _QLCNIC_LINUX_SUBVERSION 29
-#define QLCNIC_LINUX_VERSIONID  "5.0.29"
+#define _QLCNIC_LINUX_SUBVERSION 30
+#define QLCNIC_LINUX_VERSIONID  "5.0.30"
 #define QLCNIC_DRV_IDC_VER  0x01
 #define QLCNIC_DRIVER_VERSION  ((_QLCNIC_LINUX_MAJOR << 16) |\
                  (_QLCNIC_LINUX_MINOR << 8) | (_QLCNIC_LINUX_SUBVERSION))
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
index 58f094ca052e..b14b8f0787ea 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
@@ -134,7 +134,7 @@ int qlcnic_fw_cmd_get_minidump_temp(struct qlcnic_adapter *adapter)
         __le32 *tmp_buf;
         struct qlcnic_cmd_args cmd;
         struct qlcnic_hardware_context *ahw;
-        struct qlcnic_dump_template_hdr *tmpl_hdr, *tmp_tmpl;
+        struct qlcnic_dump_template_hdr *tmpl_hdr;
         dma_addr_t tmp_addr_t = 0;
 
         ahw = adapter->ahw;
@@ -150,6 +150,8 @@ int qlcnic_fw_cmd_get_minidump_temp(struct qlcnic_adapter *adapter)
         }
         temp_size = cmd.rsp.arg2;
         version = cmd.rsp.arg3;
+        dev_info(&adapter->pdev->dev,
+                 "minidump template version = 0x%x", version);
         if (!temp_size)
                 return -EIO;
 
@@ -174,7 +176,6 @@ int qlcnic_fw_cmd_get_minidump_temp(struct qlcnic_adapter *adapter)
                 err = -EIO;
                 goto error;
         }
-        tmp_tmpl = tmp_addr;
         ahw->fw_dump.tmpl_hdr = vzalloc(temp_size);
         if (!ahw->fw_dump.tmpl_hdr) {
                 err = -EIO;
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c
index fc48e000f35f..7a6d5ebe4e0f 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c
@@ -365,7 +365,7 @@ static int
 qlcnic_send_cmd_descs(struct qlcnic_adapter *adapter,
                 struct cmd_desc_type0 *cmd_desc_arr, int nr_desc)
 {
-        u32 i, producer, consumer;
+        u32 i, producer;
         struct qlcnic_cmd_buffer *pbuf;
         struct cmd_desc_type0 *cmd_desc;
         struct qlcnic_host_tx_ring *tx_ring;
@@ -379,7 +379,6 @@ qlcnic_send_cmd_descs(struct qlcnic_adapter *adapter,
         __netif_tx_lock_bh(tx_ring->txq);
 
         producer = tx_ring->producer;
-        consumer = tx_ring->sw_consumer;
 
         if (nr_desc >= qlcnic_tx_avail(tx_ring)) {
                 netif_tx_stop_queue(tx_ring->txq);
@@ -402,7 +401,7 @@ qlcnic_send_cmd_descs(struct qlcnic_adapter *adapter,
                 pbuf->frag_count = 0;
 
                 memcpy(&tx_ring->desc_head[producer],
-                        &cmd_desc_arr[i], sizeof(struct cmd_desc_type0));
+                       cmd_desc, sizeof(struct cmd_desc_type0));
 
                 producer = get_next_index(producer, tx_ring->num_desc);
                 i++;
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index a7554d9aab0c..d833f5927891 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -445,13 +445,10 @@ static int
 qlcnic_set_function_modes(struct qlcnic_adapter *adapter)
 {
         u8 id;
-        u32 ref_count;
         int i, ret = 1;
         u32 data = QLCNIC_MGMT_FUNC;
         struct qlcnic_hardware_context *ahw = adapter->ahw;
 
-        /* If other drivers are not in use set their privilege level */
-        ref_count = QLCRD32(adapter, QLCNIC_CRB_DRV_ACTIVE);
         ret = qlcnic_api_lock(adapter);
         if (ret)
                 goto err_lock;
@@ -531,11 +528,9 @@ static int qlcnic_setup_pci_map(struct pci_dev *pdev,
 {
         u32 offset;
         void __iomem *mem_ptr0 = NULL;
-        resource_size_t mem_base;
         unsigned long mem_len, pci_len0 = 0, bar0_len;
 
         /* remap phys address */
-        mem_base = pci_resource_start(pdev, 0); /* 0 is for BAR 0 */
         mem_len = pci_resource_len(pdev, 0);
 
         qlcnic_get_bar_length(pdev->device, &bar0_len);
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_minidump.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_minidump.c
index 12ff29270745..0b8d8625834c 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_minidump.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_minidump.c
@@ -197,7 +197,7 @@ static u32 qlcnic_dump_ctrl(struct qlcnic_adapter *adapter,
         int i, k, timeout = 0;
         void __iomem *base = adapter->ahw->pci_base0;
         u32 addr, data;
-        u8 opcode, no_ops;
+        u8 no_ops;
         struct __ctrl *ctr = &entry->region.ctrl;
         struct qlcnic_dump_template_hdr *t_hdr = adapter->ahw->fw_dump.tmpl_hdr;
 
@@ -206,7 +206,6 @@ static u32 qlcnic_dump_ctrl(struct qlcnic_adapter *adapter,
 
         for (i = 0; i < no_ops; i++) {
                 k = 0;
-                opcode = 0;
                 for (k = 0; k < 8; k++) {
                         if (!(ctr->opcode & (1 << k)))
                                 continue;
diff --git a/drivers/net/ethernet/realtek/8139cp.c b/drivers/net/ethernet/realtek/8139cp.c
index cb6fc5a743ca..5ac93323a40c 100644
--- a/drivers/net/ethernet/realtek/8139cp.c
+++ b/drivers/net/ethernet/realtek/8139cp.c
@@ -577,28 +577,30 @@ static irqreturn_t cp_interrupt (int irq, void *dev_instance)
 {
         struct net_device *dev = dev_instance;
         struct cp_private *cp;
+        int handled = 0;
         u16 status;
 
         if (unlikely(dev == NULL))
                 return IRQ_NONE;
         cp = netdev_priv(dev);
 
+        spin_lock(&cp->lock);
+
         status = cpr16(IntrStatus);
         if (!status || (status == 0xFFFF))
-                return IRQ_NONE;
+                goto out_unlock;
+
+        handled = 1;
 
         netif_dbg(cp, intr, dev, "intr, status %04x cmd %02x cpcmd %04x\n",
                   status, cpr8(Cmd), cpr16(CpCmd));
 
         cpw16(IntrStatus, status & ~cp_rx_intr_mask);
 
-        spin_lock(&cp->lock);
-
         /* close possible race's with dev_close */
         if (unlikely(!netif_running(dev))) {
                 cpw16(IntrMask, 0);
-                spin_unlock(&cp->lock);
-                return IRQ_HANDLED;
+                goto out_unlock;
         }
 
         if (status & (RxOK | RxErr | RxEmpty | RxFIFOOvr))
@@ -612,7 +614,6 @@ static irqreturn_t cp_interrupt (int irq, void *dev_instance)
         if (status & LinkChg)
                 mii_check_media(&cp->mii_if, netif_msg_link(cp), false);
 
-        spin_unlock(&cp->lock);
 
         if (status & PciErr) {
                 u16 pci_status;
@@ -625,7 +626,10 @@ static irqreturn_t cp_interrupt (int irq, void *dev_instance)
                 /* TODO: reset hardware */
         }
 
-        return IRQ_HANDLED;
+out_unlock:
+        spin_unlock(&cp->lock);
+
+        return IRQ_RETVAL(handled);
 }
 
 #ifdef CONFIG_NET_POLL_CONTROLLER
diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
index 022b45bc14ff..a670d23d9340 100644
--- a/drivers/net/ethernet/smsc/smc91x.c
+++ b/drivers/net/ethernet/smsc/smc91x.c
@@ -2386,8 +2386,6 @@ static const struct of_device_id smc91x_match[] = {
         {},
 };
 MODULE_DEVICE_TABLE(of, smc91x_match);
-#else
-#define smc91x_match NULL
 #endif
 
 static struct dev_pm_ops smc_drv_pm_ops = {
@@ -2402,7 +2400,7 @@ static struct platform_driver smc_driver = {
                 .name   = CARDNAME,
                 .owner  = THIS_MODULE,
                 .pm     = &smc_drv_pm_ops,
-                .of_match_table = smc91x_match,
+                .of_match_table = of_match_ptr(smc91x_match),
         },
 };
 
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index 4616bf27d515..e112877d15d3 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -2575,11 +2575,13 @@ static const struct dev_pm_ops smsc911x_pm_ops = {
 #define SMSC911X_PM_OPS NULL
 #endif
 
+#ifdef CONFIG_OF
 static const struct of_device_id smsc911x_dt_ids[] = {
         { .compatible = "smsc,lan9115", },
         { /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, smsc911x_dt_ids);
+#endif
 
 static struct platform_driver smsc911x_driver = {
         .probe = smsc911x_drv_probe,
@@ -2588,7 +2590,7 @@ static struct platform_driver smsc911x_driver = {
                 .name   = SMSC_CHIPNAME,
                 .owner  = THIS_MODULE,
                 .pm     = SMSC911X_PM_OPS,
-                .of_match_table = smsc911x_dt_ids,
+                .of_match_table = of_match_ptr(smsc911x_dt_ids),
         },
 };
 
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
index 023a4fb4efa5..b05df8983be5 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
@@ -127,14 +127,14 @@ static inline int stmmac_register_platform(void)
 }
 static inline void stmmac_unregister_platform(void)
 {
-        platform_driver_register(&stmmac_pltfr_driver);
+        platform_driver_unregister(&stmmac_pltfr_driver);
 }
 #else
 static inline int stmmac_register_platform(void)
 {
         pr_debug("stmmac: do not register the platf driver\n");
 
-        return -EINVAL;
+        return 0;
 }
 static inline void stmmac_unregister_platform(void)
 {
@@ -162,7 +162,7 @@ static inline int stmmac_register_pci(void)
 {
         pr_debug("stmmac: do not register the PCI driver\n");
 
-        return -EINVAL;
+        return 0;
 }
 static inline void stmmac_unregister_pci(void)
 {
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 542edbcd92c7..f07c0612abf6 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -2194,18 +2194,20 @@ int stmmac_restore(struct net_device *ndev)
  */
 static int __init stmmac_init(void)
 {
-        int err_plt = 0;
-        int err_pci = 0;
-
-        err_plt = stmmac_register_platform();
-        err_pci = stmmac_register_pci();
-
-        if ((err_pci) && (err_plt)) {
-                pr_err("stmmac: driver registration failed\n");
-                return -EINVAL;
-        }
+        int ret;
 
+        ret = stmmac_register_platform();
+        if (ret)
+                goto err;
+        ret = stmmac_register_pci();
+        if (ret)
+                goto err_pci;
         return 0;
+err_pci:
+        stmmac_unregister_platform();
+err:
+        pr_err("stmmac: driver registration failed\n");
+        return ret;
 }
 
 static void __exit stmmac_exit(void)
diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
index 337766738eca..5e62c1aeeffb 100644
--- a/drivers/net/ethernet/ti/cpts.c
+++ b/drivers/net/ethernet/ti/cpts.c
@@ -27,8 +27,6 @@
 #include <linux/uaccess.h>
 #include <linux/workqueue.h>
 
-#include <plat/clock.h>
-
 #include "cpts.h"
 
 #ifdef CONFIG_TI_CPTS