diff options
author | Joe Perches <joe@perches.com> | 2013-03-08 10:03:25 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-03-09 16:09:19 -0500 |
commit | 720a43efd30f04a0a492c85fb997361c44fbae05 (patch) | |
tree | 430e9488e00413655b7947f67e82c4fd2c07e951 /drivers/net/ethernet/xircom | |
parent | e8f83e5ec7450b85b101a774e165e70a18e9c3ab (diff) |
drivers:net: Remove unnecessary OOM messages after netdev_alloc_skb
Emitting netdev_alloc_skb and netdev_alloc_skb_ip_align OOM
messages is unnecessary as there is already a dump_stack
after allocation failures.
Other trivial changes around these removals:
Convert a few comparisons of pointer to 0 to !pointer.
Change flow to remove unnecessary label.
Remove now unused variable.
Hoist assignment from if.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/xircom')
-rw-r--r-- | drivers/net/ethernet/xircom/xirc2ps_cs.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ethernet/xircom/xirc2ps_cs.c b/drivers/net/ethernet/xircom/xirc2ps_cs.c index 98e09d0d3ce2..76210abf2e9b 100644 --- a/drivers/net/ethernet/xircom/xirc2ps_cs.c +++ b/drivers/net/ethernet/xircom/xirc2ps_cs.c | |||
@@ -1041,7 +1041,6 @@ xirc2ps_interrupt(int irq, void *dev_id) | |||
1041 | /* 1 extra so we can use insw */ | 1041 | /* 1 extra so we can use insw */ |
1042 | skb = netdev_alloc_skb(dev, pktlen + 3); | 1042 | skb = netdev_alloc_skb(dev, pktlen + 3); |
1043 | if (!skb) { | 1043 | if (!skb) { |
1044 | pr_notice("low memory, packet dropped (size=%u)\n", pktlen); | ||
1045 | dev->stats.rx_dropped++; | 1044 | dev->stats.rx_dropped++; |
1046 | } else { /* okay get the packet */ | 1045 | } else { /* okay get the packet */ |
1047 | skb_reserve(skb, 2); | 1046 | skb_reserve(skb, 2); |