aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/sun
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2014-08-28 01:59:26 -0400
committerDavid S. Miller <davem@davemloft.net>2014-08-28 02:07:12 -0400
commitabc4da4503bf6cb1864454b464c52959241239bd (patch)
tree144555c483489084eea908606c4ce79742380968 /drivers/net/ethernet/sun
parent73852b2bfb743298dff9e731615ee0162b33630c (diff)
sungem: Fix global namespace pollution of phy accessors.
The sungem driver has "phy_read()" and "phy_write()" functions, which we need to rename because the generic phy layer is about to export generic interfaces with the same name. Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/sun')
-rw-r--r--drivers/net/ethernet/sun/sungem.c34
1 files changed, 17 insertions, 17 deletions
diff --git a/drivers/net/ethernet/sun/sungem.c b/drivers/net/ethernet/sun/sungem.c
index f7415b6bf141..fef5dec2cffe 100644
--- a/drivers/net/ethernet/sun/sungem.c
+++ b/drivers/net/ethernet/sun/sungem.c
@@ -115,7 +115,7 @@ static const struct pci_device_id gem_pci_tbl[] = {
115 115
116MODULE_DEVICE_TABLE(pci, gem_pci_tbl); 116MODULE_DEVICE_TABLE(pci, gem_pci_tbl);
117 117
118static u16 __phy_read(struct gem *gp, int phy_addr, int reg) 118static u16 __sungem_phy_read(struct gem *gp, int phy_addr, int reg)
119{ 119{
120 u32 cmd; 120 u32 cmd;
121 int limit = 10000; 121 int limit = 10000;
@@ -141,18 +141,18 @@ static u16 __phy_read(struct gem *gp, int phy_addr, int reg)
141 return cmd & MIF_FRAME_DATA; 141 return cmd & MIF_FRAME_DATA;
142} 142}
143 143
144static inline int _phy_read(struct net_device *dev, int mii_id, int reg) 144static inline int _sungem_phy_read(struct net_device *dev, int mii_id, int reg)
145{ 145{
146 struct gem *gp = netdev_priv(dev); 146 struct gem *gp = netdev_priv(dev);
147 return __phy_read(gp, mii_id, reg); 147 return __sungem_phy_read(gp, mii_id, reg);
148} 148}
149 149
150static inline u16 phy_read(struct gem *gp, int reg) 150static inline u16 sungem_phy_read(struct gem *gp, int reg)
151{ 151{
152 return __phy_read(gp, gp->mii_phy_addr, reg); 152 return __sungem_phy_read(gp, gp->mii_phy_addr, reg);
153} 153}
154 154
155static void __phy_write(struct gem *gp, int phy_addr, int reg, u16 val) 155static void __sungem_phy_write(struct gem *gp, int phy_addr, int reg, u16 val)
156{ 156{
157 u32 cmd; 157 u32 cmd;
158 int limit = 10000; 158 int limit = 10000;
@@ -174,15 +174,15 @@ static void __phy_write(struct gem *gp, int phy_addr, int reg, u16 val)
174 } 174 }
175} 175}
176 176
177static inline void _phy_write(struct net_device *dev, int mii_id, int reg, int val) 177static inline void _sungem_phy_write(struct net_device *dev, int mii_id, int reg, int val)
178{ 178{
179 struct gem *gp = netdev_priv(dev); 179 struct gem *gp = netdev_priv(dev);
180 __phy_write(gp, mii_id, reg, val & 0xffff); 180 __sungem_phy_write(gp, mii_id, reg, val & 0xffff);
181} 181}
182 182
183static inline void phy_write(struct gem *gp, int reg, u16 val) 183static inline void sungem_phy_write(struct gem *gp, int reg, u16 val)
184{ 184{
185 __phy_write(gp, gp->mii_phy_addr, reg, val); 185 __sungem_phy_write(gp, gp->mii_phy_addr, reg, val);
186} 186}
187 187
188static inline void gem_enable_ints(struct gem *gp) 188static inline void gem_enable_ints(struct gem *gp)
@@ -1687,9 +1687,9 @@ static void gem_init_phy(struct gem *gp)
1687 /* Some PHYs used by apple have problem getting back to us, 1687 /* Some PHYs used by apple have problem getting back to us,
1688 * we do an additional reset here 1688 * we do an additional reset here
1689 */ 1689 */
1690 phy_write(gp, MII_BMCR, BMCR_RESET); 1690 sungem_phy_write(gp, MII_BMCR, BMCR_RESET);
1691 msleep(20); 1691 msleep(20);
1692 if (phy_read(gp, MII_BMCR) != 0xffff) 1692 if (sungem_phy_read(gp, MII_BMCR) != 0xffff)
1693 break; 1693 break;
1694 if (i == 2) 1694 if (i == 2)
1695 netdev_warn(gp->dev, "GMAC PHY not responding !\n"); 1695 netdev_warn(gp->dev, "GMAC PHY not responding !\n");
@@ -2012,7 +2012,7 @@ static int gem_check_invariants(struct gem *gp)
2012 2012
2013 for (i = 0; i < 32; i++) { 2013 for (i = 0; i < 32; i++) {
2014 gp->mii_phy_addr = i; 2014 gp->mii_phy_addr = i;
2015 if (phy_read(gp, MII_BMCR) != 0xffff) 2015 if (sungem_phy_read(gp, MII_BMCR) != 0xffff)
2016 break; 2016 break;
2017 } 2017 }
2018 if (i == 32) { 2018 if (i == 32) {
@@ -2696,13 +2696,13 @@ static int gem_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
2696 /* Fallthrough... */ 2696 /* Fallthrough... */
2697 2697
2698 case SIOCGMIIREG: /* Read MII PHY register. */ 2698 case SIOCGMIIREG: /* Read MII PHY register. */
2699 data->val_out = __phy_read(gp, data->phy_id & 0x1f, 2699 data->val_out = __sungem_phy_read(gp, data->phy_id & 0x1f,
2700 data->reg_num & 0x1f); 2700 data->reg_num & 0x1f);
2701 rc = 0; 2701 rc = 0;
2702 break; 2702 break;
2703 2703
2704 case SIOCSMIIREG: /* Write MII PHY register. */ 2704 case SIOCSMIIREG: /* Write MII PHY register. */
2705 __phy_write(gp, data->phy_id & 0x1f, data->reg_num & 0x1f, 2705 __sungem_phy_write(gp, data->phy_id & 0x1f, data->reg_num & 0x1f,
2706 data->val_in); 2706 data->val_in);
2707 rc = 0; 2707 rc = 0;
2708 break; 2708 break;
@@ -2933,8 +2933,8 @@ static int gem_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
2933 2933
2934 /* Fill up the mii_phy structure (even if we won't use it) */ 2934 /* Fill up the mii_phy structure (even if we won't use it) */
2935 gp->phy_mii.dev = dev; 2935 gp->phy_mii.dev = dev;
2936 gp->phy_mii.mdio_read = _phy_read; 2936 gp->phy_mii.mdio_read = _sungem_phy_read;
2937 gp->phy_mii.mdio_write = _phy_write; 2937 gp->phy_mii.mdio_write = _sungem_phy_write;
2938#ifdef CONFIG_PPC_PMAC 2938#ifdef CONFIG_PPC_PMAC
2939 gp->phy_mii.platform_data = gp->of_node; 2939 gp->phy_mii.platform_data = gp->of_node;
2940#endif 2940#endif