diff options
author | Sowmini Varadhan <sowmini.varadhan@oracle.com> | 2014-11-06 14:51:08 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-11-06 15:16:30 -0500 |
commit | 8c4ee3e70646d6bfdda55afe84016b914c7fdd0e (patch) | |
tree | e943ec597065f6d33713272d4e5805f3de7c052f /drivers/net/ethernet/sun | |
parent | 6c3ce8a30c1bafa8952461fb76e66e2da338b7ed (diff) |
sunvnet: Return from vnet_napi_event() if no packets to read
vnet_event_napi() may be called as part of the NAPI ->poll,
to resume reading descriptor rings. When no data is available,
descriptor ring state (e.g., rcv_nxt) needs to be reset
carefully to stay in lock-step with ldc_read(). In the interest
of simplicity, the best way to do this is to return from
vnet_event_napi() when there are no more packets to read.
The next trip through ldc_rx will correctly set up the dring state.
Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Tested-by: David Stevens <david.stevens@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/sun')
-rw-r--r-- | drivers/net/ethernet/sun/sunvnet.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/ethernet/sun/sunvnet.c b/drivers/net/ethernet/sun/sunvnet.c index 2688b19a6e63..5c5fb59adf76 100644 --- a/drivers/net/ethernet/sun/sunvnet.c +++ b/drivers/net/ethernet/sun/sunvnet.c | |||
@@ -691,7 +691,6 @@ ldc_ctrl: | |||
691 | pkt->end_idx = -1; | 691 | pkt->end_idx = -1; |
692 | goto napi_resume; | 692 | goto napi_resume; |
693 | } | 693 | } |
694 | ldc_read: | ||
695 | err = ldc_read(vio->lp, &msgbuf, sizeof(msgbuf)); | 694 | err = ldc_read(vio->lp, &msgbuf, sizeof(msgbuf)); |
696 | if (unlikely(err < 0)) { | 695 | if (unlikely(err < 0)) { |
697 | if (err == -ECONNRESET) | 696 | if (err == -ECONNRESET) |
@@ -722,8 +721,8 @@ napi_resume: | |||
722 | err = vnet_rx(port, &msgbuf, &npkts, budget); | 721 | err = vnet_rx(port, &msgbuf, &npkts, budget); |
723 | if (npkts >= budget) | 722 | if (npkts >= budget) |
724 | break; | 723 | break; |
725 | if (npkts == 0 && err != -ECONNRESET) | 724 | if (npkts == 0) |
726 | goto ldc_read; | 725 | break; |
727 | } else if (msgbuf.tag.stype == VIO_SUBTYPE_ACK) { | 726 | } else if (msgbuf.tag.stype == VIO_SUBTYPE_ACK) { |
728 | err = vnet_ack(port, &msgbuf); | 727 | err = vnet_ack(port, &msgbuf); |
729 | if (err > 0) | 728 | if (err > 0) |