ethtool: fix drvinfo strings set in drivers

Use strlcpy where possible to ensure the string is \0 terminated.
Use always sizeof(string) instead of 32, ETHTOOL_BUSINFO_LEN
and custom defines.
Use snprintf instead of sprint.
Remove unnecessary inits of ->fw_version
Remove unnecessary inits of drvinfo struct.

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 4 insertions, 3 deletions

diff --git a/drivers/net/ethernet/sun/sunqe.c b/drivers/net/ethernet/sun/sunqe.c
index 1dcee6915843..49bf3e2eb652 100644
--- a/drivers/net/ethernet/sun/sunqe.c
+++ b/drivers/net/ethernet/sun/sunqe.c
@@ -685,13 +685,14 @@ static void qe_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
         struct sunqe *qep = netdev_priv(dev);
         struct platform_device *op;
 
-        strcpy(info->driver, "sunqe");
-        strcpy(info->version, "3.0");
+        strlcpy(info->driver, "sunqe", sizeof(info->driver));
+        strlcpy(info->version, "3.0", sizeof(info->version));
 
         op = qep->op;
         regs = of_get_property(op->dev.of_node, "reg", NULL);
         if (regs)
-                sprintf(info->bus_info, "SBUS:%d", regs->which_io);
+                snprintf(info->bus_info, sizeof(info->bus_info), "SBUS:%d",
+                         regs->which_io);
 
 }