diff options
author | Rick Jones <rick.jones2@hp.com> | 2011-11-07 08:29:27 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-11-08 15:11:57 -0500 |
commit | 68aad78c5023b8aa82da99b47f9d8cf40e8ca453 (patch) | |
tree | c9f90903bd2e7831ea6fc5231affa3b9fc908b73 /drivers/net/ethernet/smsc | |
parent | 34d2d89f2d7da3b72b3157e778bbf709047ded97 (diff) |
sweep the floors and convert some .get_drvinfo routines to strlcpy
Per the mention made by Ben Hutchings that strlcpy is now the preferred
string copy routine for a .get_drvinfo routine, do a bit of floor
sweeping and convert some of the as-yet unconverted ethernet drivers to
it.
Signed-off-by: Rick Jones <rick.jones2@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/smsc')
-rw-r--r-- | drivers/net/ethernet/smsc/epic100.c | 6 | ||||
-rw-r--r-- | drivers/net/ethernet/smsc/smsc9420.c | 7 |
2 files changed, 7 insertions, 6 deletions
diff --git a/drivers/net/ethernet/smsc/epic100.c b/drivers/net/ethernet/smsc/epic100.c index 0a5dfb814157..2c077ce0b6d6 100644 --- a/drivers/net/ethernet/smsc/epic100.c +++ b/drivers/net/ethernet/smsc/epic100.c | |||
@@ -1414,9 +1414,9 @@ static void netdev_get_drvinfo (struct net_device *dev, struct ethtool_drvinfo * | |||
1414 | { | 1414 | { |
1415 | struct epic_private *np = netdev_priv(dev); | 1415 | struct epic_private *np = netdev_priv(dev); |
1416 | 1416 | ||
1417 | strcpy (info->driver, DRV_NAME); | 1417 | strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); |
1418 | strcpy (info->version, DRV_VERSION); | 1418 | strlcpy(info->version, DRV_VERSION, sizeof(info->version)); |
1419 | strcpy (info->bus_info, pci_name(np->pci_dev)); | 1419 | strlcpy(info->bus_info, pci_name(np->pci_dev), sizeof(info->bus_info)); |
1420 | } | 1420 | } |
1421 | 1421 | ||
1422 | static int netdev_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) | 1422 | static int netdev_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) |
diff --git a/drivers/net/ethernet/smsc/smsc9420.c b/drivers/net/ethernet/smsc/smsc9420.c index edb24b0e337b..a9efbdfe5302 100644 --- a/drivers/net/ethernet/smsc/smsc9420.c +++ b/drivers/net/ethernet/smsc/smsc9420.c | |||
@@ -279,9 +279,10 @@ static void smsc9420_ethtool_get_drvinfo(struct net_device *netdev, | |||
279 | { | 279 | { |
280 | struct smsc9420_pdata *pd = netdev_priv(netdev); | 280 | struct smsc9420_pdata *pd = netdev_priv(netdev); |
281 | 281 | ||
282 | strcpy(drvinfo->driver, DRV_NAME); | 282 | strlcpy(drvinfo->driver, DRV_NAME, sizeof(drvinfo->driver)); |
283 | strcpy(drvinfo->bus_info, pci_name(pd->pdev)); | 283 | strlcpy(drvinfo->bus_info, pci_name(pd->pdev), |
284 | strcpy(drvinfo->version, DRV_VERSION); | 284 | sizeof(drvinfo->bus_info)); |
285 | strlcpy(drvinfo->version, DRV_VERSION, sizeof(drvinfo->version)); | ||
285 | } | 286 | } |
286 | 287 | ||
287 | static u32 smsc9420_ethtool_get_msglevel(struct net_device *netdev) | 288 | static u32 smsc9420_ethtool_get_msglevel(struct net_device *netdev) |