diff options
author | Jingoo Han <jg1.han@samsung.com> | 2013-05-27 15:01:12 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-05-28 01:34:51 -0400 |
commit | dfd93c977d84fef77404b689ef95bc716b313533 (patch) | |
tree | ab1084c9933e81cd603f5b01d3f50b53dc2d2f5d /drivers/net/ethernet/smsc/smc91x.c | |
parent | 3acfeac351c6ab2fe1139ee13d780729af0c8145 (diff) |
net: ethernet: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Acked-by: Rob Herring <rob.herring@calxeda.com>
Acked-by: Roland Stigge <stigge@antcom.de>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Tested-by: Roland Stigge <stigge@antcom.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/smsc/smc91x.c')
-rw-r--r-- | drivers/net/ethernet/smsc/smc91x.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c index dfbf978315df..cde13be7c7de 100644 --- a/drivers/net/ethernet/smsc/smc91x.c +++ b/drivers/net/ethernet/smsc/smc91x.c | |||
@@ -2299,7 +2299,6 @@ static int smc_drv_probe(struct platform_device *pdev) | |||
2299 | return 0; | 2299 | return 0; |
2300 | 2300 | ||
2301 | out_iounmap: | 2301 | out_iounmap: |
2302 | platform_set_drvdata(pdev, NULL); | ||
2303 | iounmap(addr); | 2302 | iounmap(addr); |
2304 | out_release_attrib: | 2303 | out_release_attrib: |
2305 | smc_release_attrib(pdev, ndev); | 2304 | smc_release_attrib(pdev, ndev); |
@@ -2319,8 +2318,6 @@ static int smc_drv_remove(struct platform_device *pdev) | |||
2319 | struct smc_local *lp = netdev_priv(ndev); | 2318 | struct smc_local *lp = netdev_priv(ndev); |
2320 | struct resource *res; | 2319 | struct resource *res; |
2321 | 2320 | ||
2322 | platform_set_drvdata(pdev, NULL); | ||
2323 | |||
2324 | unregister_netdev(ndev); | 2321 | unregister_netdev(ndev); |
2325 | 2322 | ||
2326 | free_irq(ndev->irq, ndev); | 2323 | free_irq(ndev->irq, ndev); |