diff options
author | Joe Perches <joe@perches.com> | 2013-03-15 03:23:58 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-03-17 12:50:24 -0400 |
commit | 1f9061d27d3d2028805549c4a306324a48209057 (patch) | |
tree | 7cfb1a92933f5a9bba6745b68b6a964d9e757ef9 /drivers/net/ethernet/sfc | |
parent | 7f9421c264f8a6e6137027a45ae576517f66fa56 (diff) |
drivers:net: dma_alloc_coherent: use __GFP_ZERO instead of memset(, 0)
Reduce the number of calls required to alloc
a zeroed block of memory.
Trivially reduces overall object size.
Other changes around these removals
o Neaten call argument alignment
o Remove an unnecessary OOM message after dma_alloc_coherent failure
o Remove unnecessary gfp_t stack variable
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/sfc')
-rw-r--r-- | drivers/net/ethernet/sfc/nic.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/sfc/nic.c b/drivers/net/ethernet/sfc/nic.c index f9f5df8b51fe..7b87798409cc 100644 --- a/drivers/net/ethernet/sfc/nic.c +++ b/drivers/net/ethernet/sfc/nic.c | |||
@@ -305,11 +305,11 @@ int efx_nic_alloc_buffer(struct efx_nic *efx, struct efx_buffer *buffer, | |||
305 | unsigned int len) | 305 | unsigned int len) |
306 | { | 306 | { |
307 | buffer->addr = dma_alloc_coherent(&efx->pci_dev->dev, len, | 307 | buffer->addr = dma_alloc_coherent(&efx->pci_dev->dev, len, |
308 | &buffer->dma_addr, GFP_ATOMIC); | 308 | &buffer->dma_addr, |
309 | GFP_ATOMIC | __GFP_ZERO); | ||
309 | if (!buffer->addr) | 310 | if (!buffer->addr) |
310 | return -ENOMEM; | 311 | return -ENOMEM; |
311 | buffer->len = len; | 312 | buffer->len = len; |
312 | memset(buffer->addr, 0, len); | ||
313 | return 0; | 313 | return 0; |
314 | } | 314 | } |
315 | 315 | ||