diff options
author | Daniel Pieczko <dpieczko@solarflare.com> | 2012-10-17 08:21:23 -0400 |
---|---|---|
committer | Ben Hutchings <bhutchings@solarflare.com> | 2012-11-30 21:37:35 -0500 |
commit | c2f3b8e3a44b6fe9e36704e30157ebe1a88c08b1 (patch) | |
tree | a33870250f24b7b832a52bb039aee7f4b20d842b /drivers/net/ethernet/sfc/selftest.c | |
parent | 525d9e824018cd7cc8d8d44832ddcd363abfe6e1 (diff) |
sfc: lock TX queues when calling netif_device_detach()
The assertion of netif_device_present() at the top of
efx_hard_start_xmit() may fail if we don't do this.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Diffstat (limited to 'drivers/net/ethernet/sfc/selftest.c')
-rw-r--r-- | drivers/net/ethernet/sfc/selftest.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/sfc/selftest.c b/drivers/net/ethernet/sfc/selftest.c index f6651d35d615..2069f51b2aa9 100644 --- a/drivers/net/ethernet/sfc/selftest.c +++ b/drivers/net/ethernet/sfc/selftest.c | |||
@@ -722,7 +722,7 @@ int efx_selftest(struct efx_nic *efx, struct efx_self_tests *tests, | |||
722 | /* Detach the device so the kernel doesn't transmit during the | 722 | /* Detach the device so the kernel doesn't transmit during the |
723 | * loopback test and the watchdog timeout doesn't fire. | 723 | * loopback test and the watchdog timeout doesn't fire. |
724 | */ | 724 | */ |
725 | netif_device_detach(efx->net_dev); | 725 | efx_device_detach_sync(efx); |
726 | 726 | ||
727 | if (efx->type->test_chip) { | 727 | if (efx->type->test_chip) { |
728 | rc_reset = efx->type->test_chip(efx, tests); | 728 | rc_reset = efx->type->test_chip(efx, tests); |