aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/renesas
diff options
context:
space:
mode:
authorSergei Shtylyov <sergei.shtylyov@cogentembedded.com>2013-12-19 17:41:12 -0500
committerDavid S. Miller <davem@davemloft.net>2013-12-19 19:09:38 -0500
commit4174ecd78f6591a3d1ec04738ef7bc900a11f5ce (patch)
treed1e30f9d0941602c58e71bb17f4ab39c67650f88 /drivers/net/ethernet/renesas
parent18be099badcfc4a12f058addc55c4270d5a8bec8 (diff)
sh_eth: do not reset PHY needlessly
There's no need anymore to call phy_init_hw() to reset/resume the PHY from the driver, as the call chain in phylib already has reached it, and so reset/resumed the PHY (even resuming it twice). This duplicate reset is not only needless, it e.g. clears the PHY's interrupt enables just setup by phylib and so prevents the expected IRQs from the PHY. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/renesas')
-rw-r--r--drivers/net/ethernet/renesas/sh_eth.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index 9d8013f82019..ca742e1f704e 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -1703,11 +1703,6 @@ static int sh_eth_phy_start(struct net_device *ndev)
1703 if (ret) 1703 if (ret)
1704 return ret; 1704 return ret;
1705 1705
1706 /* reset phy - this also wakes it from PDOWN */
1707 ret = phy_init_hw(mdp->phydev);
1708 if (ret)
1709 return ret;
1710
1711 phy_start(mdp->phydev); 1706 phy_start(mdp->phydev);
1712 1707
1713 return 0; 1708 return 0;