diff options
author | Jingoo Han <jg1.han@samsung.com> | 2013-05-27 15:01:12 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-05-28 01:34:51 -0400 |
commit | dfd93c977d84fef77404b689ef95bc716b313533 (patch) | |
tree | ab1084c9933e81cd603f5b01d3f50b53dc2d2f5d /drivers/net/ethernet/nxp | |
parent | 3acfeac351c6ab2fe1139ee13d780729af0c8145 (diff) |
net: ethernet: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Acked-by: Rob Herring <rob.herring@calxeda.com>
Acked-by: Roland Stigge <stigge@antcom.de>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Tested-by: Roland Stigge <stigge@antcom.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/nxp')
-rw-r--r-- | drivers/net/ethernet/nxp/lpc_eth.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c index 55a5548d6add..a061b93efe66 100644 --- a/drivers/net/ethernet/nxp/lpc_eth.c +++ b/drivers/net/ethernet/nxp/lpc_eth.c | |||
@@ -1483,7 +1483,6 @@ static int lpc_eth_drv_probe(struct platform_device *pdev) | |||
1483 | return 0; | 1483 | return 0; |
1484 | 1484 | ||
1485 | err_out_unregister_netdev: | 1485 | err_out_unregister_netdev: |
1486 | platform_set_drvdata(pdev, NULL); | ||
1487 | unregister_netdev(ndev); | 1486 | unregister_netdev(ndev); |
1488 | err_out_dma_unmap: | 1487 | err_out_dma_unmap: |
1489 | if (!use_iram_for_net(&pldat->pdev->dev) || | 1488 | if (!use_iram_for_net(&pldat->pdev->dev) || |
@@ -1511,7 +1510,6 @@ static int lpc_eth_drv_remove(struct platform_device *pdev) | |||
1511 | struct netdata_local *pldat = netdev_priv(ndev); | 1510 | struct netdata_local *pldat = netdev_priv(ndev); |
1512 | 1511 | ||
1513 | unregister_netdev(ndev); | 1512 | unregister_netdev(ndev); |
1514 | platform_set_drvdata(pdev, NULL); | ||
1515 | 1513 | ||
1516 | if (!use_iram_for_net(&pldat->pdev->dev) || | 1514 | if (!use_iram_for_net(&pldat->pdev->dev) || |
1517 | pldat->dma_buff_size > lpc32xx_return_iram_size()) | 1515 | pldat->dma_buff_size > lpc32xx_return_iram_size()) |