diff options
author | Jingoo Han <jg1.han@samsung.com> | 2013-05-27 15:01:12 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-05-28 01:34:51 -0400 |
commit | dfd93c977d84fef77404b689ef95bc716b313533 (patch) | |
tree | ab1084c9933e81cd603f5b01d3f50b53dc2d2f5d /drivers/net/ethernet/nuvoton | |
parent | 3acfeac351c6ab2fe1139ee13d780729af0c8145 (diff) |
net: ethernet: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Acked-by: Rob Herring <rob.herring@calxeda.com>
Acked-by: Roland Stigge <stigge@antcom.de>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Tested-by: Roland Stigge <stigge@antcom.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/nuvoton')
-rw-r--r-- | drivers/net/ethernet/nuvoton/w90p910_ether.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/ethernet/nuvoton/w90p910_ether.c b/drivers/net/ethernet/nuvoton/w90p910_ether.c index 3df8287b7452..e88bdb1aa669 100644 --- a/drivers/net/ethernet/nuvoton/w90p910_ether.c +++ b/drivers/net/ethernet/nuvoton/w90p910_ether.c | |||
@@ -1051,7 +1051,6 @@ failed_put_clk: | |||
1051 | clk_put(ether->clk); | 1051 | clk_put(ether->clk); |
1052 | failed_free_rxirq: | 1052 | failed_free_rxirq: |
1053 | free_irq(ether->rxirq, pdev); | 1053 | free_irq(ether->rxirq, pdev); |
1054 | platform_set_drvdata(pdev, NULL); | ||
1055 | failed_free_txirq: | 1054 | failed_free_txirq: |
1056 | free_irq(ether->txirq, pdev); | 1055 | free_irq(ether->txirq, pdev); |
1057 | failed_free_io: | 1056 | failed_free_io: |
@@ -1080,7 +1079,6 @@ static int w90p910_ether_remove(struct platform_device *pdev) | |||
1080 | free_irq(ether->rxirq, dev); | 1079 | free_irq(ether->rxirq, dev); |
1081 | 1080 | ||
1082 | del_timer_sync(ðer->check_timer); | 1081 | del_timer_sync(ðer->check_timer); |
1083 | platform_set_drvdata(pdev, NULL); | ||
1084 | 1082 | ||
1085 | free_netdev(dev); | 1083 | free_netdev(dev); |
1086 | return 0; | 1084 | return 0; |