diff options
author | David S. Miller <davem@davemloft.net> | 2014-06-02 00:58:02 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-06-02 00:58:02 -0400 |
commit | ee39facbf82e73e468c504d2b40e83e2d223c28c (patch) | |
tree | 802451ae11344f94f66a8b922a5418095707517e /drivers/net/ethernet/micrel | |
parent | 2a82e40d6b66373498bf937e31b249f17dc1105a (diff) |
net: Revert mlx4 cpumask changes.
This reverts commit 70a640d0dae3a9b1b222ce673eb5d92c263ddd61
("net/mlx4_en: Use affinity hint") and commit
c8865b64b05b2f4eeefd369373e9c8aeb069e7a1 ("cpumask: Utility function
to set n'th cpu - local cpu first") because these changes break
the build when SMP is disabled amongst other things.
Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/micrel')
-rw-r--r-- | drivers/net/ethernet/micrel/ks8851.c | 50 |
1 files changed, 28 insertions, 22 deletions
diff --git a/drivers/net/ethernet/micrel/ks8851.c b/drivers/net/ethernet/micrel/ks8851.c index 66d4ab703f45..e72918970a58 100644 --- a/drivers/net/ethernet/micrel/ks8851.c +++ b/drivers/net/ethernet/micrel/ks8851.c | |||
@@ -1441,30 +1441,32 @@ static int ks8851_probe(struct spi_device *spi) | |||
1441 | } | 1441 | } |
1442 | } | 1442 | } |
1443 | 1443 | ||
1444 | ks->vdd_io = devm_regulator_get(&spi->dev, "vdd-io"); | 1444 | ks->vdd_io = devm_regulator_get_optional(&spi->dev, "vdd-io"); |
1445 | if (IS_ERR(ks->vdd_io)) { | 1445 | if (IS_ERR(ks->vdd_io)) { |
1446 | ret = PTR_ERR(ks->vdd_io); | 1446 | ret = PTR_ERR(ks->vdd_io); |
1447 | goto err_reg_io; | 1447 | if (ret == -EPROBE_DEFER) |
1448 | } | 1448 | goto err_reg_io; |
1449 | 1449 | } else { | |
1450 | ret = regulator_enable(ks->vdd_io); | 1450 | ret = regulator_enable(ks->vdd_io); |
1451 | if (ret) { | 1451 | if (ret) { |
1452 | dev_err(&spi->dev, "regulator vdd_io enable fail: %d\n", | 1452 | dev_err(&spi->dev, "regulator vdd_io enable fail: %d\n", |
1453 | ret); | 1453 | ret); |
1454 | goto err_reg_io; | 1454 | goto err_reg_io; |
1455 | } | ||
1455 | } | 1456 | } |
1456 | 1457 | ||
1457 | ks->vdd_reg = devm_regulator_get(&spi->dev, "vdd"); | 1458 | ks->vdd_reg = devm_regulator_get_optional(&spi->dev, "vdd"); |
1458 | if (IS_ERR(ks->vdd_reg)) { | 1459 | if (IS_ERR(ks->vdd_reg)) { |
1459 | ret = PTR_ERR(ks->vdd_reg); | 1460 | ret = PTR_ERR(ks->vdd_reg); |
1460 | goto err_reg; | 1461 | if (ret == -EPROBE_DEFER) |
1461 | } | 1462 | goto err_reg; |
1462 | 1463 | } else { | |
1463 | ret = regulator_enable(ks->vdd_reg); | 1464 | ret = regulator_enable(ks->vdd_reg); |
1464 | if (ret) { | 1465 | if (ret) { |
1465 | dev_err(&spi->dev, "regulator vdd enable fail: %d\n", | 1466 | dev_err(&spi->dev, "regulator vdd enable fail: %d\n", |
1466 | ret); | 1467 | ret); |
1467 | goto err_reg; | 1468 | goto err_reg; |
1469 | } | ||
1468 | } | 1470 | } |
1469 | 1471 | ||
1470 | if (gpio_is_valid(gpio)) { | 1472 | if (gpio_is_valid(gpio)) { |
@@ -1570,9 +1572,11 @@ err_irq: | |||
1570 | if (gpio_is_valid(gpio)) | 1572 | if (gpio_is_valid(gpio)) |
1571 | gpio_set_value(gpio, 0); | 1573 | gpio_set_value(gpio, 0); |
1572 | err_id: | 1574 | err_id: |
1573 | regulator_disable(ks->vdd_reg); | 1575 | if (!IS_ERR(ks->vdd_reg)) |
1576 | regulator_disable(ks->vdd_reg); | ||
1574 | err_reg: | 1577 | err_reg: |
1575 | regulator_disable(ks->vdd_io); | 1578 | if (!IS_ERR(ks->vdd_io)) |
1579 | regulator_disable(ks->vdd_io); | ||
1576 | err_reg_io: | 1580 | err_reg_io: |
1577 | err_gpio: | 1581 | err_gpio: |
1578 | free_netdev(ndev); | 1582 | free_netdev(ndev); |
@@ -1590,8 +1594,10 @@ static int ks8851_remove(struct spi_device *spi) | |||
1590 | free_irq(spi->irq, priv); | 1594 | free_irq(spi->irq, priv); |
1591 | if (gpio_is_valid(priv->gpio)) | 1595 | if (gpio_is_valid(priv->gpio)) |
1592 | gpio_set_value(priv->gpio, 0); | 1596 | gpio_set_value(priv->gpio, 0); |
1593 | regulator_disable(priv->vdd_reg); | 1597 | if (!IS_ERR(priv->vdd_reg)) |
1594 | regulator_disable(priv->vdd_io); | 1598 | regulator_disable(priv->vdd_reg); |
1599 | if (!IS_ERR(priv->vdd_io)) | ||
1600 | regulator_disable(priv->vdd_io); | ||
1595 | free_netdev(priv->netdev); | 1601 | free_netdev(priv->netdev); |
1596 | 1602 | ||
1597 | return 0; | 1603 | return 0; |