diff options
author | Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> | 2013-12-13 04:20:25 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-12-17 14:42:43 -0500 |
commit | 58911151aa0afc922f081d1516455c8833fce6b9 (patch) | |
tree | 6e04ea57679ff95420e3896c55fbc189c7947da6 /drivers/net/ethernet/marvell | |
parent | be78cfcb25fd163ad7c415cdc0ff343fbc8d22ec (diff) |
net: mv643xx_eth: properly start/stop phy device
When using phydev, it should be phy_start/phy_stop'ed properly. This
driver doesn't do that, so add the corresponding calls to port_start/
stop respectively.
Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/marvell')
-rw-r--r-- | drivers/net/ethernet/marvell/mv643xx_eth.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index b3d9327f78b9..a2565ce22b7c 100644 --- a/drivers/net/ethernet/marvell/mv643xx_eth.c +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c | |||
@@ -2080,6 +2080,7 @@ static void port_start(struct mv643xx_eth_private *mp) | |||
2080 | mv643xx_eth_get_settings(mp->dev, &cmd); | 2080 | mv643xx_eth_get_settings(mp->dev, &cmd); |
2081 | phy_init_hw(mp->phy); | 2081 | phy_init_hw(mp->phy); |
2082 | mv643xx_eth_set_settings(mp->dev, &cmd); | 2082 | mv643xx_eth_set_settings(mp->dev, &cmd); |
2083 | phy_start(mp->phy); | ||
2083 | } | 2084 | } |
2084 | 2085 | ||
2085 | /* | 2086 | /* |
@@ -2275,7 +2276,8 @@ static int mv643xx_eth_stop(struct net_device *dev) | |||
2275 | del_timer_sync(&mp->rx_oom); | 2276 | del_timer_sync(&mp->rx_oom); |
2276 | 2277 | ||
2277 | netif_carrier_off(dev); | 2278 | netif_carrier_off(dev); |
2278 | 2279 | if (mp->phy) | |
2280 | phy_stop(mp->phy); | ||
2279 | free_irq(dev->irq, dev); | 2281 | free_irq(dev->irq, dev); |
2280 | 2282 | ||
2281 | port_reset(mp); | 2283 | port_reset(mp); |