diff options
| author | Joe Perches <joe@perches.com> | 2013-02-03 12:43:58 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-02-04 13:22:33 -0500 |
| commit | b2adaca92c63b9bb8beb021d554f656e387a7648 (patch) | |
| tree | ec0ca7c14267dc090435ddbefe29b110912b851f /drivers/net/ethernet/marvell/skge.c | |
| parent | 09da6c5f60ad2e2018366e47192a9ddbccfb3ac5 (diff) | |
ethernet: Remove unnecessary alloc/OOM messages, alloc cleanups
alloc failures already get standardized OOM
messages and a dump_stack.
Convert kzalloc's with multiplies to kcalloc.
Convert kmalloc's with multiplies to kmalloc_array.
Fix a few whitespace defects.
Convert a constant 6 to ETH_ALEN.
Use parentheses around sizeof.
Convert vmalloc/memset to vzalloc.
Remove now unused size variables.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/marvell/skge.c')
| -rw-r--r-- | drivers/net/ethernet/marvell/skge.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c index 8b08bc4b8a76..171f4b3dda07 100644 --- a/drivers/net/ethernet/marvell/skge.c +++ b/drivers/net/ethernet/marvell/skge.c | |||
| @@ -3916,10 +3916,9 @@ static int skge_probe(struct pci_dev *pdev, const struct pci_device_id *ent) | |||
| 3916 | /* space for skge@pci:0000:04:00.0 */ | 3916 | /* space for skge@pci:0000:04:00.0 */ |
| 3917 | hw = kzalloc(sizeof(*hw) + strlen(DRV_NAME "@pci:") | 3917 | hw = kzalloc(sizeof(*hw) + strlen(DRV_NAME "@pci:") |
| 3918 | + strlen(pci_name(pdev)) + 1, GFP_KERNEL); | 3918 | + strlen(pci_name(pdev)) + 1, GFP_KERNEL); |
| 3919 | if (!hw) { | 3919 | if (!hw) |
| 3920 | dev_err(&pdev->dev, "cannot allocate hardware struct\n"); | ||
| 3921 | goto err_out_free_regions; | 3920 | goto err_out_free_regions; |
| 3922 | } | 3921 | |
| 3923 | sprintf(hw->irq_name, DRV_NAME "@pci:%s", pci_name(pdev)); | 3922 | sprintf(hw->irq_name, DRV_NAME "@pci:%s", pci_name(pdev)); |
| 3924 | 3923 | ||
| 3925 | hw->pdev = pdev; | 3924 | hw->pdev = pdev; |