diff options
author | Joe Perches <joe@perches.com> | 2012-06-04 08:44:16 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-06-06 12:31:33 -0400 |
commit | 6469933605a3ecdfa66b98160cde98ecd256cb3f (patch) | |
tree | 9d80273c26cbec4b3064eee47ba173be11ac444f /drivers/net/ethernet/marvell/pxa168_eth.c | |
parent | 20d5ec435c5fba8142eb7df692a5f54fbb26e892 (diff) |
ethernet: Remove casts to same type
Adding casts of objects to the same type is unnecessary
and confusing for a human reader.
For example, this cast:
int y;
int *p = (int *)&y;
I used the coccinelle script below to find and remove these
unnecessary casts. I manually removed the conversions this
script produces of casts with __force, __iomem and __user.
@@
type T;
T *p;
@@
- (T *)p
+ p
A function in atl1e_main.c was passed a const pointer
when it actually modified elements of the structure.
Change the argument to a non-const pointer.
A function in stmmac needed a __force to avoid a sparse
warning. Added it.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/marvell/pxa168_eth.c')
-rw-r--r-- | drivers/net/ethernet/marvell/pxa168_eth.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c index 1db023b075a1..59489722e898 100644 --- a/drivers/net/ethernet/marvell/pxa168_eth.c +++ b/drivers/net/ethernet/marvell/pxa168_eth.c | |||
@@ -1032,7 +1032,7 @@ static int rxq_init(struct net_device *dev) | |||
1032 | } | 1032 | } |
1033 | memset((void *)pep->p_rx_desc_area, 0, size); | 1033 | memset((void *)pep->p_rx_desc_area, 0, size); |
1034 | /* initialize the next_desc_ptr links in the Rx descriptors ring */ | 1034 | /* initialize the next_desc_ptr links in the Rx descriptors ring */ |
1035 | p_rx_desc = (struct rx_desc *)pep->p_rx_desc_area; | 1035 | p_rx_desc = pep->p_rx_desc_area; |
1036 | for (i = 0; i < rx_desc_num; i++) { | 1036 | for (i = 0; i < rx_desc_num; i++) { |
1037 | p_rx_desc[i].next_desc_ptr = pep->rx_desc_dma + | 1037 | p_rx_desc[i].next_desc_ptr = pep->rx_desc_dma + |
1038 | ((i + 1) % rx_desc_num) * sizeof(struct rx_desc); | 1038 | ((i + 1) % rx_desc_num) * sizeof(struct rx_desc); |
@@ -1095,7 +1095,7 @@ static int txq_init(struct net_device *dev) | |||
1095 | } | 1095 | } |
1096 | memset((void *)pep->p_tx_desc_area, 0, pep->tx_desc_area_size); | 1096 | memset((void *)pep->p_tx_desc_area, 0, pep->tx_desc_area_size); |
1097 | /* Initialize the next_desc_ptr links in the Tx descriptors ring */ | 1097 | /* Initialize the next_desc_ptr links in the Tx descriptors ring */ |
1098 | p_tx_desc = (struct tx_desc *)pep->p_tx_desc_area; | 1098 | p_tx_desc = pep->p_tx_desc_area; |
1099 | for (i = 0; i < tx_desc_num; i++) { | 1099 | for (i = 0; i < tx_desc_num; i++) { |
1100 | p_tx_desc[i].next_desc_ptr = pep->tx_desc_dma + | 1100 | p_tx_desc[i].next_desc_ptr = pep->tx_desc_dma + |
1101 | ((i + 1) % tx_desc_num) * sizeof(struct tx_desc); | 1101 | ((i + 1) % tx_desc_num) * sizeof(struct tx_desc); |