diff options
author | Bruce Allan <bruce.w.allan@intel.com> | 2011-12-15 19:46:54 -0500 |
---|---|---|
committer | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2012-01-26 21:30:39 -0500 |
commit | 434f1392ae3a3934a33d2d16987d857c97951c3d (patch) | |
tree | 16b75ddfb22d5f82587761e581694cf7a9a94591 /drivers/net/ethernet/intel/e1000e/ich8lan.c | |
parent | 464c85e37e6b2d2ad4f3bea23a59408c5595db15 (diff) |
e1000e: concatenate long debug strings which span multiple lines
To ease searching for debug message strings, concatenate strings that span
multiple lines even if the resulting line exceeds 80 columns; these will
not cause checkpatch warnings.
Also, add '\n' and remove unnecessary '\r' from a few debug strings.
Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/e1000e/ich8lan.c')
-rw-r--r-- | drivers/net/ethernet/intel/e1000e/ich8lan.c | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c index 6a6e6f6d9e73..53e5447cbbca 100644 --- a/drivers/net/ethernet/intel/e1000e/ich8lan.c +++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c | |||
@@ -902,8 +902,7 @@ static s32 e1000_acquire_swflag_ich8lan(struct e1000_hw *hw) | |||
902 | } | 902 | } |
903 | 903 | ||
904 | if (!timeout) { | 904 | if (!timeout) { |
905 | e_dbg("Failed to acquire the semaphore, FW or HW has it: " | 905 | e_dbg("Failed to acquire the semaphore, FW or HW has it: FWSM=0x%8.8x EXTCNF_CTRL=0x%8.8x)\n", |
906 | "FWSM=0x%8.8x EXTCNF_CTRL=0x%8.8x)\n", | ||
907 | er32(FWSM), extcnf_ctrl); | 906 | er32(FWSM), extcnf_ctrl); |
908 | extcnf_ctrl &= ~E1000_EXTCNF_CTRL_SWFLAG; | 907 | extcnf_ctrl &= ~E1000_EXTCNF_CTRL_SWFLAG; |
909 | ew32(EXTCNF_CTRL, extcnf_ctrl); | 908 | ew32(EXTCNF_CTRL, extcnf_ctrl); |
@@ -2132,8 +2131,7 @@ static s32 e1000_valid_nvm_bank_detect_ich8lan(struct e1000_hw *hw, u32 *bank) | |||
2132 | 2131 | ||
2133 | return 0; | 2132 | return 0; |
2134 | } | 2133 | } |
2135 | e_dbg("Unable to determine valid NVM bank via EEC - " | 2134 | e_dbg("Unable to determine valid NVM bank via EEC - reading flash signature\n"); |
2136 | "reading flash signature\n"); | ||
2137 | /* fall-thru */ | 2135 | /* fall-thru */ |
2138 | default: | 2136 | default: |
2139 | /* set bank to 0 in case flash read fails */ | 2137 | /* set bank to 0 in case flash read fails */ |
@@ -2245,8 +2243,7 @@ static s32 e1000_flash_cycle_init_ich8lan(struct e1000_hw *hw) | |||
2245 | 2243 | ||
2246 | /* Check if the flash descriptor is valid */ | 2244 | /* Check if the flash descriptor is valid */ |
2247 | if (hsfsts.hsf_status.fldesvalid == 0) { | 2245 | if (hsfsts.hsf_status.fldesvalid == 0) { |
2248 | e_dbg("Flash descriptor invalid. " | 2246 | e_dbg("Flash descriptor invalid. SW Sequencing must be used.\n"); |
2249 | "SW Sequencing must be used.\n"); | ||
2250 | return -E1000_ERR_NVM; | 2247 | return -E1000_ERR_NVM; |
2251 | } | 2248 | } |
2252 | 2249 | ||
@@ -2446,8 +2443,7 @@ static s32 e1000_read_flash_data_ich8lan(struct e1000_hw *hw, u32 offset, | |||
2446 | /* Repeat for some time before giving up. */ | 2443 | /* Repeat for some time before giving up. */ |
2447 | continue; | 2444 | continue; |
2448 | } else if (hsfsts.hsf_status.flcdone == 0) { | 2445 | } else if (hsfsts.hsf_status.flcdone == 0) { |
2449 | e_dbg("Timeout error - flash cycle " | 2446 | e_dbg("Timeout error - flash cycle did not complete.\n"); |
2450 | "did not complete.\n"); | ||
2451 | break; | 2447 | break; |
2452 | } | 2448 | } |
2453 | } | 2449 | } |
@@ -2798,8 +2794,7 @@ static s32 e1000_write_flash_data_ich8lan(struct e1000_hw *hw, u32 offset, | |||
2798 | /* Repeat for some time before giving up. */ | 2794 | /* Repeat for some time before giving up. */ |
2799 | continue; | 2795 | continue; |
2800 | if (hsfsts.hsf_status.flcdone == 0) { | 2796 | if (hsfsts.hsf_status.flcdone == 0) { |
2801 | e_dbg("Timeout error - flash cycle " | 2797 | e_dbg("Timeout error - flash cycle did not complete.\n"); |
2802 | "did not complete."); | ||
2803 | break; | 2798 | break; |
2804 | } | 2799 | } |
2805 | } while (count++ < ICH_FLASH_CYCLE_REPEAT_COUNT); | 2800 | } while (count++ < ICH_FLASH_CYCLE_REPEAT_COUNT); |