diff options
author | Ben Hutchings <bhutchings@solarflare.com> | 2011-09-06 09:49:12 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-09-16 19:25:10 -0400 |
commit | 815c7db5c809ea3d5735de3131ecdf758b0e14ff (patch) | |
tree | 310304287c1671468cdd7ab006eeab4a725a4dda /drivers/net/ethernet/freescale | |
parent | 434495c50ea786b89eca7f7af2bac424658a76ee (diff) |
ethtool: Clean up definitions of rule location arrays in RX NFC
Correct the description of ethtool_rxnfc::rule_locs; it is an array
of currently used locations, not all possible valid locations.
Add note that drivers must not use ethtool_rxnfc::rule_locs.
The rule_locs argument to ethtool_ops::get_rxnfc is either NULL or a
pointer to an array of u32, so change the parameter type accordingly.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/freescale')
-rw-r--r-- | drivers/net/ethernet/freescale/gianfar_ethtool.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c index 25a8c2adb001..42238301c425 100644 --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c | |||
@@ -1712,7 +1712,7 @@ static int gfar_set_nfc(struct net_device *dev, struct ethtool_rxnfc *cmd) | |||
1712 | } | 1712 | } |
1713 | 1713 | ||
1714 | static int gfar_get_nfc(struct net_device *dev, struct ethtool_rxnfc *cmd, | 1714 | static int gfar_get_nfc(struct net_device *dev, struct ethtool_rxnfc *cmd, |
1715 | void *rule_locs) | 1715 | u32 *rule_locs) |
1716 | { | 1716 | { |
1717 | struct gfar_private *priv = netdev_priv(dev); | 1717 | struct gfar_private *priv = netdev_priv(dev); |
1718 | int ret = 0; | 1718 | int ret = 0; |
@@ -1728,7 +1728,7 @@ static int gfar_get_nfc(struct net_device *dev, struct ethtool_rxnfc *cmd, | |||
1728 | ret = gfar_get_cls(priv, cmd); | 1728 | ret = gfar_get_cls(priv, cmd); |
1729 | break; | 1729 | break; |
1730 | case ETHTOOL_GRXCLSRLALL: | 1730 | case ETHTOOL_GRXCLSRLALL: |
1731 | ret = gfar_get_cls_all(priv, cmd, (u32 *) rule_locs); | 1731 | ret = gfar_get_cls_all(priv, cmd, rule_locs); |
1732 | break; | 1732 | break; |
1733 | default: | 1733 | default: |
1734 | ret = -EINVAL; | 1734 | ret = -EINVAL; |