aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/chelsio
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2014-10-08 09:43:17 -0400
committerDavid S. Miller <davem@davemloft.net>2014-10-08 16:08:04 -0400
commit9fef84780348bbc01b14c1a0f88440ee67cfddfe (patch)
treee0e89a8b21375e2718a89097174ec309549d4ff4 /drivers/net/ethernet/chelsio
parent4567dc10934292a3171f98d28817d58127b73b72 (diff)
cxgb4: potential shift wrapping bug
"cntxt_id" is an unsigned int but "udb" is a u64 so there is a potential shift wrapping bug here. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/chelsio')
-rw-r--r--drivers/net/ethernet/chelsio/cxgb4/sge.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c
index bb7851e0b4c6..e8e90ce3ae15 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/sge.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/sge.c
@@ -2258,7 +2258,7 @@ static u64 udb_address(struct adapter *adap, unsigned int cntxt_id,
2258 (QUEUESPERPAGEPF1 - QUEUESPERPAGEPF0) * adap->fn); 2258 (QUEUESPERPAGEPF1 - QUEUESPERPAGEPF0) * adap->fn);
2259 udb_density = 1 << ((qpp >> s_qpp) & QUEUESPERPAGEPF0_MASK); 2259 udb_density = 1 << ((qpp >> s_qpp) & QUEUESPERPAGEPF0_MASK);
2260 qpshift = PAGE_SHIFT - ilog2(udb_density); 2260 qpshift = PAGE_SHIFT - ilog2(udb_density);
2261 udb = cntxt_id << qpshift; 2261 udb = (u64)cntxt_id << qpshift;
2262 udb &= PAGE_MASK; 2262 udb &= PAGE_MASK;
2263 page = udb / PAGE_SIZE; 2263 page = udb / PAGE_SIZE;
2264 udb += (cntxt_id - (page * udb_density)) * SGE_UDB_SIZE; 2264 udb += (cntxt_id - (page * udb_density)) * SGE_UDB_SIZE;