drivers/net: Remove boolean comparisons to true/false

Booleans should not be compared to true or false
but be directly tested or tested with !.

Done via cocci script:

@@
bool t;
@@
- t == true
+ t
@@
bool t;
@@
- t != true
+ !t
@@
bool t;
@@
- t == false
+ !t
@@
bool t;
@@
- t != false
+ t

Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

2 files changed, 5 insertions, 5 deletions

diff --git a/drivers/net/ethernet/brocade/bna/bfa_cee.c b/drivers/net/ethernet/brocade/bna/bfa_cee.c
index 29f284f79e02..689e5e19cc0b 100644
--- a/drivers/net/ethernet/brocade/bna/bfa_cee.c
+++ b/drivers/net/ethernet/brocade/bna/bfa_cee.c
@@ -203,7 +203,7 @@ bfa_nw_cee_get_attr(struct bfa_cee *cee, struct bfa_cee_attr *attr,
         if (!bfa_nw_ioc_is_operational(cee->ioc))
                 return BFA_STATUS_IOC_FAILURE;
 
-        if (cee->get_attr_pending == true)
+        if (cee->get_attr_pending)
                 return  BFA_STATUS_DEVBUSY;
 
         cee->get_attr_pending = true;
@@ -272,7 +272,7 @@ bfa_cee_notify(void *arg, enum bfa_ioc_event event)
         switch (event) {
         case BFA_IOC_E_DISABLED:
         case BFA_IOC_E_FAILED:
-                if (cee->get_attr_pending == true) {
+                if (cee->get_attr_pending) {
                         cee->get_attr_status = BFA_STATUS_FAILED;
                         cee->get_attr_pending  = false;
                         if (cee->cbfn.get_attr_cbfn) {
@@ -281,7 +281,7 @@ bfa_cee_notify(void *arg, enum bfa_ioc_event event)
                                         BFA_STATUS_FAILED);
                         }
                 }
-                if (cee->get_stats_pending == true) {
+                if (cee->get_stats_pending) {
                         cee->get_stats_status = BFA_STATUS_FAILED;
                         cee->get_stats_pending  = false;
                         if (cee->cbfn.get_stats_cbfn) {
@@ -290,7 +290,7 @@ bfa_cee_notify(void *arg, enum bfa_ioc_event event)
                                         BFA_STATUS_FAILED);
                         }
                 }
-                if (cee->reset_stats_pending == true) {
+                if (cee->reset_stats_pending) {
                         cee->reset_stats_status = BFA_STATUS_FAILED;
                         cee->reset_stats_pending  = false;
                         if (cee->cbfn.reset_stats_cbfn) {
diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
index abfad275b5f3..77977d735dd7 100644
--- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c
+++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
@@ -692,7 +692,7 @@ static void
 bfa_iocpf_sm_mismatch_entry(struct bfa_iocpf *iocpf)
 {
         /* Call only the first time sm enters fwmismatch state. */
-        if (iocpf->fw_mismatch_notified == false)
+        if (!iocpf->fw_mismatch_notified)
                 bfa_ioc_pf_fwmismatch(iocpf->ioc);
 
         iocpf->fw_mismatch_notified = true;