diff options
author | Benoit Taine <benoit.taine@lip6.fr> | 2014-08-08 09:56:03 -0400 |
---|---|---|
committer | Bjorn Helgaas <bhelgaas@google.com> | 2014-08-12 14:15:14 -0400 |
commit | 9baa3c34ac4e27f7e062f266f50cc5dbea26a6c1 (patch) | |
tree | 2c6f874e1eb4dbb415ad96b6a39f1f7982655412 /drivers/net/ethernet/atheros | |
parent | c8d6637d0497d62093dbba0694c7b3a80b79bfe1 (diff) |
PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use
We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to
meet kernel coding style guidelines. This issue was reported by checkpatch.
A simplified version of the semantic patch that makes this change is as
follows (http://coccinelle.lip6.fr/):
// <smpl>
@@
identifier i;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer z;
@@
- DEFINE_PCI_DEVICE_TABLE(i)
+ const struct pci_device_id i[]
= z;
// </smpl>
[bhelgaas: add semantic patch]
Signed-off-by: Benoit Taine <benoit.taine@lip6.fr>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/net/ethernet/atheros')
-rw-r--r-- | drivers/net/ethernet/atheros/alx/main.c | 2 | ||||
-rw-r--r-- | drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 2 | ||||
-rw-r--r-- | drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 2 | ||||
-rw-r--r-- | drivers/net/ethernet/atheros/atlx/atl1.c | 2 | ||||
-rw-r--r-- | drivers/net/ethernet/atheros/atlx/atl2.c | 2 |
5 files changed, 5 insertions, 5 deletions
diff --git a/drivers/net/ethernet/atheros/alx/main.c b/drivers/net/ethernet/atheros/alx/main.c index 49faa97a30c3..e398eda07298 100644 --- a/drivers/net/ethernet/atheros/alx/main.c +++ b/drivers/net/ethernet/atheros/alx/main.c | |||
@@ -1527,7 +1527,7 @@ static const struct pci_error_handlers alx_err_handlers = { | |||
1527 | .resume = alx_pci_error_resume, | 1527 | .resume = alx_pci_error_resume, |
1528 | }; | 1528 | }; |
1529 | 1529 | ||
1530 | static DEFINE_PCI_DEVICE_TABLE(alx_pci_tbl) = { | 1530 | static const struct pci_device_id alx_pci_tbl[] = { |
1531 | { PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_AR8161), | 1531 | { PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_AR8161), |
1532 | .driver_data = ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG }, | 1532 | .driver_data = ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG }, |
1533 | { PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_E2200), | 1533 | { PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_E2200), |
diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c index e11bf18fbbd1..72fb86b9aa24 100644 --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c | |||
@@ -34,7 +34,7 @@ char atl1c_driver_version[] = ATL1C_DRV_VERSION; | |||
34 | * { Vendor ID, Device ID, SubVendor ID, SubDevice ID, | 34 | * { Vendor ID, Device ID, SubVendor ID, SubDevice ID, |
35 | * Class, Class Mask, private data (not used) } | 35 | * Class, Class Mask, private data (not used) } |
36 | */ | 36 | */ |
37 | static DEFINE_PCI_DEVICE_TABLE(atl1c_pci_tbl) = { | 37 | static const struct pci_device_id atl1c_pci_tbl[] = { |
38 | {PCI_DEVICE(PCI_VENDOR_ID_ATTANSIC, PCI_DEVICE_ID_ATTANSIC_L1C)}, | 38 | {PCI_DEVICE(PCI_VENDOR_ID_ATTANSIC, PCI_DEVICE_ID_ATTANSIC_L1C)}, |
39 | {PCI_DEVICE(PCI_VENDOR_ID_ATTANSIC, PCI_DEVICE_ID_ATTANSIC_L2C)}, | 39 | {PCI_DEVICE(PCI_VENDOR_ID_ATTANSIC, PCI_DEVICE_ID_ATTANSIC_L2C)}, |
40 | {PCI_DEVICE(PCI_VENDOR_ID_ATTANSIC, PCI_DEVICE_ID_ATHEROS_L2C_B)}, | 40 | {PCI_DEVICE(PCI_VENDOR_ID_ATTANSIC, PCI_DEVICE_ID_ATHEROS_L2C_B)}, |
diff --git a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c index 316e0c3fe048..2326579f9454 100644 --- a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c +++ b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c | |||
@@ -35,7 +35,7 @@ char atl1e_driver_version[] = DRV_VERSION; | |||
35 | * { Vendor ID, Device ID, SubVendor ID, SubDevice ID, | 35 | * { Vendor ID, Device ID, SubVendor ID, SubDevice ID, |
36 | * Class, Class Mask, private data (not used) } | 36 | * Class, Class Mask, private data (not used) } |
37 | */ | 37 | */ |
38 | static DEFINE_PCI_DEVICE_TABLE(atl1e_pci_tbl) = { | 38 | static const struct pci_device_id atl1e_pci_tbl[] = { |
39 | {PCI_DEVICE(PCI_VENDOR_ID_ATTANSIC, PCI_DEVICE_ID_ATTANSIC_L1E)}, | 39 | {PCI_DEVICE(PCI_VENDOR_ID_ATTANSIC, PCI_DEVICE_ID_ATTANSIC_L1E)}, |
40 | {PCI_DEVICE(PCI_VENDOR_ID_ATTANSIC, 0x1066)}, | 40 | {PCI_DEVICE(PCI_VENDOR_ID_ATTANSIC, 0x1066)}, |
41 | /* required last entry */ | 41 | /* required last entry */ |
diff --git a/drivers/net/ethernet/atheros/atlx/atl1.c b/drivers/net/ethernet/atheros/atlx/atl1.c index 1546d550ac97..2c8f398aeda9 100644 --- a/drivers/net/ethernet/atheros/atlx/atl1.c +++ b/drivers/net/ethernet/atheros/atlx/atl1.c | |||
@@ -235,7 +235,7 @@ static void atl1_check_options(struct atl1_adapter *adapter) | |||
235 | /* | 235 | /* |
236 | * atl1_pci_tbl - PCI Device ID Table | 236 | * atl1_pci_tbl - PCI Device ID Table |
237 | */ | 237 | */ |
238 | static DEFINE_PCI_DEVICE_TABLE(atl1_pci_tbl) = { | 238 | static const struct pci_device_id atl1_pci_tbl[] = { |
239 | {PCI_DEVICE(PCI_VENDOR_ID_ATTANSIC, PCI_DEVICE_ID_ATTANSIC_L1)}, | 239 | {PCI_DEVICE(PCI_VENDOR_ID_ATTANSIC, PCI_DEVICE_ID_ATTANSIC_L1)}, |
240 | /* required last entry */ | 240 | /* required last entry */ |
241 | {0,} | 241 | {0,} |
diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c b/drivers/net/ethernet/atheros/atlx/atl2.c index c194bc687c30..84a09e8ddd9c 100644 --- a/drivers/net/ethernet/atheros/atlx/atl2.c +++ b/drivers/net/ethernet/atheros/atlx/atl2.c | |||
@@ -65,7 +65,7 @@ MODULE_VERSION(ATL2_DRV_VERSION); | |||
65 | /* | 65 | /* |
66 | * atl2_pci_tbl - PCI Device ID Table | 66 | * atl2_pci_tbl - PCI Device ID Table |
67 | */ | 67 | */ |
68 | static DEFINE_PCI_DEVICE_TABLE(atl2_pci_tbl) = { | 68 | static const struct pci_device_id atl2_pci_tbl[] = { |
69 | {PCI_DEVICE(PCI_VENDOR_ID_ATTANSIC, PCI_DEVICE_ID_ATTANSIC_L2)}, | 69 | {PCI_DEVICE(PCI_VENDOR_ID_ATTANSIC, PCI_DEVICE_ID_ATTANSIC_L2)}, |
70 | /* required last entry */ | 70 | /* required last entry */ |
71 | {0,} | 71 | {0,} |