diff options
author | Joe Perches <joe@perches.com> | 2012-06-04 08:44:16 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-06-06 12:31:33 -0400 |
commit | 6469933605a3ecdfa66b98160cde98ecd256cb3f (patch) | |
tree | 9d80273c26cbec4b3064eee47ba173be11ac444f /drivers/net/ethernet/atheros/atlx | |
parent | 20d5ec435c5fba8142eb7df692a5f54fbb26e892 (diff) |
ethernet: Remove casts to same type
Adding casts of objects to the same type is unnecessary
and confusing for a human reader.
For example, this cast:
int y;
int *p = (int *)&y;
I used the coccinelle script below to find and remove these
unnecessary casts. I manually removed the conversions this
script produces of casts with __force, __iomem and __user.
@@
type T;
T *p;
@@
- (T *)p
+ p
A function in atl1e_main.c was passed a const pointer
when it actually modified elements of the structure.
Change the argument to a non-const pointer.
A function in stmmac needed a __force to avoid a sparse
warning. Added it.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/atheros/atlx')
-rw-r--r-- | drivers/net/ethernet/atheros/atlx/atl1.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/atheros/atlx/atl1.c b/drivers/net/ethernet/atheros/atlx/atl1.c index 5d10884e5080..149a294d54e9 100644 --- a/drivers/net/ethernet/atheros/atlx/atl1.c +++ b/drivers/net/ethernet/atheros/atlx/atl1.c | |||
@@ -1061,7 +1061,7 @@ static s32 atl1_setup_ring_resources(struct atl1_adapter *adapter) | |||
1061 | goto err_nomem; | 1061 | goto err_nomem; |
1062 | } | 1062 | } |
1063 | rfd_ring->buffer_info = | 1063 | rfd_ring->buffer_info = |
1064 | (struct atl1_buffer *)(tpd_ring->buffer_info + tpd_ring->count); | 1064 | (tpd_ring->buffer_info + tpd_ring->count); |
1065 | 1065 | ||
1066 | /* | 1066 | /* |
1067 | * real ring DMA buffer | 1067 | * real ring DMA buffer |