diff options
author | Joe Perches <joe@perches.com> | 2014-09-09 23:27:44 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-09-09 23:37:08 -0400 |
commit | fe3881cf7e09dfb93e4a4c65f44e2d92f92d0022 (patch) | |
tree | 43d950cfb847614ba2e0cea08d8d024502aa8a47 /drivers/net/ethernet/3com | |
parent | 46cfd725c377bc5bb32b56b5151d6de4cb5a71e3 (diff) |
drivers/net: Convert remaining uses of pr_warning to pr_warn
Use the much more common pr_warn instead of pr_warning.
Other miscellanea:
o Typo fixes submiting/submitting
o Coalesce formats
o Realign arguments
o Add missing terminating '\n' to formats
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/3com')
-rw-r--r-- | drivers/net/ethernet/3com/3c509.c | 6 | ||||
-rw-r--r-- | drivers/net/ethernet/3com/3c515.c | 25 | ||||
-rw-r--r-- | drivers/net/ethernet/3com/3c59x.c | 27 |
3 files changed, 28 insertions, 30 deletions
diff --git a/drivers/net/ethernet/3com/3c509.c b/drivers/net/ethernet/3com/3c509.c index a968654b631d..4547a1b8b958 100644 --- a/drivers/net/ethernet/3com/3c509.c +++ b/drivers/net/ethernet/3com/3c509.c | |||
@@ -695,9 +695,9 @@ el3_tx_timeout (struct net_device *dev) | |||
695 | int ioaddr = dev->base_addr; | 695 | int ioaddr = dev->base_addr; |
696 | 696 | ||
697 | /* Transmitter timeout, serious problems. */ | 697 | /* Transmitter timeout, serious problems. */ |
698 | pr_warning("%s: transmit timed out, Tx_status %2.2x status %4.4x Tx FIFO room %d.\n", | 698 | pr_warn("%s: transmit timed out, Tx_status %2.2x status %4.4x Tx FIFO room %d\n", |
699 | dev->name, inb(ioaddr + TX_STATUS), inw(ioaddr + EL3_STATUS), | 699 | dev->name, inb(ioaddr + TX_STATUS), inw(ioaddr + EL3_STATUS), |
700 | inw(ioaddr + TX_FREE)); | 700 | inw(ioaddr + TX_FREE)); |
701 | dev->stats.tx_errors++; | 701 | dev->stats.tx_errors++; |
702 | dev->trans_start = jiffies; /* prevent tx timeout */ | 702 | dev->trans_start = jiffies; /* prevent tx timeout */ |
703 | /* Issue TX_RESET and TX_START commands. */ | 703 | /* Issue TX_RESET and TX_START commands. */ |
diff --git a/drivers/net/ethernet/3com/3c515.c b/drivers/net/ethernet/3com/3c515.c index 94c656f5a05d..942fb0d5aace 100644 --- a/drivers/net/ethernet/3com/3c515.c +++ b/drivers/net/ethernet/3com/3c515.c | |||
@@ -515,7 +515,7 @@ static struct net_device *corkscrew_scan(int unit) | |||
515 | if (pnp_device_attach(idev) < 0) | 515 | if (pnp_device_attach(idev) < 0) |
516 | continue; | 516 | continue; |
517 | if (pnp_activate_dev(idev) < 0) { | 517 | if (pnp_activate_dev(idev) < 0) { |
518 | pr_warning("pnp activate failed (out of resources?)\n"); | 518 | pr_warn("pnp activate failed (out of resources?)\n"); |
519 | pnp_device_detach(idev); | 519 | pnp_device_detach(idev); |
520 | continue; | 520 | continue; |
521 | } | 521 | } |
@@ -659,7 +659,7 @@ static int corkscrew_setup(struct net_device *dev, int ioaddr, | |||
659 | pr_cont(", IRQ %d\n", dev->irq); | 659 | pr_cont(", IRQ %d\n", dev->irq); |
660 | /* Tell them about an invalid IRQ. */ | 660 | /* Tell them about an invalid IRQ. */ |
661 | if (corkscrew_debug && (dev->irq <= 0 || dev->irq > 15)) | 661 | if (corkscrew_debug && (dev->irq <= 0 || dev->irq > 15)) |
662 | pr_warning(" *** Warning: this IRQ is unlikely to work! ***\n"); | 662 | pr_warn(" *** Warning: this IRQ is unlikely to work! ***\n"); |
663 | 663 | ||
664 | { | 664 | { |
665 | static const char * const ram_split[] = { | 665 | static const char * const ram_split[] = { |
@@ -967,13 +967,13 @@ static void corkscrew_timeout(struct net_device *dev) | |||
967 | struct corkscrew_private *vp = netdev_priv(dev); | 967 | struct corkscrew_private *vp = netdev_priv(dev); |
968 | int ioaddr = dev->base_addr; | 968 | int ioaddr = dev->base_addr; |
969 | 969 | ||
970 | pr_warning("%s: transmit timed out, tx_status %2.2x status %4.4x.\n", | 970 | pr_warn("%s: transmit timed out, tx_status %2.2x status %4.4x\n", |
971 | dev->name, inb(ioaddr + TxStatus), | 971 | dev->name, inb(ioaddr + TxStatus), |
972 | inw(ioaddr + EL3_STATUS)); | 972 | inw(ioaddr + EL3_STATUS)); |
973 | /* Slight code bloat to be user friendly. */ | 973 | /* Slight code bloat to be user friendly. */ |
974 | if ((inb(ioaddr + TxStatus) & 0x88) == 0x88) | 974 | if ((inb(ioaddr + TxStatus) & 0x88) == 0x88) |
975 | pr_warning("%s: Transmitter encountered 16 collisions --" | 975 | pr_warn("%s: Transmitter encountered 16 collisions -- network cable problem?\n", |
976 | " network cable problem?\n", dev->name); | 976 | dev->name); |
977 | #ifndef final_version | 977 | #ifndef final_version |
978 | pr_debug(" Flags; bus-master %d, full %d; dirty %d current %d.\n", | 978 | pr_debug(" Flags; bus-master %d, full %d; dirty %d current %d.\n", |
979 | vp->full_bus_master_tx, vp->tx_full, vp->dirty_tx, | 979 | vp->full_bus_master_tx, vp->tx_full, vp->dirty_tx, |
@@ -1382,13 +1382,10 @@ static int boomerang_rx(struct net_device *dev) | |||
1382 | temp = skb_put(skb, pkt_len); | 1382 | temp = skb_put(skb, pkt_len); |
1383 | /* Remove this checking code for final release. */ | 1383 | /* Remove this checking code for final release. */ |
1384 | if (isa_bus_to_virt(vp->rx_ring[entry].addr) != temp) | 1384 | if (isa_bus_to_virt(vp->rx_ring[entry].addr) != temp) |
1385 | pr_warning("%s: Warning -- the skbuff addresses do not match" | 1385 | pr_warn("%s: Warning -- the skbuff addresses do not match in boomerang_rx: %p vs. %p / %p\n", |
1386 | " in boomerang_rx: %p vs. %p / %p.\n", | 1386 | dev->name, |
1387 | dev->name, | 1387 | isa_bus_to_virt(vp->rx_ring[entry].addr), |
1388 | isa_bus_to_virt(vp-> | 1388 | skb->head, temp); |
1389 | rx_ring[entry]. | ||
1390 | addr), skb->head, | ||
1391 | temp); | ||
1392 | rx_nocopy++; | 1389 | rx_nocopy++; |
1393 | } | 1390 | } |
1394 | skb->protocol = eth_type_trans(skb, dev); | 1391 | skb->protocol = eth_type_trans(skb, dev); |
diff --git a/drivers/net/ethernet/3com/3c59x.c b/drivers/net/ethernet/3com/3c59x.c index 3fe45c705933..2b92d712f212 100644 --- a/drivers/net/ethernet/3com/3c59x.c +++ b/drivers/net/ethernet/3com/3c59x.c | |||
@@ -1310,8 +1310,8 @@ static int vortex_probe1(struct device *gendev, void __iomem *ioaddr, int irq, | |||
1310 | pr_cont(", IRQ %d\n", dev->irq); | 1310 | pr_cont(", IRQ %d\n", dev->irq); |
1311 | /* Tell them about an invalid IRQ. */ | 1311 | /* Tell them about an invalid IRQ. */ |
1312 | if (dev->irq <= 0 || dev->irq >= nr_irqs) | 1312 | if (dev->irq <= 0 || dev->irq >= nr_irqs) |
1313 | pr_warning(" *** Warning: IRQ %d is unlikely to work! ***\n", | 1313 | pr_warn(" *** Warning: IRQ %d is unlikely to work! ***\n", |
1314 | dev->irq); | 1314 | dev->irq); |
1315 | 1315 | ||
1316 | step = (window_read8(vp, 4, Wn4_NetDiag) & 0x1e) >> 1; | 1316 | step = (window_read8(vp, 4, Wn4_NetDiag) & 0x1e) >> 1; |
1317 | if (print_info) { | 1317 | if (print_info) { |
@@ -1425,7 +1425,7 @@ static int vortex_probe1(struct device *gendev, void __iomem *ioaddr, int irq, | |||
1425 | } | 1425 | } |
1426 | mii_preamble_required--; | 1426 | mii_preamble_required--; |
1427 | if (phy_idx == 0) { | 1427 | if (phy_idx == 0) { |
1428 | pr_warning(" ***WARNING*** No MII transceivers found!\n"); | 1428 | pr_warn(" ***WARNING*** No MII transceivers found!\n"); |
1429 | vp->phys[0] = 24; | 1429 | vp->phys[0] = 24; |
1430 | } else { | 1430 | } else { |
1431 | vp->advertising = mdio_read(dev, vp->phys[0], MII_ADVERTISE); | 1431 | vp->advertising = mdio_read(dev, vp->phys[0], MII_ADVERTISE); |
@@ -1566,8 +1566,7 @@ vortex_up(struct net_device *dev) | |||
1566 | pci_restore_state(VORTEX_PCI(vp)); | 1566 | pci_restore_state(VORTEX_PCI(vp)); |
1567 | err = pci_enable_device(VORTEX_PCI(vp)); | 1567 | err = pci_enable_device(VORTEX_PCI(vp)); |
1568 | if (err) { | 1568 | if (err) { |
1569 | pr_warning("%s: Could not enable device\n", | 1569 | pr_warn("%s: Could not enable device\n", dev->name); |
1570 | dev->name); | ||
1571 | goto err_out; | 1570 | goto err_out; |
1572 | } | 1571 | } |
1573 | } | 1572 | } |
@@ -2007,8 +2006,8 @@ vortex_error(struct net_device *dev, int status) | |||
2007 | /* This occurs when we have the wrong media type! */ | 2006 | /* This occurs when we have the wrong media type! */ |
2008 | if (DoneDidThat == 0 && | 2007 | if (DoneDidThat == 0 && |
2009 | ioread16(ioaddr + EL3_STATUS) & StatsFull) { | 2008 | ioread16(ioaddr + EL3_STATUS) & StatsFull) { |
2010 | pr_warning("%s: Updating statistics failed, disabling " | 2009 | pr_warn("%s: Updating statistics failed, disabling stats as an interrupt source\n", |
2011 | "stats as an interrupt source.\n", dev->name); | 2010 | dev->name); |
2012 | iowrite16(SetIntrEnb | | 2011 | iowrite16(SetIntrEnb | |
2013 | (window_read16(vp, 5, 10) & ~StatsFull), | 2012 | (window_read16(vp, 5, 10) & ~StatsFull), |
2014 | ioaddr + EL3_CMD); | 2013 | ioaddr + EL3_CMD); |
@@ -2147,8 +2146,8 @@ boomerang_start_xmit(struct sk_buff *skb, struct net_device *dev) | |||
2147 | 2146 | ||
2148 | if (vp->cur_tx - vp->dirty_tx >= TX_RING_SIZE) { | 2147 | if (vp->cur_tx - vp->dirty_tx >= TX_RING_SIZE) { |
2149 | if (vortex_debug > 0) | 2148 | if (vortex_debug > 0) |
2150 | pr_warning("%s: BUG! Tx Ring full, refusing to send buffer.\n", | 2149 | pr_warn("%s: BUG! Tx Ring full, refusing to send buffer\n", |
2151 | dev->name); | 2150 | dev->name); |
2152 | netif_stop_queue(dev); | 2151 | netif_stop_queue(dev); |
2153 | return NETDEV_TX_BUSY; | 2152 | return NETDEV_TX_BUSY; |
2154 | } | 2153 | } |
@@ -2311,7 +2310,7 @@ vortex_interrupt(int irq, void *dev_id) | |||
2311 | } | 2310 | } |
2312 | 2311 | ||
2313 | if (--work_done < 0) { | 2312 | if (--work_done < 0) { |
2314 | pr_warning("%s: Too much work in interrupt, status %4.4x.\n", | 2313 | pr_warn("%s: Too much work in interrupt, status %4.4x\n", |
2315 | dev->name, status); | 2314 | dev->name, status); |
2316 | /* Disable all pending interrupts. */ | 2315 | /* Disable all pending interrupts. */ |
2317 | do { | 2316 | do { |
@@ -2444,7 +2443,7 @@ boomerang_interrupt(int irq, void *dev_id) | |||
2444 | vortex_error(dev, status); | 2443 | vortex_error(dev, status); |
2445 | 2444 | ||
2446 | if (--work_done < 0) { | 2445 | if (--work_done < 0) { |
2447 | pr_warning("%s: Too much work in interrupt, status %4.4x.\n", | 2446 | pr_warn("%s: Too much work in interrupt, status %4.4x\n", |
2448 | dev->name, status); | 2447 | dev->name, status); |
2449 | /* Disable all pending interrupts. */ | 2448 | /* Disable all pending interrupts. */ |
2450 | do { | 2449 | do { |
@@ -2620,7 +2619,8 @@ boomerang_rx(struct net_device *dev) | |||
2620 | if (skb == NULL) { | 2619 | if (skb == NULL) { |
2621 | static unsigned long last_jif; | 2620 | static unsigned long last_jif; |
2622 | if (time_after(jiffies, last_jif + 10 * HZ)) { | 2621 | if (time_after(jiffies, last_jif + 10 * HZ)) { |
2623 | pr_warning("%s: memory shortage\n", dev->name); | 2622 | pr_warn("%s: memory shortage\n", |
2623 | dev->name); | ||
2624 | last_jif = jiffies; | 2624 | last_jif = jiffies; |
2625 | } | 2625 | } |
2626 | if ((vp->cur_rx - vp->dirty_rx) == RX_RING_SIZE) | 2626 | if ((vp->cur_rx - vp->dirty_rx) == RX_RING_SIZE) |
@@ -2719,7 +2719,8 @@ vortex_close(struct net_device *dev) | |||
2719 | if (vp->rx_csumhits && | 2719 | if (vp->rx_csumhits && |
2720 | (vp->drv_flags & HAS_HWCKSM) == 0 && | 2720 | (vp->drv_flags & HAS_HWCKSM) == 0 && |
2721 | (vp->card_idx >= MAX_UNITS || hw_checksums[vp->card_idx] == -1)) { | 2721 | (vp->card_idx >= MAX_UNITS || hw_checksums[vp->card_idx] == -1)) { |
2722 | pr_warning("%s supports hardware checksums, and we're not using them!\n", dev->name); | 2722 | pr_warn("%s supports hardware checksums, and we're not using them!\n", |
2723 | dev->name); | ||
2723 | } | 2724 | } |
2724 | #endif | 2725 | #endif |
2725 | 2726 | ||