Merge branch 'upstream-linus' of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6

* 'upstream-linus' of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6: (107 commits)
  smc911x: fix compilation breakage wjen debug is on
  [netdrvr] eexpress: minor corrections
  add NAPI support to sb1250-mac.c
  ixgb: ROUND_UP macro cleanup in drivers/net/ixgb
  e1000: ROUND_UP macro cleanup in drivers/net/e1000
  Generic HDLC sparse annotations
  e100: Optionally use I/O mode only to access register space
  e100: allow bad MAC address when running with invalid eeprom csum
  ehea: fix for dlpar support
  ehea: fix for sysfs entries
  3C509: Remove unnecessary include of <linux/pm_legacy.h>
  NetXen: Fix for vmalloc issues
  NetXen: Fixes for Power PC architecture
  NetXen: Port swap feature for multi port cards
  NetXen: Removal of redundant macros
  NetXen: Multi PCI support for Quad cards
  NetXen: Removal of redundant argument passing
  NetXen: Use multiple PCI functions
  [netdrvr e100] experiment with doing RX in a similar manner to eepro100
  [PATCH] ieee80211: add missing global needed by IEEE80211_DEBUG_XXXX
  ...

4 files changed, 38 insertions, 48 deletions

diff --git a/drivers/net/e1000/e1000.h b/drivers/net/e1000/e1000.h
index dd4b728ac4b5..a9ea67e75c1b 100644
--- a/drivers/net/e1000/e1000.h
+++ b/drivers/net/e1000/e1000.h
@@ -155,9 +155,6 @@ struct e1000_adapter;
 /* Number of packet split data buffers (not including the header buffer) */
 #define PS_PAGE_BUFFERS MAX_PS_BUFFERS-1
 
-/* only works for sizes that are powers of 2 */
-#define E1000_ROUNDUP(i, size) ((i) = (((i) + (size) - 1) & ~((size) - 1)))
-
 /* wrapper around a pointer to a socket buffer,
  * so a DMA handle can be stored along with the buffer */
 struct e1000_buffer {
diff --git a/drivers/net/e1000/e1000_ethtool.c b/drivers/net/e1000/e1000_ethtool.c
index 6777887295f5..bb08375b5f13 100644
--- a/drivers/net/e1000/e1000_ethtool.c
+++ b/drivers/net/e1000/e1000_ethtool.c
@@ -654,14 +654,11 @@ e1000_set_ringparam(struct net_device *netdev,
         e1000_mac_type mac_type = adapter->hw.mac_type;
         struct e1000_tx_ring *txdr, *tx_old;
         struct e1000_rx_ring *rxdr, *rx_old;
-        int i, err, tx_ring_size, rx_ring_size;
+        int i, err;
 
         if ((ring->rx_mini_pending) || (ring->rx_jumbo_pending))
                 return -EINVAL;
 
-        tx_ring_size = sizeof(struct e1000_tx_ring) * adapter->num_tx_queues;
-        rx_ring_size = sizeof(struct e1000_rx_ring) * adapter->num_rx_queues;
-
         while (test_and_set_bit(__E1000_RESETTING, &adapter->flags))
                 msleep(1);
 
@@ -672,11 +669,11 @@ e1000_set_ringparam(struct net_device *netdev,
         rx_old = adapter->rx_ring;
 
         err = -ENOMEM;
-        txdr = kzalloc(tx_ring_size, GFP_KERNEL);
+        txdr = kcalloc(adapter->num_tx_queues, sizeof(struct e1000_tx_ring), GFP_KERNEL);
         if (!txdr)
                 goto err_alloc_tx;
 
-        rxdr = kzalloc(rx_ring_size, GFP_KERNEL);
+        rxdr = kcalloc(adapter->num_rx_queues, sizeof(struct e1000_rx_ring), GFP_KERNEL);
         if (!rxdr)
                 goto err_alloc_rx;
 
@@ -686,12 +683,12 @@ e1000_set_ringparam(struct net_device *netdev,
         rxdr->count = max(ring->rx_pending,(uint32_t)E1000_MIN_RXD);
         rxdr->count = min(rxdr->count,(uint32_t)(mac_type < e1000_82544 ?
                 E1000_MAX_RXD : E1000_MAX_82544_RXD));
-        E1000_ROUNDUP(rxdr->count, REQ_RX_DESCRIPTOR_MULTIPLE);
+        rxdr->count = ALIGN(rxdr->count, REQ_RX_DESCRIPTOR_MULTIPLE);
 
         txdr->count = max(ring->tx_pending,(uint32_t)E1000_MIN_TXD);
         txdr->count = min(txdr->count,(uint32_t)(mac_type < e1000_82544 ?
                 E1000_MAX_TXD : E1000_MAX_82544_TXD));
-        E1000_ROUNDUP(txdr->count, REQ_TX_DESCRIPTOR_MULTIPLE);
+        txdr->count = ALIGN(txdr->count, REQ_TX_DESCRIPTOR_MULTIPLE);
 
         for (i = 0; i < adapter->num_tx_queues; i++)
                 txdr[i].count = txdr->count;
@@ -742,7 +739,7 @@ err_setup:
         uint32_t pat, value;                                                   \
         uint32_t test[] =                                                      \
                 {0x5A5A5A5A, 0xA5A5A5A5, 0x00000000, 0xFFFFFFFF};              \
-        for (pat = 0; pat < sizeof(test)/sizeof(test[0]); pat++) {              \
+        for (pat = 0; pat < ARRAY_SIZE(test); pat++) {              \
                 E1000_WRITE_REG(&adapter->hw, R, (test[pat] & W));             \
                 value = E1000_READ_REG(&adapter->hw, R);                       \
                 if (value != (test[pat] & W & M)) {                             \
@@ -1053,23 +1050,24 @@ e1000_setup_desc_rings(struct e1000_adapter *adapter)
         struct e1000_rx_ring *rxdr = &adapter->test_rx_ring;
         struct pci_dev *pdev = adapter->pdev;
         uint32_t rctl;
-        int size, i, ret_val;
+        int i, ret_val;
 
         /* Setup Tx descriptor ring and Tx buffers */
 
         if (!txdr->count)
                 txdr->count = E1000_DEFAULT_TXD;
 
-        size = txdr->count * sizeof(struct e1000_buffer);
-        if (!(txdr->buffer_info = kmalloc(size, GFP_KERNEL))) {
+        if (!(txdr->buffer_info = kcalloc(txdr->count,
+                                          sizeof(struct e1000_buffer),
+                                          GFP_KERNEL))) {
                 ret_val = 1;
                 goto err_nomem;
         }
-        memset(txdr->buffer_info, 0, size);
 
         txdr->size = txdr->count * sizeof(struct e1000_tx_desc);
-        E1000_ROUNDUP(txdr->size, 4096);
-        if (!(txdr->desc = pci_alloc_consistent(pdev, txdr->size, &txdr->dma))) {
+        txdr->size = ALIGN(txdr->size, 4096);
+        if (!(txdr->desc = pci_alloc_consistent(pdev, txdr->size,
+                                                &txdr->dma))) {
                 ret_val = 2;
                 goto err_nomem;
         }
@@ -1116,12 +1114,12 @@ e1000_setup_desc_rings(struct e1000_adapter *adapter)
         if (!rxdr->count)
                 rxdr->count = E1000_DEFAULT_RXD;
 
-        size = rxdr->count * sizeof(struct e1000_buffer);
-        if (!(rxdr->buffer_info = kmalloc(size, GFP_KERNEL))) {
+        if (!(rxdr->buffer_info = kcalloc(rxdr->count,
+                                          sizeof(struct e1000_buffer),
+                                          GFP_KERNEL))) {
                 ret_val = 4;
                 goto err_nomem;
         }
-        memset(rxdr->buffer_info, 0, size);
 
         rxdr->size = rxdr->count * sizeof(struct e1000_rx_desc);
         if (!(rxdr->desc = pci_alloc_consistent(pdev, rxdr->size, &rxdr->dma))) {
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index 9267f16b1b32..3a03a74c0609 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -748,9 +748,9 @@ e1000_reset(struct e1000_adapter *adapter)
                                VLAN_TAG_SIZE;
                 min_tx_space = min_rx_space;
                 min_tx_space *= 2;
-                E1000_ROUNDUP(min_tx_space, 1024);
+                min_tx_space = ALIGN(min_tx_space, 1024);
                 min_tx_space >>= 10;
-                E1000_ROUNDUP(min_rx_space, 1024);
+                min_rx_space = ALIGN(min_rx_space, 1024);
                 min_rx_space >>= 10;
 
                 /* If current Tx allocation is less than the min Tx FIFO size,
@@ -1354,31 +1354,27 @@ e1000_sw_init(struct e1000_adapter *adapter)
 static int __devinit
 e1000_alloc_queues(struct e1000_adapter *adapter)
 {
-        int size;
-
-        size = sizeof(struct e1000_tx_ring) * adapter->num_tx_queues;
-        adapter->tx_ring = kmalloc(size, GFP_KERNEL);
+        adapter->tx_ring = kcalloc(adapter->num_tx_queues,
+                                   sizeof(struct e1000_tx_ring), GFP_KERNEL);
         if (!adapter->tx_ring)
                 return -ENOMEM;
-        memset(adapter->tx_ring, 0, size);
 
-        size = sizeof(struct e1000_rx_ring) * adapter->num_rx_queues;
-        adapter->rx_ring = kmalloc(size, GFP_KERNEL);
+        adapter->rx_ring = kcalloc(adapter->num_rx_queues,
+                                   sizeof(struct e1000_rx_ring), GFP_KERNEL);
         if (!adapter->rx_ring) {
                 kfree(adapter->tx_ring);
                 return -ENOMEM;
         }
-        memset(adapter->rx_ring, 0, size);
 
 #ifdef CONFIG_E1000_NAPI
-        size = sizeof(struct net_device) * adapter->num_rx_queues;
-        adapter->polling_netdev = kmalloc(size, GFP_KERNEL);
+        adapter->polling_netdev = kcalloc(adapter->num_rx_queues,
+                                          sizeof(struct net_device),
+                                          GFP_KERNEL);
         if (!adapter->polling_netdev) {
                 kfree(adapter->tx_ring);
                 kfree(adapter->rx_ring);
                 return -ENOMEM;
         }
-        memset(adapter->polling_netdev, 0, size);
 #endif
 
         return E1000_SUCCESS;
@@ -1560,7 +1556,7 @@ e1000_setup_tx_resources(struct e1000_adapter *adapter,
         /* round up to nearest 4K */
 
         txdr->size = txdr->count * sizeof(struct e1000_tx_desc);
-        E1000_ROUNDUP(txdr->size, 4096);
+        txdr->size = ALIGN(txdr->size, 4096);
 
         txdr->desc = pci_alloc_consistent(pdev, txdr->size, &txdr->dma);
         if (!txdr->desc) {
@@ -1774,18 +1770,18 @@ e1000_setup_rx_resources(struct e1000_adapter *adapter,
         }
         memset(rxdr->buffer_info, 0, size);
 
-        size = sizeof(struct e1000_ps_page) * rxdr->count;
-        rxdr->ps_page = kmalloc(size, GFP_KERNEL);
+        rxdr->ps_page = kcalloc(rxdr->count, sizeof(struct e1000_ps_page),
+                                GFP_KERNEL);
         if (!rxdr->ps_page) {
                 vfree(rxdr->buffer_info);
                 DPRINTK(PROBE, ERR,
                 "Unable to allocate memory for the receive descriptor ring\n");
                 return -ENOMEM;
         }
-        memset(rxdr->ps_page, 0, size);
 
-        size = sizeof(struct e1000_ps_page_dma) * rxdr->count;
-        rxdr->ps_page_dma = kmalloc(size, GFP_KERNEL);
+        rxdr->ps_page_dma = kcalloc(rxdr->count,
+                                    sizeof(struct e1000_ps_page_dma),
+                                    GFP_KERNEL);
         if (!rxdr->ps_page_dma) {
                 vfree(rxdr->buffer_info);
                 kfree(rxdr->ps_page);
@@ -1793,7 +1789,6 @@ e1000_setup_rx_resources(struct e1000_adapter *adapter,
                 "Unable to allocate memory for the receive descriptor ring\n");
                 return -ENOMEM;
         }
-        memset(rxdr->ps_page_dma, 0, size);
 
         if (adapter->hw.mac_type <= e1000_82547_rev_2)
                 desc_len = sizeof(struct e1000_rx_desc);
@@ -1803,7 +1798,7 @@ e1000_setup_rx_resources(struct e1000_adapter *adapter,
         /* Round up to nearest 4K */
 
         rxdr->size = rxdr->count * desc_len;
-        E1000_ROUNDUP(rxdr->size, 4096);
+        rxdr->size = ALIGN(rxdr->size, 4096);
 
         rxdr->desc = pci_alloc_consistent(pdev, rxdr->size, &rxdr->dma);
 
@@ -2667,7 +2662,7 @@ e1000_watchdog(unsigned long data)
 
                         netif_carrier_on(netdev);
                         netif_wake_queue(netdev);
-                        mod_timer(&adapter->phy_info_timer, jiffies + 2 * HZ);
+                        mod_timer(&adapter->phy_info_timer, round_jiffies(jiffies + 2 * HZ));
                         adapter->smartspeed = 0;
                 } else {
                         /* make sure the receive unit is started */
@@ -2684,7 +2679,7 @@ e1000_watchdog(unsigned long data)
                         DPRINTK(LINK, INFO, "NIC Link is Down\n");
                         netif_carrier_off(netdev);
                         netif_stop_queue(netdev);
-                        mod_timer(&adapter->phy_info_timer, jiffies + 2 * HZ);
+                        mod_timer(&adapter->phy_info_timer, round_jiffies(jiffies + 2 * HZ));
 
                         /* 80003ES2LAN workaround--
                          * For packet buffer work-around on link down event;
@@ -2736,7 +2731,7 @@ e1000_watchdog(unsigned long data)
                 e1000_rar_set(&adapter->hw, adapter->hw.mac_addr, 0);
 
         /* Reset the timer */
-        mod_timer(&adapter->watchdog_timer, jiffies + 2 * HZ);
+        mod_timer(&adapter->watchdog_timer, round_jiffies(jiffies + 2 * HZ));
 }
 
 enum latency_range {
@@ -3175,7 +3170,7 @@ e1000_82547_fifo_workaround(struct e1000_adapter *adapter, struct sk_buff *skb)
         uint32_t fifo_space = adapter->tx_fifo_size - adapter->tx_fifo_head;
         uint32_t skb_fifo_len = skb->len + E1000_FIFO_HDR;
 
-        E1000_ROUNDUP(skb_fifo_len, E1000_FIFO_HDR);
+        skb_fifo_len = ALIGN(skb_fifo_len, E1000_FIFO_HDR);
 
         if (adapter->link_duplex != HALF_DUPLEX)
                 goto no_fifo_stall_required;
diff --git a/drivers/net/e1000/e1000_param.c b/drivers/net/e1000/e1000_param.c
index f8862e203ac9..f485874a63f5 100644
--- a/drivers/net/e1000/e1000_param.c
+++ b/drivers/net/e1000/e1000_param.c
@@ -305,7 +305,7 @@ e1000_check_options(struct e1000_adapter *adapter)
                 if (num_TxDescriptors > bd) {
                         tx_ring->count = TxDescriptors[bd];
                         e1000_validate_option(&tx_ring->count, &opt, adapter);
-                        E1000_ROUNDUP(tx_ring->count,
+                        tx_ring->count = ALIGN(tx_ring->count,
                                                 REQ_TX_DESCRIPTOR_MULTIPLE);
                 } else {
                         tx_ring->count = opt.def;
@@ -331,7 +331,7 @@ e1000_check_options(struct e1000_adapter *adapter)
                 if (num_RxDescriptors > bd) {
                         rx_ring->count = RxDescriptors[bd];
                         e1000_validate_option(&rx_ring->count, &opt, adapter);
-                        E1000_ROUNDUP(rx_ring->count,
+                        rx_ring->count = ALIGN(rx_ring->count,
                                                 REQ_RX_DESCRIPTOR_MULTIPLE);
                 } else {
                         rx_ring->count = opt.def;