diff options
author | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2009-06-16 20:24:53 -0400 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2009-06-16 20:24:53 -0400 |
commit | 492b057c426e4aa747484958e18e9da29003985d (patch) | |
tree | 34e08c24618688d8bcc190523028b5f94cce0c0b /drivers/net/de600.c | |
parent | 313485175da221c388f6a8ecf4c30062ba9bea17 (diff) | |
parent | 300df7dc89cc276377fc020704e34875d5c473b6 (diff) |
Merge commit 'origin/master' into next
Diffstat (limited to 'drivers/net/de600.c')
-rw-r--r-- | drivers/net/de600.c | 25 |
1 files changed, 6 insertions, 19 deletions
diff --git a/drivers/net/de600.c b/drivers/net/de600.c index de63f1d41d32..e1af089064bc 100644 --- a/drivers/net/de600.c +++ b/drivers/net/de600.c | |||
@@ -38,14 +38,6 @@ static const char version[] = "de600.c: $Revision: 1.41-2.5 $, Bjorn Ekwall (bj | |||
38 | /* Add more time here if your adapter won't work OK: */ | 38 | /* Add more time here if your adapter won't work OK: */ |
39 | #define DE600_SLOW_DOWN udelay(delay_time) | 39 | #define DE600_SLOW_DOWN udelay(delay_time) |
40 | 40 | ||
41 | /* use 0 for production, 1 for verification, >2 for debug */ | ||
42 | #ifdef DE600_DEBUG | ||
43 | #define PRINTK(x) if (de600_debug >= 2) printk x | ||
44 | #else | ||
45 | #define DE600_DEBUG 0 | ||
46 | #define PRINTK(x) /**/ | ||
47 | #endif | ||
48 | |||
49 | #include <linux/module.h> | 41 | #include <linux/module.h> |
50 | #include <linux/kernel.h> | 42 | #include <linux/kernel.h> |
51 | #include <linux/types.h> | 43 | #include <linux/types.h> |
@@ -67,10 +59,6 @@ static const char version[] = "de600.c: $Revision: 1.41-2.5 $, Bjorn Ekwall (bj | |||
67 | 59 | ||
68 | #include "de600.h" | 60 | #include "de600.h" |
69 | 61 | ||
70 | static unsigned int de600_debug = DE600_DEBUG; | ||
71 | module_param(de600_debug, int, 0); | ||
72 | MODULE_PARM_DESC(de600_debug, "DE-600 debug level (0-2)"); | ||
73 | |||
74 | static unsigned int check_lost = 1; | 62 | static unsigned int check_lost = 1; |
75 | module_param(check_lost, bool, 0); | 63 | module_param(check_lost, bool, 0); |
76 | MODULE_PARM_DESC(check_lost, "If set then check for unplugged de600"); | 64 | MODULE_PARM_DESC(check_lost, "If set then check for unplugged de600"); |
@@ -180,20 +168,20 @@ static int de600_start_xmit(struct sk_buff *skb, struct net_device *dev) | |||
180 | if (free_tx_pages <= 0) { /* Do timeouts, to avoid hangs. */ | 168 | if (free_tx_pages <= 0) { /* Do timeouts, to avoid hangs. */ |
181 | tickssofar = jiffies - dev->trans_start; | 169 | tickssofar = jiffies - dev->trans_start; |
182 | if (tickssofar < 5) | 170 | if (tickssofar < 5) |
183 | return 1; | 171 | return NETDEV_TX_BUSY; |
184 | /* else */ | 172 | /* else */ |
185 | printk(KERN_WARNING "%s: transmit timed out (%d), %s?\n", dev->name, tickssofar, "network cable problem"); | 173 | printk(KERN_WARNING "%s: transmit timed out (%d), %s?\n", dev->name, tickssofar, "network cable problem"); |
186 | /* Restart the adapter. */ | 174 | /* Restart the adapter. */ |
187 | spin_lock_irqsave(&de600_lock, flags); | 175 | spin_lock_irqsave(&de600_lock, flags); |
188 | if (adapter_init(dev)) { | 176 | if (adapter_init(dev)) { |
189 | spin_unlock_irqrestore(&de600_lock, flags); | 177 | spin_unlock_irqrestore(&de600_lock, flags); |
190 | return 1; | 178 | return NETDEV_TX_BUSY; |
191 | } | 179 | } |
192 | spin_unlock_irqrestore(&de600_lock, flags); | 180 | spin_unlock_irqrestore(&de600_lock, flags); |
193 | } | 181 | } |
194 | 182 | ||
195 | /* Start real output */ | 183 | /* Start real output */ |
196 | PRINTK(("de600_start_xmit:len=%d, page %d/%d\n", skb->len, tx_fifo_in, free_tx_pages)); | 184 | pr_debug("de600_start_xmit:len=%d, page %d/%d\n", skb->len, tx_fifo_in, free_tx_pages); |
197 | 185 | ||
198 | if ((len = skb->len) < RUNT) | 186 | if ((len = skb->len) < RUNT) |
199 | len = RUNT; | 187 | len = RUNT; |
@@ -211,7 +199,7 @@ static int de600_start_xmit(struct sk_buff *skb, struct net_device *dev) | |||
211 | if (was_down || (de600_read_byte(READ_DATA, dev) != 0xde)) { | 199 | if (was_down || (de600_read_byte(READ_DATA, dev) != 0xde)) { |
212 | if (adapter_init(dev)) { | 200 | if (adapter_init(dev)) { |
213 | spin_unlock_irqrestore(&de600_lock, flags); | 201 | spin_unlock_irqrestore(&de600_lock, flags); |
214 | return 1; | 202 | return NETDEV_TX_BUSY; |
215 | } | 203 | } |
216 | } | 204 | } |
217 | } | 205 | } |
@@ -259,7 +247,7 @@ static irqreturn_t de600_interrupt(int irq, void *dev_id) | |||
259 | irq_status = de600_read_status(dev); | 247 | irq_status = de600_read_status(dev); |
260 | 248 | ||
261 | do { | 249 | do { |
262 | PRINTK(("de600_interrupt (%02X)\n", irq_status)); | 250 | pr_debug("de600_interrupt (%02X)\n", irq_status); |
263 | 251 | ||
264 | if (irq_status & RX_GOOD) | 252 | if (irq_status & RX_GOOD) |
265 | de600_rx_intr(dev); | 253 | de600_rx_intr(dev); |
@@ -407,8 +395,7 @@ static struct net_device * __init de600_probe(void) | |||
407 | 395 | ||
408 | printk(KERN_INFO "%s: D-Link DE-600 pocket adapter", dev->name); | 396 | printk(KERN_INFO "%s: D-Link DE-600 pocket adapter", dev->name); |
409 | /* Alpha testers must have the version number to report bugs. */ | 397 | /* Alpha testers must have the version number to report bugs. */ |
410 | if (de600_debug > 1) | 398 | pr_debug("%s", version); |
411 | printk(version); | ||
412 | 399 | ||
413 | /* probe for adapter */ | 400 | /* probe for adapter */ |
414 | err = -ENODEV; | 401 | err = -ENODEV; |