net: cxgb4{,vf}: convert to hw_features

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Acked-by: Dimitris Michailidis <dm@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

3 files changed, 10 insertions, 57 deletions

diff --git a/drivers/net/cxgb4vf/adapter.h b/drivers/net/cxgb4vf/adapter.h
index 4766b4116b41..4fd821aadc8a 100644
--- a/drivers/net/cxgb4vf/adapter.h
+++ b/drivers/net/cxgb4vf/adapter.h
@@ -97,17 +97,11 @@ struct port_info {
         u16 rss_size;                   /* size of VI's RSS table slice */
         u8 pidx;                        /* index into adapter port[] */
         u8 port_id;                     /* physical port ID */
-        u8 rx_offload;                  /* CSO, etc. */
         u8 nqsets;                      /* # of "Queue Sets" */
         u8 first_qset;                  /* index of first "Queue Set" */
         struct link_config link_cfg;    /* physical port configuration */
 };
 
-/* port_info.rx_offload flags */
-enum {
-        RX_CSO = 1 << 0,
-};
-
 /*
  * Scatter Gather Engine resources for the "adapter".  Our ingress and egress
  * queues are organized into "Queue Sets" with one ingress and one egress
diff --git a/drivers/net/cxgb4vf/cxgb4vf_main.c b/drivers/net/cxgb4vf/cxgb4vf_main.c
index c662679de4fa..8cf9890cafaf 100644
--- a/drivers/net/cxgb4vf/cxgb4vf_main.c
+++ b/drivers/net/cxgb4vf/cxgb4vf_main.c
@@ -1326,30 +1326,6 @@ static void cxgb4vf_get_pauseparam(struct net_device *dev,
 }
 
 /*
- * Return whether RX Checksum Offloading is currently enabled for the device.
- */
-static u32 cxgb4vf_get_rx_csum(struct net_device *dev)
-{
-        struct port_info *pi = netdev_priv(dev);
-
-        return (pi->rx_offload & RX_CSO) != 0;
-}
-
-/*
- * Turn RX Checksum Offloading on or off for the device.
- */
-static int cxgb4vf_set_rx_csum(struct net_device *dev, u32 csum)
-{
-        struct port_info *pi = netdev_priv(dev);
-
-        if (csum)
-                pi->rx_offload |= RX_CSO;
-        else
-                pi->rx_offload &= ~RX_CSO;
-        return 0;
-}
-
-/*
  * Identify the port by blinking the port's LED.
  */
 static int cxgb4vf_phys_id(struct net_device *dev,
@@ -1569,18 +1545,6 @@ static void cxgb4vf_get_wol(struct net_device *dev,
  */
 #define TSO_FLAGS (NETIF_F_TSO | NETIF_F_TSO6 | NETIF_F_TSO_ECN)
 
-/*
- * Set TCP Segmentation Offloading feature capabilities.
- */
-static int cxgb4vf_set_tso(struct net_device *dev, u32 tso)
-{
-        if (tso)
-                dev->features |= TSO_FLAGS;
-        else
-                dev->features &= ~TSO_FLAGS;
-        return 0;
-}
-
 static struct ethtool_ops cxgb4vf_ethtool_ops = {
         .get_settings           = cxgb4vf_get_settings,
         .get_drvinfo            = cxgb4vf_get_drvinfo,
@@ -1591,10 +1555,6 @@ static struct ethtool_ops cxgb4vf_ethtool_ops = {
         .get_coalesce           = cxgb4vf_get_coalesce,
         .set_coalesce           = cxgb4vf_set_coalesce,
         .get_pauseparam         = cxgb4vf_get_pauseparam,
-        .get_rx_csum            = cxgb4vf_get_rx_csum,
-        .set_rx_csum            = cxgb4vf_set_rx_csum,
-        .set_tx_csum            = ethtool_op_set_tx_ipv6_csum,
-        .set_sg                 = ethtool_op_set_sg,
         .get_link               = ethtool_op_get_link,
         .get_strings            = cxgb4vf_get_strings,
         .set_phys_id            = cxgb4vf_phys_id,
@@ -1603,7 +1563,6 @@ static struct ethtool_ops cxgb4vf_ethtool_ops = {
         .get_regs_len           = cxgb4vf_get_regs_len,
         .get_regs               = cxgb4vf_get_regs,
         .get_wol                = cxgb4vf_get_wol,
-        .set_tso                = cxgb4vf_set_tso,
 };
 
 /*
@@ -2638,19 +2597,19 @@ static int __devinit cxgb4vf_pci_probe(struct pci_dev *pdev,
                  * it.
                  */
                 pi->xact_addr_filt = -1;
-                pi->rx_offload = RX_CSO;
                 netif_carrier_off(netdev);
                 netdev->irq = pdev->irq;
 
-                netdev->features = (NETIF_F_SG | TSO_FLAGS |
-                                    NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
-                                    NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX |
-                                    NETIF_F_GRO);
+                netdev->hw_features = NETIF_F_SG | TSO_FLAGS |
+                        NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
+                        NETIF_F_HW_VLAN_TX | NETIF_F_RXCSUM;
+                netdev->vlan_features = NETIF_F_SG | TSO_FLAGS |
+                        NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
+                        NETIF_F_HIGHDMA;
+                netdev->features = netdev->hw_features |
+                        NETIF_F_HW_VLAN_RX;
                 if (pci_using_dac)
                         netdev->features |= NETIF_F_HIGHDMA;
-                netdev->vlan_features =
-                        (netdev->features &
-                         ~(NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX));
 
 #ifdef HAVE_NET_DEVICE_OPS
                 netdev->netdev_ops = &cxgb4vf_netdev_ops;
diff --git a/drivers/net/cxgb4vf/sge.c b/drivers/net/cxgb4vf/sge.c
index bb65121f581c..5182960e29fd 100644
--- a/drivers/net/cxgb4vf/sge.c
+++ b/drivers/net/cxgb4vf/sge.c
@@ -1555,8 +1555,8 @@ int t4vf_ethrx_handler(struct sge_rspq *rspq, const __be64 *rsp,
         pi = netdev_priv(skb->dev);
         rxq->stats.pkts++;
 
-        if (csum_ok && (pi->rx_offload & RX_CSO) && !pkt->err_vec &&
-            (be32_to_cpu(pkt->l2info) & (RXF_UDP|RXF_TCP))) {
+        if (csum_ok && (rspq->netdev->features & NETIF_F_RXCSUM) &&
+            !pkt->err_vec && (be32_to_cpu(pkt->l2info) & (RXF_UDP|RXF_TCP))) {
                 if (!pkt->ip_frag)
                         skb->ip_summed = CHECKSUM_UNNECESSARY;
                 else {