diff options
author | Jeff Garzik <jeff@garzik.org> | 2007-09-15 17:41:06 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-10-10 19:51:17 -0400 |
commit | 88d3aafdae5c5e1d2dd9489a5c8a24e29d335f2e (patch) | |
tree | 272ce75c30a170420ac8bbfd679c3faed9f9d20a /drivers/net/cxgb3 | |
parent | 09f75cd7bf13720738e6a196cc0107ce9a5bd5a0 (diff) |
[ETHTOOL] Provide default behaviors for a few ethtool sub-ioctls
For the operations
get-tx-csum
get-sg
get-tso
get-ufo
the default ethtool_op_xxx behavior is fine for all drivers, so we
permit op==NULL to imply the default behavior.
This provides a more uniform behavior across all drivers, eliminating
ethtool(8) "ioctl not supported" errors on older drivers that had
not been updated for the latest sub-ioctls.
The ethtool_op_xxx() functions are left exported, in case anyone
wishes to call them directly from a driver-private implementation --
a not-uncommon case. Should an ethtool_op_xxx() helper remain unused
for a while, except by net/core/ethtool.c, we can un-export it at a
later date.
[ Resolved conflicts with set/get value ethtool patch... -DaveM ]
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/cxgb3')
-rw-r--r-- | drivers/net/cxgb3/cxgb3_main.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c index 19937498589d..04633ea55202 100644 --- a/drivers/net/cxgb3/cxgb3_main.c +++ b/drivers/net/cxgb3/cxgb3_main.c | |||
@@ -1634,9 +1634,7 @@ static const struct ethtool_ops cxgb_ethtool_ops = { | |||
1634 | .set_pauseparam = set_pauseparam, | 1634 | .set_pauseparam = set_pauseparam, |
1635 | .get_rx_csum = get_rx_csum, | 1635 | .get_rx_csum = get_rx_csum, |
1636 | .set_rx_csum = set_rx_csum, | 1636 | .set_rx_csum = set_rx_csum, |
1637 | .get_tx_csum = ethtool_op_get_tx_csum, | ||
1638 | .set_tx_csum = ethtool_op_set_tx_csum, | 1637 | .set_tx_csum = ethtool_op_set_tx_csum, |
1639 | .get_sg = ethtool_op_get_sg, | ||
1640 | .set_sg = ethtool_op_set_sg, | 1638 | .set_sg = ethtool_op_set_sg, |
1641 | .get_link = ethtool_op_get_link, | 1639 | .get_link = ethtool_op_get_link, |
1642 | .get_strings = get_strings, | 1640 | .get_strings = get_strings, |
@@ -1647,7 +1645,6 @@ static const struct ethtool_ops cxgb_ethtool_ops = { | |||
1647 | .get_regs_len = get_regs_len, | 1645 | .get_regs_len = get_regs_len, |
1648 | .get_regs = get_regs, | 1646 | .get_regs = get_regs, |
1649 | .get_wol = get_wol, | 1647 | .get_wol = get_wol, |
1650 | .get_tso = ethtool_op_get_tso, | ||
1651 | .set_tso = ethtool_op_set_tso, | 1648 | .set_tso = ethtool_op_set_tso, |
1652 | }; | 1649 | }; |
1653 | 1650 | ||