cxgb3: Use generic MDIO definitions and mdio_mii_ioctl()

Compile-tested only.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 40 insertions, 30 deletions

diff --git a/drivers/net/cxgb3/vsc8211.c b/drivers/net/cxgb3/vsc8211.c
index d07130971b8f..4f9a1c2724f4 100644
--- a/drivers/net/cxgb3/vsc8211.c
+++ b/drivers/net/cxgb3/vsc8211.c
@@ -91,17 +91,18 @@ enum {
  */
 static int vsc8211_reset(struct cphy *cphy, int wait)
 {
-        return t3_phy_reset(cphy, 0, 0);
+        return t3_phy_reset(cphy, MDIO_DEVAD_NONE, 0);
 }
 
 static int vsc8211_intr_enable(struct cphy *cphy)
 {
-        return mdio_write(cphy, 0, VSC8211_INTR_ENABLE, INTR_MASK);
+        return t3_mdio_write(cphy, MDIO_DEVAD_NONE, VSC8211_INTR_ENABLE,
+                             INTR_MASK);
 }
 
 static int vsc8211_intr_disable(struct cphy *cphy)
 {
-        return mdio_write(cphy, 0, VSC8211_INTR_ENABLE, 0);
+        return t3_mdio_write(cphy, MDIO_DEVAD_NONE, VSC8211_INTR_ENABLE, 0);
 }
 
 static int vsc8211_intr_clear(struct cphy *cphy)
@@ -109,18 +110,20 @@ static int vsc8211_intr_clear(struct cphy *cphy)
         u32 val;
 
         /* Clear PHY interrupts by reading the register. */
-        return mdio_read(cphy, 0, VSC8211_INTR_STATUS, &val);
+        return t3_mdio_read(cphy, MDIO_DEVAD_NONE, VSC8211_INTR_STATUS, &val);
 }
 
 static int vsc8211_autoneg_enable(struct cphy *cphy)
 {
-        return t3_mdio_change_bits(cphy, 0, MII_BMCR, BMCR_PDOWN | BMCR_ISOLATE,
+        return t3_mdio_change_bits(cphy, MDIO_DEVAD_NONE, MII_BMCR,
+                                   BMCR_PDOWN | BMCR_ISOLATE,
                                    BMCR_ANENABLE | BMCR_ANRESTART);
 }
 
 static int vsc8211_autoneg_restart(struct cphy *cphy)
 {
-        return t3_mdio_change_bits(cphy, 0, MII_BMCR, BMCR_PDOWN | BMCR_ISOLATE,
+        return t3_mdio_change_bits(cphy, MDIO_DEVAD_NONE, MII_BMCR,
+                                   BMCR_PDOWN | BMCR_ISOLATE,
                                    BMCR_ANRESTART);
 }
 
@@ -130,9 +133,9 @@ static int vsc8211_get_link_status(struct cphy *cphy, int *link_ok,
         unsigned int bmcr, status, lpa, adv;
         int err, sp = -1, dplx = -1, pause = 0;
 
-        err = mdio_read(cphy, 0, MII_BMCR, &bmcr);
+        err = t3_mdio_read(cphy, MDIO_DEVAD_NONE, MII_BMCR, &bmcr);
         if (!err)
-                err = mdio_read(cphy, 0, MII_BMSR, &status);
+                err = t3_mdio_read(cphy, MDIO_DEVAD_NONE, MII_BMSR, &status);
         if (err)
                 return err;
 
@@ -142,7 +145,8 @@ static int vsc8211_get_link_status(struct cphy *cphy, int *link_ok,
                  * once more to get the current link state.
                  */
                 if (!(status & BMSR_LSTATUS))
-                        err = mdio_read(cphy, 0, MII_BMSR, &status);
+                        err = t3_mdio_read(cphy, MDIO_DEVAD_NONE, MII_BMSR,
+                                           &status);
                 if (err)
                         return err;
                 *link_ok = (status & BMSR_LSTATUS) != 0;
@@ -156,7 +160,8 @@ static int vsc8211_get_link_status(struct cphy *cphy, int *link_ok,
                 else
                         sp = SPEED_10;
         } else if (status & BMSR_ANEGCOMPLETE) {
-                err = mdio_read(cphy, 0, VSC8211_AUX_CTRL_STAT, &status);
+                err = t3_mdio_read(cphy, MDIO_DEVAD_NONE, VSC8211_AUX_CTRL_STAT,
+                                   &status);
                 if (err)
                         return err;
 
@@ -170,9 +175,11 @@ static int vsc8211_get_link_status(struct cphy *cphy, int *link_ok,
                         sp = SPEED_1000;
 
                 if (fc && dplx == DUPLEX_FULL) {
-                        err = mdio_read(cphy, 0, MII_LPA, &lpa);
+                        err = t3_mdio_read(cphy, MDIO_DEVAD_NONE, MII_LPA,
+                                           &lpa);
                         if (!err)
-                                err = mdio_read(cphy, 0, MII_ADVERTISE, &adv);
+                                err = t3_mdio_read(cphy, MDIO_DEVAD_NONE,
+                                                   MII_ADVERTISE, &adv);
                         if (err)
                                 return err;
 
@@ -202,9 +209,9 @@ static int vsc8211_get_link_status_fiber(struct cphy *cphy, int *link_ok,
         unsigned int bmcr, status, lpa, adv;
         int err, sp = -1, dplx = -1, pause = 0;
 
-        err = mdio_read(cphy, 0, MII_BMCR, &bmcr);
+        err = t3_mdio_read(cphy, MDIO_DEVAD_NONE, MII_BMCR, &bmcr);
         if (!err)
-                err = mdio_read(cphy, 0, MII_BMSR, &status);
+                err = t3_mdio_read(cphy, MDIO_DEVAD_NONE, MII_BMSR, &status);
         if (err)
                 return err;
 
@@ -214,7 +221,8 @@ static int vsc8211_get_link_status_fiber(struct cphy *cphy, int *link_ok,
                  * once more to get the current link state.
                  */
                 if (!(status & BMSR_LSTATUS))
-                        err = mdio_read(cphy, 0, MII_BMSR, &status);
+                        err = t3_mdio_read(cphy, MDIO_DEVAD_NONE, MII_BMSR,
+                                           &status);
                 if (err)
                         return err;
                 *link_ok = (status & BMSR_LSTATUS) != 0;
@@ -228,9 +236,10 @@ static int vsc8211_get_link_status_fiber(struct cphy *cphy, int *link_ok,
                 else
                         sp = SPEED_10;
         } else if (status & BMSR_ANEGCOMPLETE) {
-                err = mdio_read(cphy, 0, MII_LPA, &lpa);
+                err = t3_mdio_read(cphy, MDIO_DEVAD_NONE, MII_LPA, &lpa);
                 if (!err)
-                        err = mdio_read(cphy, 0, MII_ADVERTISE, &adv);
+                        err = t3_mdio_read(cphy, MDIO_DEVAD_NONE, MII_ADVERTISE,
+                                           &adv);
                 if (err)
                         return err;
 
@@ -270,23 +279,23 @@ static int vsc8211_set_automdi(struct cphy *phy, int enable)
 {
         int err;
 
-        err = mdio_write(phy, 0, VSC8211_EXT_PAGE_AXS, 0x52b5);
+        err = t3_mdio_write(phy, MDIO_DEVAD_NONE, VSC8211_EXT_PAGE_AXS, 0x52b5);
         if (err)
                 return err;
 
-        err = mdio_write(phy, 0, 18, 0x12);
+        err = t3_mdio_write(phy, MDIO_DEVAD_NONE, 18, 0x12);
         if (err)
                 return err;
 
-        err = mdio_write(phy, 0, 17, enable ? 0x2803 : 0x3003);
+        err = t3_mdio_write(phy, MDIO_DEVAD_NONE, 17, enable ? 0x2803 : 0x3003);
         if (err)
                 return err;
 
-        err = mdio_write(phy, 0, 16, 0x87fa);
+        err = t3_mdio_write(phy, MDIO_DEVAD_NONE, 16, 0x87fa);
         if (err)
                 return err;
 
-        err = mdio_write(phy, 0, VSC8211_EXT_PAGE_AXS, 0);
+        err = t3_mdio_write(phy, MDIO_DEVAD_NONE, VSC8211_EXT_PAGE_AXS, 0);
         if (err)
                 return err;
 
@@ -315,7 +324,7 @@ static int vsc8211_intr_handler(struct cphy *cphy)
         unsigned int cause;
         int err, cphy_cause = 0;
 
-        err = mdio_read(cphy, 0, VSC8211_INTR_STATUS, &cause);
+        err = t3_mdio_read(cphy, MDIO_DEVAD_NONE, VSC8211_INTR_STATUS, &cause);
         if (err)
                 return err;
 
@@ -367,12 +376,13 @@ int t3_vsc8211_phy_prep(struct cphy *phy, struct adapter *adapter,
                   SUPPORTED_TP | SUPPORTED_IRQ, "10/100/1000BASE-T");
         msleep(20);       /* PHY needs ~10ms to start responding to MDIO */
 
-        err = mdio_read(phy, 0, VSC8211_EXT_CTRL, &val);
+        err = t3_mdio_read(phy, MDIO_DEVAD_NONE, VSC8211_EXT_CTRL, &val);
         if (err)
                 return err;
         if (val & VSC_CTRL_MEDIA_MODE_HI) {
                 /* copper interface, just need to configure the LEDs */
-                return mdio_write(phy, 0, VSC8211_LED_CTRL, 0x100);
+                return t3_mdio_write(phy, MDIO_DEVAD_NONE, VSC8211_LED_CTRL,
+                                     0x100);
         }
 
         phy->caps = SUPPORTED_1000baseT_Full | SUPPORTED_Autoneg |
@@ -380,20 +390,20 @@ int t3_vsc8211_phy_prep(struct cphy *phy, struct adapter *adapter,
         phy->desc = "1000BASE-X";
         phy->ops = &vsc8211_fiber_ops;
 
-        err = mdio_write(phy, 0, VSC8211_EXT_PAGE_AXS, 1);
+        err = t3_mdio_write(phy, MDIO_DEVAD_NONE, VSC8211_EXT_PAGE_AXS, 1);
         if (err)
                 return err;
 
-        err = mdio_write(phy, 0, VSC8211_SIGDET_CTRL, 1);
+        err = t3_mdio_write(phy, MDIO_DEVAD_NONE, VSC8211_SIGDET_CTRL, 1);
         if (err)
                 return err;
 
-        err = mdio_write(phy, 0, VSC8211_EXT_PAGE_AXS, 0);
+        err = t3_mdio_write(phy, MDIO_DEVAD_NONE, VSC8211_EXT_PAGE_AXS, 0);
         if (err)
                 return err;
 
-        err = mdio_write(phy, 0, VSC8211_EXT_CTRL,
-                         val | VSC_CTRL_CLAUSE37_VIEW);
+        err = t3_mdio_write(phy, MDIO_DEVAD_NONE, VSC8211_EXT_CTRL,
+                            val | VSC_CTRL_CLAUSE37_VIEW);
         if (err)
                 return err;