diff options
author | Randy Dunlap <randy.dunlap@oracle.com> | 2007-07-09 14:55:54 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2007-07-11 19:02:11 -0400 |
commit | 694625c0b322905d6892fad873029f764cd4823f (patch) | |
tree | c48ac2c0095f2ac4044bd12b27ea318eb6156c73 /drivers/net/cassini.c | |
parent | f5609d7e679db3f29433f56e1f2e397a2f815288 (diff) |
PCI: add pci_try_set_mwi
As suggested by Andrew, add pci_try_set_mwi(), which does not require
return-value checking.
- add pci_try_set_mwi() without __must_check
- make it return 0 on success, errno if the "try" failed or error
- review callers
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/net/cassini.c')
-rw-r--r-- | drivers/net/cassini.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/cassini.c b/drivers/net/cassini.c index 805924fc077a..f6e4030c73d1 100644 --- a/drivers/net/cassini.c +++ b/drivers/net/cassini.c | |||
@@ -4917,13 +4917,13 @@ static int __devinit cas_init_one(struct pci_dev *pdev, | |||
4917 | pci_cmd &= ~PCI_COMMAND_SERR; | 4917 | pci_cmd &= ~PCI_COMMAND_SERR; |
4918 | pci_cmd |= PCI_COMMAND_PARITY; | 4918 | pci_cmd |= PCI_COMMAND_PARITY; |
4919 | pci_write_config_word(pdev, PCI_COMMAND, pci_cmd); | 4919 | pci_write_config_word(pdev, PCI_COMMAND, pci_cmd); |
4920 | if (pci_set_mwi(pdev)) | 4920 | if (pci_try_set_mwi(pdev)) |
4921 | printk(KERN_WARNING PFX "Could not enable MWI for %s\n", | 4921 | printk(KERN_WARNING PFX "Could not enable MWI for %s\n", |
4922 | pci_name(pdev)); | 4922 | pci_name(pdev)); |
4923 | 4923 | ||
4924 | /* | 4924 | /* |
4925 | * On some architectures, the default cache line size set | 4925 | * On some architectures, the default cache line size set |
4926 | * by pci_set_mwi reduces perforamnce. We have to increase | 4926 | * by pci_try_set_mwi reduces perforamnce. We have to increase |
4927 | * it for this case. To start, we'll print some configuration | 4927 | * it for this case. To start, we'll print some configuration |
4928 | * data. | 4928 | * data. |
4929 | */ | 4929 | */ |