can: Unify droping of invalid tx skbs and netdev stats

To prevent the CAN drivers to operate on invalid socketbuffers the skbs are
now checked and silently dropped at the xmit-function consistently.

Also the netdev stats are consistently using the CAN data length code (dlc)
for [rx|tx]_bytes now.

Signed-off-by: Oliver Hartkopp <oliver@hartkopp.net>
Acked-by: Wolfgang Grandegger <wg@grandegger.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 1 insertions, 5 deletions

diff --git a/drivers/net/can/mcp251x.c b/drivers/net/can/mcp251x.c
index 1a72ca066a17..afa2fa45fed9 100644
--- a/drivers/net/can/mcp251x.c
+++ b/drivers/net/can/mcp251x.c
@@ -494,12 +494,8 @@ static netdev_tx_t mcp251x_hard_start_xmit(struct sk_buff *skb,
                 return NETDEV_TX_BUSY;
         }
 
-        if (skb->len != sizeof(struct can_frame)) {
-                dev_err(&spi->dev, "dropping packet - bad length\n");
-                dev_kfree_skb(skb);
-                net->stats.tx_dropped++;
+        if (can_dropped_invalid_skb(net, skb))
                 return NETDEV_TX_OK;
-        }
 
         netif_stop_queue(net);
         priv->tx_skb = skb;