virtio: use size-based config accessors.

This lets the transport do endian conversion if necessary, and insulates
the drivers from the difference.

Most drivers can use the simple helpers virtio_cread() and virtio_cwrite().

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

1 files changed, 12 insertions, 11 deletions

diff --git a/drivers/net/caif/caif_virtio.c b/drivers/net/caif/caif_virtio.c
index b9ed1288ce2d..985608634f8c 100644
--- a/drivers/net/caif/caif_virtio.c
+++ b/drivers/net/caif/caif_virtio.c
@@ -686,18 +686,19 @@ static int cfv_probe(struct virtio_device *vdev)
                 goto err;
 
         /* Get the CAIF configuration from virtio config space, if available */
-#define GET_VIRTIO_CONFIG_OPS(_v, _var, _f) \
-        ((_v)->config->get(_v, offsetof(struct virtio_caif_transf_config, _f), \
-                           &_var, \
-                           FIELD_SIZEOF(struct virtio_caif_transf_config, _f)))
-
         if (vdev->config->get) {
-                GET_VIRTIO_CONFIG_OPS(vdev, cfv->tx_hr, headroom);
-                GET_VIRTIO_CONFIG_OPS(vdev, cfv->rx_hr, headroom);
-                GET_VIRTIO_CONFIG_OPS(vdev, cfv->tx_tr, tailroom);
-                GET_VIRTIO_CONFIG_OPS(vdev, cfv->rx_tr, tailroom);
-                GET_VIRTIO_CONFIG_OPS(vdev, cfv->mtu, mtu);
-                GET_VIRTIO_CONFIG_OPS(vdev, cfv->mru, mtu);
+                virtio_cread(vdev, struct virtio_caif_transf_config, headroom,
+                             &cfv->tx_hr);
+                virtio_cread(vdev, struct virtio_caif_transf_config, headroom,
+                             &cfv->rx_hr);
+                virtio_cread(vdev, struct virtio_caif_transf_config, tailroom,
+                             &cfv->tx_tr);
+                virtio_cread(vdev, struct virtio_caif_transf_config, tailroom,
+                             &cfv->rx_tr);
+                virtio_cread(vdev, struct virtio_caif_transf_config, mtu,
+                             &cfv->mtu);
+                virtio_cread(vdev, struct virtio_caif_transf_config, mtu,
+                             &cfv->mru);
         } else {
                 cfv->tx_hr = CFV_DEF_HEADROOM;
                 cfv->rx_hr = CFV_DEF_HEADROOM;