diff options
author | Joe Perches <joe@perches.com> | 2009-12-03 02:58:21 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-12-03 16:18:01 -0500 |
commit | 8e95a2026f3b43f7c3d676adaccd2de9532e8dcc (patch) | |
tree | 3733318168cd512480b6db58c5c16d1c8847f0b7 /drivers/net/bonding | |
parent | 3454f835837609d60b29a266e3bd9d701073b060 (diff) |
drivers/net: Move && and || to end of previous line
Only files where David Miller is the primary git-signer.
wireless, wimax, ixgbe, etc are not modified.
Compile tested x86 allyesconfig only
Not all files compiled (not x86 compatible)
Added a few > 80 column lines, which I ignored.
Existing checkpatch complaints ignored.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bonding')
-rw-r--r-- | drivers/net/bonding/bond_3ad.c | 24 | ||||
-rw-r--r-- | drivers/net/bonding/bond_main.c | 4 | ||||
-rw-r--r-- | drivers/net/bonding/bonding.h | 4 |
3 files changed, 16 insertions, 16 deletions
diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c index 88c3fe80b355..d69e6838f21e 100644 --- a/drivers/net/bonding/bond_3ad.c +++ b/drivers/net/bonding/bond_3ad.c | |||
@@ -561,12 +561,12 @@ static void __update_selected(struct lacpdu *lacpdu, struct port *port) | |||
561 | const struct port_params *partner = &port->partner_oper; | 561 | const struct port_params *partner = &port->partner_oper; |
562 | 562 | ||
563 | // check if any parameter is different | 563 | // check if any parameter is different |
564 | if (ntohs(lacpdu->actor_port) != partner->port_number | 564 | if (ntohs(lacpdu->actor_port) != partner->port_number || |
565 | || ntohs(lacpdu->actor_port_priority) != partner->port_priority | 565 | ntohs(lacpdu->actor_port_priority) != partner->port_priority || |
566 | || MAC_ADDRESS_COMPARE(&lacpdu->actor_system, &partner->system) | 566 | MAC_ADDRESS_COMPARE(&lacpdu->actor_system, &partner->system) || |
567 | || ntohs(lacpdu->actor_system_priority) != partner->system_priority | 567 | ntohs(lacpdu->actor_system_priority) != partner->system_priority || |
568 | || ntohs(lacpdu->actor_key) != partner->key | 568 | ntohs(lacpdu->actor_key) != partner->key || |
569 | || (lacpdu->actor_state & AD_STATE_AGGREGATION) != (partner->port_state & AD_STATE_AGGREGATION)) { | 569 | (lacpdu->actor_state & AD_STATE_AGGREGATION) != (partner->port_state & AD_STATE_AGGREGATION)) { |
570 | // update the state machine Selected variable | 570 | // update the state machine Selected variable |
571 | port->sm_vars &= ~AD_PORT_SELECTED; | 571 | port->sm_vars &= ~AD_PORT_SELECTED; |
572 | } | 572 | } |
@@ -592,12 +592,12 @@ static void __update_default_selected(struct port *port) | |||
592 | const struct port_params *oper = &port->partner_oper; | 592 | const struct port_params *oper = &port->partner_oper; |
593 | 593 | ||
594 | // check if any parameter is different | 594 | // check if any parameter is different |
595 | if (admin->port_number != oper->port_number | 595 | if (admin->port_number != oper->port_number || |
596 | || admin->port_priority != oper->port_priority | 596 | admin->port_priority != oper->port_priority || |
597 | || MAC_ADDRESS_COMPARE(&admin->system, &oper->system) | 597 | MAC_ADDRESS_COMPARE(&admin->system, &oper->system) || |
598 | || admin->system_priority != oper->system_priority | 598 | admin->system_priority != oper->system_priority || |
599 | || admin->key != oper->key | 599 | admin->key != oper->key || |
600 | || (admin->port_state & AD_STATE_AGGREGATION) | 600 | (admin->port_state & AD_STATE_AGGREGATION) |
601 | != (oper->port_state & AD_STATE_AGGREGATION)) { | 601 | != (oper->port_state & AD_STATE_AGGREGATION)) { |
602 | // update the state machine Selected variable | 602 | // update the state machine Selected variable |
603 | port->sm_vars &= ~AD_PORT_SELECTED; | 603 | port->sm_vars &= ~AD_PORT_SELECTED; |
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index ac3fe20abf8f..af9b9c4eb496 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c | |||
@@ -1852,8 +1852,8 @@ int bond_release(struct net_device *bond_dev, struct net_device *slave_dev) | |||
1852 | } | 1852 | } |
1853 | 1853 | ||
1854 | if (!bond->params.fail_over_mac) { | 1854 | if (!bond->params.fail_over_mac) { |
1855 | if (!compare_ether_addr(bond_dev->dev_addr, slave->perm_hwaddr) | 1855 | if (!compare_ether_addr(bond_dev->dev_addr, slave->perm_hwaddr) && |
1856 | && bond->slave_cnt > 1) | 1856 | bond->slave_cnt > 1) |
1857 | pr_warning(DRV_NAME | 1857 | pr_warning(DRV_NAME |
1858 | ": %s: Warning: the permanent HWaddr of %s - " | 1858 | ": %s: Warning: the permanent HWaddr of %s - " |
1859 | "%pM - is still in use by %s. " | 1859 | "%pM - is still in use by %s. " |
diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h index a51ae7dc8d51..558ec1352527 100644 --- a/drivers/net/bonding/bonding.h +++ b/drivers/net/bonding/bonding.h | |||
@@ -254,8 +254,8 @@ static inline struct bonding *bond_get_bond_by_slave(struct slave *slave) | |||
254 | 254 | ||
255 | static inline bool bond_is_lb(const struct bonding *bond) | 255 | static inline bool bond_is_lb(const struct bonding *bond) |
256 | { | 256 | { |
257 | return bond->params.mode == BOND_MODE_TLB | 257 | return (bond->params.mode == BOND_MODE_TLB || |
258 | || bond->params.mode == BOND_MODE_ALB; | 258 | bond->params.mode == BOND_MODE_ALB); |
259 | } | 259 | } |
260 | 260 | ||
261 | #define BOND_PRI_RESELECT_ALWAYS 0 | 261 | #define BOND_PRI_RESELECT_ALWAYS 0 |