diff options
author | Jiri Bohac <jbohac@suse.cz> | 2011-06-10 06:27:20 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-06-11 19:13:29 -0400 |
commit | 830a9c75514b477994fd3847f72654d3dbdfa5ca (patch) | |
tree | 945e3a5187560332c4acbfd6cefee93b19a97d21 /drivers/net/bonding | |
parent | 539d3ee6376eba05ebd947c81d097e31a3ee42a8 (diff) |
bonding: clean up bond_del_vlan()
1) the setting of NETIF_F_VLAN_CHALLENGED in bond_del_vlan() is
useless since commit b2a103e6 because bond_fix_features() now
sets NETIF_F_VLAN_CHALLENGED whenever the last slave is being
removed.
2) the code never triggers anyway as vlan_list is never empty
since ad1afb00.
Signed-off-by: Jiri Bohac <jbohac@suse.cz>
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bonding')
-rw-r--r-- | drivers/net/bonding/bond_main.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index bb1af9c1629f..07e866d5a87c 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c | |||
@@ -329,16 +329,6 @@ static int bond_del_vlan(struct bonding *bond, unsigned short vlan_id) | |||
329 | 329 | ||
330 | kfree(vlan); | 330 | kfree(vlan); |
331 | 331 | ||
332 | if (list_empty(&bond->vlan_list) && | ||
333 | (bond->slave_cnt == 0)) { | ||
334 | /* Last VLAN removed and no slaves, so | ||
335 | * restore block on adding VLANs. This will | ||
336 | * be removed once new slaves that are not | ||
337 | * VLAN challenged will be added. | ||
338 | */ | ||
339 | bond->dev->features |= NETIF_F_VLAN_CHALLENGED; | ||
340 | } | ||
341 | |||
342 | res = 0; | 332 | res = 0; |
343 | goto out; | 333 | goto out; |
344 | } | 334 | } |