aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/bonding/bond_sysfs.c
diff options
context:
space:
mode:
authorJiri Pirko <jpirko@redhat.com>2009-08-13 00:11:52 -0400
committerDavid S. Miller <davem@davemloft.net>2009-08-13 19:43:32 -0400
commite5e2a8fd8358d1b3a2c51c3248edee72e4194703 (patch)
tree5fcbbd0d82b370446dd2745296caa37b374ecf03 /drivers/net/bonding/bond_sysfs.c
parent26ced1e4aa181c01379b0b7ef156a29c000d1f8c (diff)
bonding: wipe out printk's
I did not introduce new lines over 80 chars. I even eliminated some of them. Signed-off-by: Jiri Pirko <jpirko@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bonding/bond_sysfs.c')
-rw-r--r--drivers/net/bonding/bond_sysfs.c63
1 files changed, 33 insertions, 30 deletions
diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c
index 55bf34f59bbf..6044e12ff9fc 100644
--- a/drivers/net/bonding/bond_sysfs.c
+++ b/drivers/net/bonding/bond_sysfs.c
@@ -218,9 +218,8 @@ static ssize_t bonding_store_slaves(struct device *d,
218 218
219 /* Quick sanity check -- is the bond interface up? */ 219 /* Quick sanity check -- is the bond interface up? */
220 if (!(bond->dev->flags & IFF_UP)) { 220 if (!(bond->dev->flags & IFF_UP)) {
221 printk(KERN_WARNING DRV_NAME 221 pr_warning(DRV_NAME ": %s: doing slave updates when "
222 ": %s: doing slave updates when interface is down.\n", 222 "interface is down.\n", bond->dev->name);
223 bond->dev->name);
224 } 223 }
225 224
226 /* Note: We can't hold bond->lock here, as bond_create grabs it. */ 225 /* Note: We can't hold bond->lock here, as bond_create grabs it. */
@@ -778,12 +777,14 @@ static ssize_t bonding_store_downdelay(struct device *d,
778 goto out; 777 goto out;
779 } else { 778 } else {
780 if ((new_value % bond->params.miimon) != 0) { 779 if ((new_value % bond->params.miimon) != 0) {
781 printk(KERN_WARNING DRV_NAME 780 pr_warning(DRV_NAME
782 ": %s: Warning: down delay (%d) is not a multiple " 781 ": %s: Warning: down delay (%d) is not a "
783 "of miimon (%d), delay rounded to %d ms\n", 782 "multiple of miimon (%d), delay rounded "
784 bond->dev->name, new_value, bond->params.miimon, 783 "to %d ms\n",
785 (new_value / bond->params.miimon) * 784 bond->dev->name, new_value,
786 bond->params.miimon); 785 bond->params.miimon,
786 (new_value / bond->params.miimon) *
787 bond->params.miimon);
787 } 788 }
788 bond->params.downdelay = new_value / bond->params.miimon; 789 bond->params.downdelay = new_value / bond->params.miimon;
789 pr_info(DRV_NAME ": %s: Setting down delay to %d.\n", 790 pr_info(DRV_NAME ": %s: Setting down delay to %d.\n",
@@ -838,12 +839,14 @@ static ssize_t bonding_store_updelay(struct device *d,
838 goto out; 839 goto out;
839 } else { 840 } else {
840 if ((new_value % bond->params.miimon) != 0) { 841 if ((new_value % bond->params.miimon) != 0) {
841 printk(KERN_WARNING DRV_NAME 842 pr_warning(DRV_NAME
842 ": %s: Warning: up delay (%d) is not a multiple " 843 ": %s: Warning: up delay (%d) is not a "
843 "of miimon (%d), updelay rounded to %d ms\n", 844 "multiple of miimon (%d), updelay rounded "
844 bond->dev->name, new_value, bond->params.miimon, 845 "to %d ms\n",
845 (new_value / bond->params.miimon) * 846 bond->dev->name, new_value,
846 bond->params.miimon); 847 bond->params.miimon,
848 (new_value / bond->params.miimon) *
849 bond->params.miimon);
847 } 850 }
848 bond->params.updelay = new_value / bond->params.miimon; 851 bond->params.updelay = new_value / bond->params.miimon;
849 pr_info(DRV_NAME ": %s: Setting up delay to %d.\n", 852 pr_info(DRV_NAME ": %s: Setting up delay to %d.\n",
@@ -1299,9 +1302,9 @@ static ssize_t bonding_store_active_slave(struct device *d,
1299 new_active = slave; 1302 new_active = slave;
1300 if (new_active == old_active) { 1303 if (new_active == old_active) {
1301 /* do nothing */ 1304 /* do nothing */
1302 printk(KERN_INFO DRV_NAME 1305 pr_info(DRV_NAME
1303 ": %s: %s is already the current active slave.\n", 1306 ": %s: %s is already the current active slave.\n",
1304 bond->dev->name, slave->dev->name); 1307 bond->dev->name, slave->dev->name);
1305 goto out; 1308 goto out;
1306 } 1309 }
1307 else { 1310 else {
@@ -1309,17 +1312,17 @@ static ssize_t bonding_store_active_slave(struct device *d,
1309 (old_active) && 1312 (old_active) &&
1310 (new_active->link == BOND_LINK_UP) && 1313 (new_active->link == BOND_LINK_UP) &&
1311 IS_UP(new_active->dev)) { 1314 IS_UP(new_active->dev)) {
1312 printk(KERN_INFO DRV_NAME 1315 pr_info(DRV_NAME
1313 ": %s: Setting %s as active slave.\n", 1316 ": %s: Setting %s as active slave.\n",
1314 bond->dev->name, slave->dev->name); 1317 bond->dev->name, slave->dev->name);
1315 bond_change_active_slave(bond, new_active); 1318 bond_change_active_slave(bond, new_active);
1316 } 1319 }
1317 else { 1320 else {
1318 printk(KERN_INFO DRV_NAME 1321 pr_info(DRV_NAME
1319 ": %s: Could not set %s as active slave; " 1322 ": %s: Could not set %s as active slave; "
1320 "either %s is down or the link is down.\n", 1323 "either %s is down or the link is down.\n",
1321 bond->dev->name, slave->dev->name, 1324 bond->dev->name, slave->dev->name,
1322 slave->dev->name); 1325 slave->dev->name);
1323 } 1326 }
1324 goto out; 1327 goto out;
1325 } 1328 }
@@ -1537,8 +1540,8 @@ int bond_create_sysfs(void)
1537 /* Is someone being kinky and naming a device bonding_master? */ 1540 /* Is someone being kinky and naming a device bonding_master? */
1538 if (__dev_get_by_name(&init_net, 1541 if (__dev_get_by_name(&init_net,
1539 class_attr_bonding_masters.attr.name)) 1542 class_attr_bonding_masters.attr.name))
1540 printk(KERN_ERR 1543 pr_err("network device named %s already "
1541 "network device named %s already exists in sysfs", 1544 "exists in sysfs",
1542 class_attr_bonding_masters.attr.name); 1545 class_attr_bonding_masters.attr.name);
1543 ret = 0; 1546 ret = 0;
1544 } 1547 }
@@ -1566,7 +1569,7 @@ int bond_create_sysfs_entry(struct bonding *bond)
1566 1569
1567 err = sysfs_create_group(&(dev->dev.kobj), &bonding_group); 1570 err = sysfs_create_group(&(dev->dev.kobj), &bonding_group);
1568 if (err) 1571 if (err)
1569 printk(KERN_EMERG "eek! didn't create group!\n"); 1572 pr_emerg("eek! didn't create group!\n");
1570 1573
1571 return err; 1574 return err;
1572} 1575}