aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/bonding/bond_alb.c
diff options
context:
space:
mode:
authorVeaceslav Falico <vfalico@redhat.com>2013-08-29 17:38:56 -0400
committerDavid S. Miller <davem@davemloft.net>2013-09-03 22:02:32 -0400
commit6f477d420183f7cacc73f46a93e12961cb234e91 (patch)
tree0baa9ee3f525c6a5b18b3fe5a7990813dc64557d /drivers/net/bonding/bond_alb.c
parentc12a22428ae773eff27bad490d35028fe036bf35 (diff)
bonding: remove bond_vlan_used()
We're using it currently to verify if we have vlans before getting the tag from the skb we're about to send. It's useless because the vlan_get_tag() verifies if the skb has the tag (and returns an error if not), and we can receive tagged skbs only if we *already* have vlans. Plus, the current RCUed implementation is kind of useless anyway - the we can remove the last vlan in the moment we return from the function. So remove the only usage of it and the whole function. CC: Jay Vosburgh <fubar@us.ibm.com> CC: Andy Gospodarek <andy@greyhouse.net> Signed-off-by: Veaceslav Falico <vfalico@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bonding/bond_alb.c')
-rw-r--r--drivers/net/bonding/bond_alb.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
index 018235263596..27b03fab60eb 100644
--- a/drivers/net/bonding/bond_alb.c
+++ b/drivers/net/bonding/bond_alb.c
@@ -694,10 +694,8 @@ static struct slave *rlb_choose_channel(struct sk_buff *skb, struct bonding *bon
694 client_info->ntt = 0; 694 client_info->ntt = 0;
695 } 695 }
696 696
697 if (bond_vlan_used(bond)) { 697 if (!vlan_get_tag(skb, &client_info->vlan_id))
698 if (!vlan_get_tag(skb, &client_info->vlan_id)) 698 client_info->tag = 1;
699 client_info->tag = 1;
700 }
701 699
702 if (!client_info->assigned) { 700 if (!client_info->assigned) {
703 u32 prev_tbl_head = bond_info->rx_hashtbl_used_head; 701 u32 prev_tbl_head = bond_info->rx_hashtbl_used_head;