diff options
author | Stanislaw Gruszka <sgruszka@redhat.com> | 2010-03-09 01:55:01 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-03-15 18:47:00 -0400 |
commit | 0efc22f3afa5d8f070a33fea06162d7d9d518e38 (patch) | |
tree | a4697a795999df7bfe11e89038e53664927195f9 /drivers/net/bnx2x_main.c | |
parent | 2d99cf16f42b1979a2c498bb6d09498dbd689978 (diff) |
bnx2x: remove not necessary compiler barrier
Access to fp->tx_bd_prod is protected by __netif_tx_lock, so we do not
need any barrier for that.
Update of fp->tx_bd_cons in bnx2x_tx_int() is not protected by lock, but
barrier() nor smb_mb() in bnx2x_tx_avail() not guarantee we will see
values that is written on other cpu. Ordering issues between
netif_tx_stop_queue(), netif_tx_queue_stopped(), fp->tx_bd_cons = bd_cons
and bnx2x_tx_avail() are already handled by smp_mb() in bnx2x_tx_int()
and bnx2x_start_xmit().
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bnx2x_main.c')
-rw-r--r-- | drivers/net/bnx2x_main.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c index 9fc0f6a7a5e9..ae62b67aa597 100644 --- a/drivers/net/bnx2x_main.c +++ b/drivers/net/bnx2x_main.c | |||
@@ -893,7 +893,6 @@ static inline u16 bnx2x_tx_avail(struct bnx2x_fastpath *fp) | |||
893 | u16 prod; | 893 | u16 prod; |
894 | u16 cons; | 894 | u16 cons; |
895 | 895 | ||
896 | barrier(); /* Tell compiler that prod and cons can change */ | ||
897 | prod = fp->tx_bd_prod; | 896 | prod = fp->tx_bd_prod; |
898 | cons = fp->tx_bd_cons; | 897 | cons = fp->tx_bd_cons; |
899 | 898 | ||