aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/bnx2x
diff options
context:
space:
mode:
authorJesse Gross <jesse@nicira.com>2010-10-20 09:56:03 -0400
committerDavid S. Miller <davem@davemloft.net>2010-10-21 04:26:52 -0400
commiteab6d18d20fc5b5ba04a7e7fcd6f357197870e51 (patch)
tree8a52538666747998dd16bc68a2102b05ebfe6873 /drivers/net/bnx2x
parentb738127dfb469bb9f595cdace30e7f881e8146b2 (diff)
vlan: Don't check for vlan group before vlan_tx_tag_present.
Many (but not all) drivers check to see whether there is a vlan group configured before using a tag stored in the skb. There's not much point in this check since it just throws away data that should only be present in the expected circumstances. However, it will soon be legal and expected to get a vlan tag when no vlan group is configured, so remove this check from all drivers to avoid dropping the tags. Signed-off-by: Jesse Gross <jesse@nicira.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bnx2x')
-rw-r--r--drivers/net/bnx2x/bnx2x_cmn.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/bnx2x/bnx2x_cmn.c b/drivers/net/bnx2x/bnx2x_cmn.c
index 1966ceeefcd4..6905b2e0609e 100644
--- a/drivers/net/bnx2x/bnx2x_cmn.c
+++ b/drivers/net/bnx2x/bnx2x_cmn.c
@@ -2026,8 +2026,7 @@ netdev_tx_t bnx2x_start_xmit(struct sk_buff *skb, struct net_device *dev)
2026 pkt_prod, tx_buf, fp->tx_pkt_prod, bd_prod, tx_start_bd); 2026 pkt_prod, tx_buf, fp->tx_pkt_prod, bd_prod, tx_start_bd);
2027 2027
2028#ifdef BCM_VLAN 2028#ifdef BCM_VLAN
2029 if ((bp->vlgrp != NULL) && vlan_tx_tag_present(skb) && 2029 if (vlan_tx_tag_present(skb)) {
2030 (bp->flags & HW_VLAN_TX_FLAG)) {
2031 tx_start_bd->vlan_or_ethertype = 2030 tx_start_bd->vlan_or_ethertype =
2032 cpu_to_le16(vlan_tx_tag_get(skb)); 2031 cpu_to_le16(vlan_tx_tag_get(skb));
2033 tx_start_bd->bd_flags.as_bitfield |= 2032 tx_start_bd->bd_flags.as_bitfield |=