diff options
author | Ben Hutchings <bhutchings@solarflare.com> | 2009-09-03 06:39:43 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-09-03 23:02:11 -0400 |
commit | 7ab0f2736bfe137a82a7084bbfb5f809da95cabd (patch) | |
tree | e305ec96eceebb285efee4b6fd307822ab257fe6 /drivers/net/bnx2.c | |
parent | aae5e7c30fc660c50dfecbdd745799b05af90f01 (diff) |
netdev: Remove redundant checks for CAP_NET_ADMIN in MDIO implementations
dev_ioctl() already checks capable(CAP_NET_ADMIN) before calling the
driver's implementation of MDIO ioctls.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bnx2.c')
-rw-r--r-- | drivers/net/bnx2.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 1357d548e698..08cddb6ff740 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c | |||
@@ -7480,9 +7480,6 @@ bnx2_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) | |||
7480 | } | 7480 | } |
7481 | 7481 | ||
7482 | case SIOCSMIIREG: | 7482 | case SIOCSMIIREG: |
7483 | if (!capable(CAP_NET_ADMIN)) | ||
7484 | return -EPERM; | ||
7485 | |||
7486 | if (bp->phy_flags & BNX2_PHY_FLAG_REMOTE_PHY_CAP) | 7483 | if (bp->phy_flags & BNX2_PHY_FLAG_REMOTE_PHY_CAP) |
7487 | return -EOPNOTSUPP; | 7484 | return -EOPNOTSUPP; |
7488 | 7485 | ||