aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/benet
diff options
context:
space:
mode:
authorAjit Khaparde <ajit.khaparde@emulex.com>2011-02-20 06:41:20 -0500
committerDavid S. Miller <davem@davemloft.net>2011-02-22 13:26:45 -0500
commit4ee772144f376ddf2a8c6ea5708a1362a9e85002 (patch)
treeb30e524d5de14dbe98e1dacc853100d8b84d297d /drivers/net/benet
parentf6c4bf3e6927e1cc98b33c64df93aa8964349195 (diff)
be2net: fixes in ethtool selftest
> add missing separator between items in ethtool self_test array > fix reporting of test resluts when link is down and when selftest command fails. From: Suresh R <suresh.reddy@emulex.com> Signed-off-by: Ajit Khaparde <ajit.khaparde@emulex.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/benet')
-rw-r--r--drivers/net/benet/be_ethtool.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/benet/be_ethtool.c b/drivers/net/benet/be_ethtool.c
index 82a9a27a9812..0833cbdb9b53 100644
--- a/drivers/net/benet/be_ethtool.c
+++ b/drivers/net/benet/be_ethtool.c
@@ -127,7 +127,7 @@ static const char et_self_tests[][ETH_GSTRING_LEN] = {
127 "MAC Loopback test", 127 "MAC Loopback test",
128 "PHY Loopback test", 128 "PHY Loopback test",
129 "External Loopback test", 129 "External Loopback test",
130 "DDR DMA test" 130 "DDR DMA test",
131 "Link test" 131 "Link test"
132}; 132};
133 133
@@ -642,7 +642,8 @@ be_self_test(struct net_device *netdev, struct ethtool_test *test, u64 *data)
642 &qos_link_speed) != 0) { 642 &qos_link_speed) != 0) {
643 test->flags |= ETH_TEST_FL_FAILED; 643 test->flags |= ETH_TEST_FL_FAILED;
644 data[4] = -1; 644 data[4] = -1;
645 } else if (mac_speed) { 645 } else if (!mac_speed) {
646 test->flags |= ETH_TEST_FL_FAILED;
646 data[4] = 1; 647 data[4] = 1;
647 } 648 }
648} 649}