ethtool: cosmetic: Use ethtool ethtool_cmd_speed API

This updates the network drivers so that they don't access the
ethtool_cmd::speed field directly, but use ethtool_cmd_speed()
instead.

For most of the drivers, these changes are purely cosmetic and don't
fix any problem, such as for those 1GbE/10GbE drivers that indirectly
call their own ethtool get_settings()/mii_ethtool_gset(). The changes
are meant to enforce code consistency and provide robustness with
future larger throughputs, at the expense of a few CPU cycles for each
ethtool operation.

All drivers compiled with make allyesconfig ion x86_64 have been
updated.

Tested: make allyesconfig on x86_64 + e1000e/bnx2x work
Signed-off-by: David Decotigny <decot@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 8 insertions, 8 deletions

diff --git a/drivers/net/benet/be_ethtool.c b/drivers/net/benet/be_ethtool.c
index 6565f3e55b26..8e770e8275df 100644
--- a/drivers/net/benet/be_ethtool.c
+++ b/drivers/net/benet/be_ethtool.c
@@ -381,23 +381,23 @@ static int be_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
                 be_link_status_update(adapter, link_up);
                 /* link_speed is in units of 10 Mbps */
                 if (link_speed) {
-                        ecmd->speed = link_speed*10;
+                        ethtool_cmd_speed_set(ecmd, link_speed*10);
                 } else {
                         switch (mac_speed) {
                         case PHY_LINK_SPEED_10MBPS:
-                                ecmd->speed = SPEED_10;
+                                ethtool_cmd_speed_set(ecmd, SPEED_10);
                                 break;
                         case PHY_LINK_SPEED_100MBPS:
-                                ecmd->speed = SPEED_100;
+                                ethtool_cmd_speed_set(ecmd, SPEED_100);
                                 break;
                         case PHY_LINK_SPEED_1GBPS:
-                                ecmd->speed = SPEED_1000;
+                                ethtool_cmd_speed_set(ecmd, SPEED_1000);
                                 break;
                         case PHY_LINK_SPEED_10GBPS:
-                                ecmd->speed = SPEED_10000;
+                                ethtool_cmd_speed_set(ecmd, SPEED_10000);
                                 break;
                         case PHY_LINK_SPEED_ZERO:
-                                ecmd->speed = 0;
+                                ethtool_cmd_speed_set(ecmd, 0);
                                 break;
                         }
                 }
@@ -440,14 +440,14 @@ static int be_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
                 }
 
                 /* Save for future use */
-                adapter->link_speed = ecmd->speed;
+                adapter->link_speed = ethtool_cmd_speed(ecmd);
                 adapter->port_type = ecmd->port;
                 adapter->transceiver = ecmd->transceiver;
                 adapter->autoneg = ecmd->autoneg;
                 dma_free_coherent(&adapter->pdev->dev, phy_cmd.size, phy_cmd.va,
                                   phy_cmd.dma);
         } else {
-                ecmd->speed = adapter->link_speed;
+                ethtool_cmd_speed_set(ecmd, adapter->link_speed);
                 ecmd->port = adapter->port_type;
                 ecmd->transceiver = adapter->transceiver;
                 ecmd->autoneg = adapter->autoneg;